From: Marco Stornelli <marco.stornelli@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Chris Mason <chris.mason@fusionio.com>,
Steve French <sfrench@samba.org>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Anton Altaparmakov <anton@tuxera.com>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
xfs@oss.sgi.com, Mike Snitzer <snitzer@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net,
linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com,
linux-mm@kvack.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called
Date: Sat, 06 Apr 2013 16:56:25 +0200 [thread overview]
Message-ID: <51603799.9070008@gmail.com> (raw)
In-Reply-To: <20130406131703.GC28744@parisc-linux.org>
Il 06/04/2013 15:17, Matthew Wilcox ha scritto:
> On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote:
>> In every place where sb_start_write was called now we must manage
>> the error code and return -EINTR.
>
> If we must manage the error code, then these functions should be marked
> __must_check.
>
Yep, good point.
Marco
WARNING: multiple messages have this Message-ID (diff)
From: Marco Stornelli <marco.stornelli@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Chris Mason <chris.mason@fusionio.com>, Jan Kara <jack@suse.cz>,
Mike Snitzer <snitzer@redhat.com>,
linux-mm@kvack.org, Andreas Dilger <adilger.kernel@dilger.ca>,
Alasdair G Kergon <agk@redhat.com>,
linux-cifs@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net,
Mark Fasheh <mfasheh@suse.com>,
xfs@oss.sgi.com, Ben Myers <bpm@sgi.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Anton Altaparmakov <anton@tuxera.com>,
Alex Elder <elder@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
linux-ntfs-dev@lists.sourceforge.net,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
Steve French <sfrench@samba.org>,
ocfs2-devel@oss.oracle.com,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
linux-btrfs@vger.kernel.org, Joel Becker <jlbec@evilplan.org>
Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called
Date: Sat, 06 Apr 2013 16:56:25 +0200 [thread overview]
Message-ID: <51603799.9070008@gmail.com> (raw)
In-Reply-To: <20130406131703.GC28744@parisc-linux.org>
Il 06/04/2013 15:17, Matthew Wilcox ha scritto:
> On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote:
>> In every place where sb_start_write was called now we must manage
>> the error code and return -EINTR.
>
> If we must manage the error code, then these functions should be marked
> __must_check.
>
Yep, good point.
Marco
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Marco Stornelli <marco.stornelli@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Chris Mason <chris.mason@fusionio.com>,
Steve French <sfrench@samba.org>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Anton Altaparmakov <anton@tuxera.com>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
xfs@oss.sgi.com, Mike Snitzer <snitzer@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net,
linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com,
linux-mm@kvack.org, Jan Kara <jack@suse.cz>
Subject: [Ocfs2-devel] [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called
Date: Sat, 06 Apr 2013 15:03:45 -0000 [thread overview]
Message-ID: <51603799.9070008@gmail.com> (raw)
In-Reply-To: <20130406131703.GC28744@parisc-linux.org>
Il 06/04/2013 15:17, Matthew Wilcox ha scritto:
> On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote:
>> In every place where sb_start_write was called now we must manage
>> the error code and return -EINTR.
>
> If we must manage the error code, then these functions should be marked
> __must_check.
>
Yep, good point.
Marco
WARNING: multiple messages have this Message-ID (diff)
From: Marco Stornelli <marco.stornelli@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Chris Mason <chris.mason@fusionio.com>,
Steve French <sfrench@samba.org>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Anton Altaparmakov <anton@tuxera.com>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
xfs@oss.sgi.com, Mike Snitzer <snitzer@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net,
linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com,
linux-mm@kvack.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called
Date: Sat, 06 Apr 2013 16:56:25 +0200 [thread overview]
Message-ID: <51603799.9070008@gmail.com> (raw)
In-Reply-To: <20130406131703.GC28744@parisc-linux.org>
Il 06/04/2013 15:17, Matthew Wilcox ha scritto:
> On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote:
>> In every place where sb_start_write was called now we must manage
>> the error code and return -EINTR.
>
> If we must manage the error code, then these functions should be marked
> __must_check.
>
Yep, good point.
Marco
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-06 14:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 10:04 [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called Marco Stornelli
2013-04-06 10:12 ` [Ocfs2-devel] " Marco Stornelli
2013-04-06 10:04 ` Marco Stornelli
2013-04-06 10:04 ` Marco Stornelli
2013-04-06 10:04 ` Marco Stornelli
2013-04-06 13:17 ` Matthew Wilcox
2013-04-06 13:17 ` [Ocfs2-devel] " Matthew Wilcox
2013-04-06 13:17 ` Matthew Wilcox
2013-04-06 13:17 ` Matthew Wilcox
2013-04-06 14:56 ` Marco Stornelli [this message]
2013-04-06 15:03 ` [Ocfs2-devel] " Marco Stornelli
2013-04-06 14:56 ` Marco Stornelli
2013-04-06 14:56 ` Marco Stornelli
[not found] ` <515FF344.8040705-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-06 21:50 ` Al Viro
2013-04-06 21:51 ` [Ocfs2-devel] " Al Viro
2013-04-06 21:50 ` Al Viro
2013-04-06 21:50 ` Al Viro
2013-04-06 21:50 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51603799.9070008@gmail.com \
--to=marco.stornelli@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=agk@redhat.com \
--cc=anton@tuxera.com \
--cc=bpm@sgi.com \
--cc=chris.mason@fusionio.com \
--cc=elder@kernel.org \
--cc=fuse-devel@lists.sourceforge.net \
--cc=jack@suse.cz \
--cc=jlbec@evilplan.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=matthew@wil.cx \
--cc=mfasheh@suse.com \
--cc=miklos@szeredi.hu \
--cc=ocfs2-devel@oss.oracle.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.