From: Stephen Warren <swarren@wwwdotorg.org>
To: Jay Agarwal <jagarwal@nvidia.com>
Cc: linux@arm.linux.org.uk, thierry.reding@avionic-design.de,
ldewangan@nvidia.com, bhelgaas@google.com, olof@lixom.net,
hdoyu@nvidia.com, pgaikwad@nvidia.com, mturquette@linaro.org,
pdeschrijver@nvidia.com, linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, jtukkinen@nvidia.com,
kthota@nvidia.com
Subject: Re: [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support
Date: Mon, 08 Apr 2013 12:21:47 -0600 [thread overview]
Message-ID: <51630ABB.1020200@wwwdotorg.org> (raw)
In-Reply-To: <1365435688-4179-1-git-send-email-jagarwal@nvidia.com>
On 04/08/2013 09:41 AM, Jay Agarwal wrote:
> Signed-off-by: Jay Agarwal <jagarwal@nvidia.com>
>
> - Enable pcie root port 2 for cardhu
> - Make private data structure for each SOC
> - Add required tegra3 clocks and regulators
> - Add tegra3 specific code in enable controller
> - Modify clock tree to get clocks based on device
> - Based on git://gitorious.org/thierryreding/linux.git
A couple more points on this patch:
* You didn't mention that this series is based on Thierry's
work-in-progress tree, and not something immediately destined for
upstream. As such, only Thierry is expected to actually apply any of
these patches.
* Your changes to the Tegra PCIe driver require that device tree include
extra clocks and regulators. You need to update
Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt to
describe these new requirements.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support
Date: Mon, 08 Apr 2013 12:21:47 -0600 [thread overview]
Message-ID: <51630ABB.1020200@wwwdotorg.org> (raw)
In-Reply-To: <1365435688-4179-1-git-send-email-jagarwal@nvidia.com>
On 04/08/2013 09:41 AM, Jay Agarwal wrote:
> Signed-off-by: Jay Agarwal <jagarwal@nvidia.com>
>
> - Enable pcie root port 2 for cardhu
> - Make private data structure for each SOC
> - Add required tegra3 clocks and regulators
> - Add tegra3 specific code in enable controller
> - Modify clock tree to get clocks based on device
> - Based on git://gitorious.org/thierryreding/linux.git
A couple more points on this patch:
* You didn't mention that this series is based on Thierry's
work-in-progress tree, and not something immediately destined for
upstream. As such, only Thierry is expected to actually apply any of
these patches.
* Your changes to the Tegra PCIe driver require that device tree include
extra clocks and regulators. You need to update
Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt to
describe these new requirements.
next prev parent reply other threads:[~2013-04-08 18:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 15:41 [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support Jay Agarwal
2013-04-08 15:41 ` Jay Agarwal
2013-04-08 15:41 ` Jay Agarwal
2013-04-08 15:41 ` [PATCH 2/3] ARM: dts: tegra: Correct PCIe entry Jay Agarwal
2013-04-08 15:41 ` Jay Agarwal
2013-04-08 15:41 ` Jay Agarwal
2013-04-08 18:27 ` Stephen Warren
2013-04-08 18:27 ` Stephen Warren
2013-04-09 8:30 ` Peter De Schrijver
2013-04-09 8:30 ` Peter De Schrijver
2013-04-09 15:46 ` Stephen Warren
2013-04-09 15:46 ` Stephen Warren
2013-04-12 15:03 ` Jay Agarwal
2013-04-12 15:03 ` Jay Agarwal
2013-04-12 15:03 ` Jay Agarwal
2013-04-08 15:41 ` [PATCH 3/3] ARM: dts: tegra: Add PCIe entry for cardhu Jay Agarwal
2013-04-08 15:41 ` Jay Agarwal
2013-04-08 15:41 ` Jay Agarwal
2013-04-08 18:32 ` Stephen Warren
2013-04-08 18:32 ` Stephen Warren
2013-04-08 18:11 ` [PATCH 1/3] ARM: tegra: pcie: Add tegra3 support Stephen Warren
2013-04-08 18:11 ` Stephen Warren
2013-04-12 14:58 ` Jay Agarwal
2013-04-12 14:58 ` Jay Agarwal
2013-04-12 14:58 ` Jay Agarwal
2013-04-12 15:34 ` Stephen Warren
2013-04-12 15:34 ` Stephen Warren
2013-04-13 10:23 ` Thierry Reding
2013-04-13 10:23 ` Thierry Reding
2013-04-08 18:21 ` Stephen Warren [this message]
2013-04-08 18:21 ` Stephen Warren
2013-04-12 16:43 ` Jay Agarwal
2013-04-12 16:43 ` Jay Agarwal
2013-04-12 16:43 ` Jay Agarwal
2013-04-12 17:01 ` Stephen Warren
2013-04-12 17:01 ` Stephen Warren
2013-04-12 17:06 ` Jay Agarwal
2013-04-12 17:06 ` Jay Agarwal
2013-04-12 18:29 ` Stephen Warren
2013-04-12 18:29 ` Stephen Warren
2013-04-10 17:23 ` Stephen Warren
2013-04-10 17:23 ` Stephen Warren
2013-04-10 17:23 ` Stephen Warren
2013-05-06 19:49 ` Stephen Warren
2013-05-06 19:49 ` Stephen Warren
2013-05-06 19:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51630ABB.1020200@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=bhelgaas@google.com \
--cc=hdoyu@nvidia.com \
--cc=jagarwal@nvidia.com \
--cc=jtukkinen@nvidia.com \
--cc=kthota@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.