Re: [PATCH 4/6] DT: MIPS: ralink: add RT2880 dts files

[Gabor Juhos <juhosg@openwrt.org>]

2013.04.13. 10:50 keltezéssel, John Crispin írta:
> Add a dtsi file for RT2880 SoC and a sample dts file.
> 
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
>  arch/mips/ralink/Kconfig             |    4 +++
>  arch/mips/ralink/dts/Makefile        |    1 +
>  arch/mips/ralink/dts/rt2880.dtsi     |   58 ++++++++++++++++++++++++++++++++++
>  arch/mips/ralink/dts/rt2880_eval.dts |   48 ++++++++++++++++++++++++++++
>  4 files changed, 111 insertions(+)
>  create mode 100644 arch/mips/ralink/dts/rt2880.dtsi
>  create mode 100644 arch/mips/ralink/dts/rt2880_eval.dts
> 
> diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
> index 86f6c77..2f6fbb8 100644
> --- a/arch/mips/ralink/Kconfig
> +++ b/arch/mips/ralink/Kconfig
> @@ -34,6 +34,10 @@ choice
>  	config DTB_RT_NONE
>  		bool "None"
>  
> +	config DTB_RT2880_EVAL
> +		bool "RT2880 eval kit"
> +		depends on SOC_RT288X
> +
>  	config DTB_RT305X_EVAL
>  		bool "RT305x eval kit"
>  		depends on SOC_RT305X
> diff --git a/arch/mips/ralink/dts/Makefile b/arch/mips/ralink/dts/Makefile
> index 1a69fb3..f635a01 100644
> --- a/arch/mips/ralink/dts/Makefile
> +++ b/arch/mips/ralink/dts/Makefile
> @@ -1 +1,2 @@
> +obj-$(CONFIG_DTB_RT2880_EVAL) := rt2880_eval.dtb.o
>  obj-$(CONFIG_DTB_RT305X_EVAL) := rt3052_eval.dtb.o
> diff --git a/arch/mips/ralink/dts/rt2880.dtsi b/arch/mips/ralink/dts/rt2880.dtsi
> new file mode 100644
> index 0000000..182afde
> --- /dev/null
> +++ b/arch/mips/ralink/dts/rt2880.dtsi
> @@ -0,0 +1,58 @@
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	compatible = "ralink,rt2880-soc";
> +
> +	cpus {
> +		cpu@0 {
> +			compatible = "mips,mips4KEc";
> +		};
> +	};
> +
> +	cpuintc: cpuintc@0 {
> +		#address-cells = <0>;
> +		#interrupt-cells = <1>;
> +		interrupt-controller;
> +		compatible = "mti,cpu-interrupt-controller";
> +	};
> +
> +	palmbus@300000 {
> +		compatible = "palmbus";
> +		reg = <0x300000 0x200000>;
> +                ranges = <0x0 0x300000 0x1FFFFF>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		sysc@0 {
> +			compatible = "ralink,rt2880-sysc";
> +			reg = <0x0 0x100>;
> +		};
> +
> +		intc: intc@200 {
> +			compatible = "ralink,rt2880-intc";
> +			reg = <0x200 0x100>;
> +
> +			interrupt-controller;
> +			#interrupt-cells = <1>;
> +
> +			interrupt-parent = <&cpuintc>;
> +			interrupts = <2>;
> +		};
> +
> +		memc@300 {
> +			compatible = "ralink,rt2880-memc";
> +			reg = <0x300 0x100>;
> +		};
> +
> +		uartlite@c00 {
> +			compatible = "ralink,rt2880-uart", "ns16550a";
> +			reg = <0xc00 0x100>;
> +
> +			interrupt-parent = <&intc>;
> +			interrupts = <8>;
> +
> +			reg-shift = <2>;
> +		};
> +	};
> +};
> diff --git a/arch/mips/ralink/dts/rt2880_eval.dts b/arch/mips/ralink/dts/rt2880_eval.dts
> new file mode 100644
> index 0000000..e967b43
> --- /dev/null
> +++ b/arch/mips/ralink/dts/rt2880_eval.dts
> @@ -0,0 +1,48 @@
> +/dts-v1/;
> +
> +/include/ "rt2880.dtsi"
> +
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;

These -cells properties are superfluous, because the rt2880.dtsi file contains
these already.

-Gabor