All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabor Juhos <juhosg@openwrt.org>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 5/6] DT: MIPS: ralink: add RT3883 dts files
Date: Sun, 14 Apr 2013 11:54:58 +0200	[thread overview]
Message-ID: <516A7CF2.6020507@openwrt.org> (raw)
In-Reply-To: <1365843026-11015-5-git-send-email-blogic@openwrt.org>

2013.04.13. 10:50 keltezéssel, John Crispin írta:
> Add a dtsi file for RT3883 SoC and a sample dts file.
> 
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
>  arch/mips/ralink/Kconfig             |    4 +++
>  arch/mips/ralink/dts/Makefile        |    1 +
>  arch/mips/ralink/dts/rt3883.dtsi     |   58 ++++++++++++++++++++++++++++++++++
>  arch/mips/ralink/dts/rt3883_eval.dts |   18 +++++++++++
>  4 files changed, 81 insertions(+)
>  create mode 100644 arch/mips/ralink/dts/rt3883.dtsi
>  create mode 100644 arch/mips/ralink/dts/rt3883_eval.dts

<...>

> diff --git a/arch/mips/ralink/dts/rt3883.dtsi b/arch/mips/ralink/dts/rt3883.dtsi
> new file mode 100644
> index 0000000..3b131dd
> --- /dev/null
> +++ b/arch/mips/ralink/dts/rt3883.dtsi
> @@ -0,0 +1,58 @@
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	compatible = "ralink,rt3883-soc";
> +

<...>

> diff --git a/arch/mips/ralink/dts/rt3883_eval.dts b/arch/mips/ralink/dts/rt3883_eval.dts
> new file mode 100644
> index 0000000..0297f20
> --- /dev/null
> +++ b/arch/mips/ralink/dts/rt3883_eval.dts
> @@ -0,0 +1,18 @@
> +/dts-v1/;
> +
> +/include/ "rt3883.dtsi"
> +
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;

These -cells properties are superfluous, because the rt3883.dtsi file contains
these already.

-Gabor

WARNING: multiple messages have this Message-ID (diff)
From: Gabor Juhos <juhosg-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Subject: Re: [PATCH 5/6] DT: MIPS: ralink: add RT3883 dts files
Date: Sun, 14 Apr 2013 11:54:58 +0200	[thread overview]
Message-ID: <516A7CF2.6020507@openwrt.org> (raw)
In-Reply-To: <1365843026-11015-5-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>

2013.04.13. 10:50 keltezéssel, John Crispin írta:
> Add a dtsi file for RT3883 SoC and a sample dts file.
> 
> Signed-off-by: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
> ---
>  arch/mips/ralink/Kconfig             |    4 +++
>  arch/mips/ralink/dts/Makefile        |    1 +
>  arch/mips/ralink/dts/rt3883.dtsi     |   58 ++++++++++++++++++++++++++++++++++
>  arch/mips/ralink/dts/rt3883_eval.dts |   18 +++++++++++
>  4 files changed, 81 insertions(+)
>  create mode 100644 arch/mips/ralink/dts/rt3883.dtsi
>  create mode 100644 arch/mips/ralink/dts/rt3883_eval.dts

<...>

> diff --git a/arch/mips/ralink/dts/rt3883.dtsi b/arch/mips/ralink/dts/rt3883.dtsi
> new file mode 100644
> index 0000000..3b131dd
> --- /dev/null
> +++ b/arch/mips/ralink/dts/rt3883.dtsi
> @@ -0,0 +1,58 @@
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	compatible = "ralink,rt3883-soc";
> +

<...>

> diff --git a/arch/mips/ralink/dts/rt3883_eval.dts b/arch/mips/ralink/dts/rt3883_eval.dts
> new file mode 100644
> index 0000000..0297f20
> --- /dev/null
> +++ b/arch/mips/ralink/dts/rt3883_eval.dts
> @@ -0,0 +1,18 @@
> +/dts-v1/;
> +
> +/include/ "rt3883.dtsi"
> +
> +/ {
> +	#address-cells = <1>;
> +	#size-cells = <1>;

These -cells properties are superfluous, because the rt3883.dtsi file contains
these already.

-Gabor

  reply	other threads:[~2013-04-14  9:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13  8:50 [PATCH 1/6] DT: add vendor prefixes for Ralink John Crispin
2013-04-13  8:50 ` [PATCH 2/6] DT: add documentation for the Ralink MIPS SoCs John Crispin
2013-04-14  9:44   ` Gabor Juhos
2013-04-13  8:50 ` [PATCH 3/6] DT: MIPS: ralink: extend RT3050 dtsi and dts file John Crispin
2013-04-13 14:49   ` Sergei Shtylyov
2013-04-13 17:59     ` John Crispin
2013-04-14  9:50       ` Gabor Juhos
2013-04-13  8:50 ` [PATCH 4/6] DT: MIPS: ralink: add RT2880 dts files John Crispin
2013-04-14  9:53   ` Gabor Juhos
2013-04-14  9:53     ` Gabor Juhos
2013-08-23 18:34   ` Sergei Shtylyov
2013-08-23 18:37     ` Sergei Shtylyov
2013-08-23 18:44     ` David Daney
2013-04-13  8:50 ` [PATCH 5/6] DT: MIPS: ralink: add RT3883 " John Crispin
2013-04-14  9:54   ` Gabor Juhos [this message]
2013-04-14  9:54     ` Gabor Juhos
2013-04-13  8:50 ` [PATCH 6/6] DT: MIPS: ralink: add MT7620 " John Crispin
2013-04-14 11:41   ` Gabor Juhos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516A7CF2.6020507@openwrt.org \
    --to=juhosg@openwrt.org \
    --cc=blogic@openwrt.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.