[meta-fsl-arm PATCH v3 0/13] Fixes current found issues for 1.4 release

[meta-fsl-arm PATCH v3 0/13] Fixes current found issues for 1.4 release

[Otavio Salvador]

We've runned full build of 'fsl-image-gui' image in O.S. Systems build
server for ALL machines in meta-fsl-arm and meta-fsl-arm-extra, the
final build list is:

 cgtqmx6 ok
 imx233-olinuxino-maxi ok
 imx233-olinuxino-micro ok
 imx233-olinuxino-mini ok
 imx23evk ok
 imx28evk ok
 imx31pdk ok
 imx35pdk ok
 imx51evk ok
 imx53ard ok
 imx53qsb ok
 imx6dlsabresd ok
 imx6qsabreauto ok
 imx6qsabrelite ok
 imx6qsabresd ok
 imx6slevk ok
 nitrogen6x ok
 wandboard-dual ok
 wandboard-solo ok

The 'imx31pdk' and 'imx35pdk' machines depends on the 'fio' patch we
sent to Meta-OpenEmbedded to add support for ARMv6 assembly code but
appart from that those are the needed fixes.

Please give them a try so these can be merged soon.

Changes in v3:
- Fix commit log U-Boot version
- New patch
- New patch
- New patch
- New patch
- New patch

Changes in v2:
- Remove change of i.MX6SL entry point format, for another patch
- New patch
- New patch
- Improve commit log
- New patch

Otavio Salvador (13):
  u-boot-fslc: Update to patches-2013.04's 20130410 snapshot
  imx6dlsabresd: Use U-Boot 2009.08 from Freescale
  gst-fsl-plugin (3.0.6): Fix the tarball's checksum
  gst-fsl-plugin (3.0.6): Add 'virtual/kernel' dependency
  imx-base.inc: Disable firmware include for not fully supported BSPs
  imx-base.inc: Avoid including imx-audio for every SoC family
  imx-base.inc: Override GStreamer plugins for i.MX3
  imx-base.inc: Fix i.MX6SL entry point hex format
  imx-base.inc: Do not assign UBOOT_LOADADDRESS
  Fix use of SOC_FAMILY as the most right value is preferred
  xf86-dri-vivante: Ensure install fails if .la cannot be removed
  xf86-dri-vivante: Fix DRI module name
  xf86-video-imxfb-vivante: Enable software rendering support

 conf/machine/imx23evk.conf                         |  2 +-
 conf/machine/imx28evk.conf                         |  2 +-
 conf/machine/imx31pdk.conf                         |  2 +-
 conf/machine/imx35pdk.conf                         |  2 +-
 conf/machine/imx51evk.conf                         |  2 +-
 conf/machine/imx53ard.conf                         |  2 +-
 conf/machine/imx53qsb.conf                         |  2 +-
 conf/machine/imx6dlsabresd.conf                    |  4 +++-
 conf/machine/imx6qsabreauto.conf                   |  2 +-
 conf/machine/imx6qsabresd.conf                     |  2 +-
 conf/machine/imx6slevk.conf                        |  2 +-
 conf/machine/include/imx-base.inc                  | 24 ++++++++++------------
 recipes-bsp/u-boot/u-boot-fslc_2013.04.bb          |  2 +-
 recipes-bsp/u-boot/u-boot-mxsboot_2013.04.bb       |  2 +-
 .../xorg-driver/xf86-dri-vivante_1.1.0.bb          |  8 ++++++--
 .../xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb  |  2 +-
 .../gst-plugins/gst-fsl-plugin_3.0.6.bb            |  8 ++++----
 17 files changed, 37 insertions(+), 33 deletions(-)

-- 
1.8.1

[meta-fsl-arm PATCH v3 01/13] u-boot-fslc: Update to patches-2013.04's 20130410 snapshot

[Otavio Salvador]

Include following fixes:

 * i.MX6Q SabreSD/SabreAUTO: Environment fix for 'mmc rescan'
 * i.MX6SL EVK: Fix memory size

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2:
- Remove change of i.MX6SL entry point format, for another patch

 recipes-bsp/u-boot/u-boot-fslc_2013.04.bb    | 2 +-
 recipes-bsp/u-boot/u-boot-mxsboot_2013.04.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-bsp/u-boot/u-boot-fslc_2013.04.bb b/recipes-bsp/u-boot/u-boot-fslc_2013.04.bb
index 01b9d59..f339996 100644
--- a/recipes-bsp/u-boot/u-boot-fslc_2013.04.bb
+++ b/recipes-bsp/u-boot/u-boot-fslc_2013.04.bb
@@ -10,7 +10,7 @@ PROVIDES += "u-boot"
 
 PV = "v2013.04"
 
-SRCREV = "7e2cfc83e91229e2573a3b51aec9e8c9fd27ed79"
+SRCREV = "debad5d6cba77538d183ac947a41f6b88f9498b2"
 SRC_URI = "git://github.com/Freescale/u-boot-imx.git"
 
 S = "${WORKDIR}/git"
diff --git a/recipes-bsp/u-boot/u-boot-mxsboot_2013.04.bb b/recipes-bsp/u-boot/u-boot-mxsboot_2013.04.bb
index b6c271f..0ef48a2 100644
--- a/recipes-bsp/u-boot/u-boot-mxsboot_2013.04.bb
+++ b/recipes-bsp/u-boot/u-boot-mxsboot_2013.04.bb
@@ -5,7 +5,7 @@ SECTION = "bootloader"
 
 PV = "v2013.04"
 
-SRCREV = "7e2cfc83e91229e2573a3b51aec9e8c9fd27ed79"
+SRCREV = "debad5d6cba77538d183ac947a41f6b88f9498b2"
 SRC_URI = "git://github.com/Freescale/u-boot-imx.git"
 
 S = "${WORKDIR}/git"
-- 
1.8.1

[meta-fsl-arm PATCH v3 02/13] imx6dlsabresd: Use U-Boot 2009.08 from Freescale

[Otavio Salvador]

The U-Boot 2013.04 does not has support for i.MX6DL SabreSD so ensure
we use U-Boot 2009.08 until it is added.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3:
- Fix commit log U-Boot version

Changes in v2:
- New patch

 conf/machine/imx6dlsabresd.conf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/conf/machine/imx6dlsabresd.conf b/conf/machine/imx6dlsabresd.conf
index 754b555..215ec1b 100644
--- a/conf/machine/imx6dlsabresd.conf
+++ b/conf/machine/imx6dlsabresd.conf
@@ -7,6 +7,8 @@ include conf/machine/include/tune-cortexa9.inc
 
 SOC_FAMILY = "mx6dl:mx6"
 
+PREFERRED_PROVIDER_u-boot = "u-boot-imx"
+
 UBOOT_MACHINE = "mx6dl_sabresd_config"
 UBOOT_SUFFIX = "bin"
 UBOOT_PADDING = "2"
-- 
1.8.1

[meta-fsl-arm PATCH v3 03/13] gst-fsl-plugin (3.0.6): Fix the tarball's checksum

[Otavio Salvador]

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3:
- New patch

Changes in v2: None

 recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
index 4c28442..0f5d5c3 100644
--- a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
+++ b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
@@ -5,7 +5,7 @@ require gst-fsl-plugin.inc
 
 DEPENDS = "gstreamer gst-plugins-base libfslcodec libfslparser"
 
-PR = "${INC_PR}.0"
+PR = "${INC_PR}.1"
 
 SRC_URI += "file://fix-missing-sys-types-h.patch \
             file://Link-with-the-Real-Time-Extension-lib.patch \
@@ -13,7 +13,7 @@ SRC_URI += "file://fix-missing-sys-types-h.patch \
 
 PACKAGE_NAME = "gst-fsl-plugins"
 
-SRC_URI[md5sum] = "fd7c9db129cbcc4dc79b7dd832061594"
-SRC_URI[sha256sum] = "546deb407993f726ef4e140f5bd734d612d5f8872c832ac820957f667f22306e"
+SRC_URI[md5sum] = "5416a727e8b0bd94eec077ac7d70aae7"
+SRC_URI[sha256sum] = "fdb0b5ab964f607a93664412702a131931da8ef0b557597cbf161c3d9c9d0c12"
 
 COMPATIBLE_MACHINE = "(mx28)"
-- 
1.8.1

[meta-fsl-arm PATCH v3 04/13] gst-fsl-plugin (3.0.6): Add 'virtual/kernel' dependency

[Otavio Salvador]

The code includes kernel headers during the build so the kernel needs
to be built before doing the gst-fsl-plugins build.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3:
- New patch

Changes in v2: None

 recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
index 0f5d5c3..77baa9a 100644
--- a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
+++ b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
@@ -3,7 +3,7 @@
 
 require gst-fsl-plugin.inc
 
-DEPENDS = "gstreamer gst-plugins-base libfslcodec libfslparser"
+DEPENDS = "virtual/kernel gstreamer gst-plugins-base libfslcodec libfslparser"
 
 PR = "${INC_PR}.1"
 
-- 
1.8.1

[meta-fsl-arm PATCH v3 05/13] imx-base.inc: Disable firmware include for not fully supported BSPs

[Otavio Salvador]

The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
don't have the firmware package for them so comment them out so it
doesn't break the build.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3:
- New patch

Changes in v2: None

 conf/machine/include/imx-base.inc | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index b421807..de48e98 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -44,10 +44,12 @@ MACHINE_FIRMWARE_mx6d = "firmware-imx-vpu-imx6d"
 MACHINE_FIRMWARE_mx6dl = "firmware-imx-vpu-imx6d"
 MACHINE_FIRMWARE_mx53 = "firmware-imx-vpu-imx53 firmware-imx-sdma-imx53"
 MACHINE_FIRMWARE_mx51 = "firmware-imx-vpu-imx51 firmware-imx-sdma-imx51"
-MACHINE_FIRMWARE_mx35 = "firmware-imx-sdma-imx35"
-MACHINE_FIRMWARE_mx31 = "firmware-imx-sdma-imx31"
-MACHINE_FIRMWARE_mx27 = "firmware-imx-vpu-imx27"
-MACHINE_FIRMWARE_mx25 = "firmware-imx-sdma-imx25"
+
+# FIXME: Needs addition of firmware-imx of official BSPs
+#MACHINE_FIRMWARE_mx35 = "firmware-imx-sdma-imx35"
+#MACHINE_FIRMWARE_mx31 = "firmware-imx-sdma-imx31"
+#MACHINE_FIRMWARE_mx27 = "firmware-imx-vpu-imx27"
+#MACHINE_FIRMWARE_mx25 = "firmware-imx-sdma-imx25"
 
 MACHINE_EXTRA_RRECOMMENDS += "${MACHINE_FIRMWARE}"
 
-- 
1.8.1

[meta-fsl-arm PATCH v3 06/13] imx-base.inc: Avoid including imx-audio for every SoC family

[Otavio Salvador]

The imx-audio package is currently only available for i.MX5 and i.MX6
so we should include it in every SoC family. This fixes i.MX31 and
i.MX35 image build due unsatisfied dependency.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3:
- New patch

Changes in v2: None

 conf/machine/include/imx-base.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index de48e98..56a0f92 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -54,7 +54,9 @@ MACHINE_FIRMWARE_mx51 = "firmware-imx-vpu-imx51 firmware-imx-sdma-imx51"
 MACHINE_EXTRA_RRECOMMENDS += "${MACHINE_FIRMWARE}"
 
 # Extra audio support
-MACHINE_EXTRA_RRECOMMENDS += "imx-audio"
+# FIXME: Add support for ALL SoC families
+MACHINE_EXTRA_RRECOMMENDS_append_mx5 = " imx-audio"
+MACHINE_EXTRA_RRECOMMENDS_append_mx6 = " imx-audio"
 
 # Extra udev rules
 MACHINE_EXTRA_RRECOMMENDS += "udev-extraconf"
-- 
1.8.1

[meta-fsl-arm PATCH v3 07/13] imx-base.inc: Override GStreamer plugins for i.MX3

[Otavio Salvador]

i.MX3 doesn't has GStreamer plugins packaged so we need to avoid its
installation for now.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3:
- New patch

Changes in v2: None

 conf/machine/include/imx-base.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index 56a0f92..456bbfb 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -63,6 +63,7 @@ MACHINE_EXTRA_RRECOMMENDS += "udev-extraconf"
 
 # Gstreamer plugin
 MACHINE_GSTREAMER_PLUGIN ?= "gst-fsl-plugin"
+MACHINE_GSTREAMER_PLUGIN_mx3 ?= ""
 
 # mx5 GPU libraries
 PREFERRED_PROVIDER_virtual/egl_mx5 ?= "amd-gpu-x11-bin-mx51"
-- 
1.8.1

[meta-fsl-arm PATCH v3 08/13] imx-base.inc: Fix i.MX6SL entry point hex format

[Otavio Salvador]

Trivial change just to make it using same code style as other entry
point values.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2:
- New patch

 conf/machine/include/imx-base.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index 456bbfb..2cc8b70 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -22,8 +22,8 @@ UBOOT_LOADADDRESS_mx53 = "0x70800000"
 UBOOT_ENTRYPOINT_mx6  = "0x10800000"
 UBOOT_LOADADDRESS_mx6 = "0x10800000"
 
-UBOOT_ENTRYPOINT_mx6sl = "0X80800000"
-UBOOT_LOADADDRESS_mx6sl = "0X80800000"
+UBOOT_ENTRYPOINT_mx6sl = "0x80800000"
+UBOOT_LOADADDRESS_mx6sl = "0x80800000"
 
 PREFERRED_VERSION_xserver-xorg_mx6 = "2:1.11.4"
 
-- 
1.8.1

[meta-fsl-arm PATCH v3 09/13] imx-base.inc: Do not assign UBOOT_LOADADDRESS

[Otavio Salvador]

The code uses UBOOT_ENTRYPOINT as default value for UBOOT_LOADADDRESS
so we don't need to have the variable UBOOT_LOADADDRESS set unless
it's different from UBOOT_ENTRYPOINT.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2:
- Improve commit log

 conf/machine/include/imx-base.inc | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index 2cc8b70..c761626 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -14,16 +14,9 @@ UBOOT_MAKE_TARGET = "u-boot.imx"
 UBOOT_SUFFIX ?= "imx"
 
 UBOOT_ENTRYPOINT_mx51  = "0xa0000000"
-UBOOT_LOADADDRESS_mx51 = "0xa0000000"
-
 UBOOT_ENTRYPOINT_mx53  = "0x70800000"
-UBOOT_LOADADDRESS_mx53 = "0x70800000"
-
 UBOOT_ENTRYPOINT_mx6  = "0x10800000"
-UBOOT_LOADADDRESS_mx6 = "0x10800000"
-
 UBOOT_ENTRYPOINT_mx6sl = "0x80800000"
-UBOOT_LOADADDRESS_mx6sl = "0x80800000"
 
 PREFERRED_VERSION_xserver-xorg_mx6 = "2:1.11.4"
 
-- 
1.8.1

[meta-fsl-arm PATCH v3 10/13] Fix use of SOC_FAMILY as the most right value is preferred

[Otavio Salvador]

The SOC_FAMILY uses the MACHINEOVERRIDES and it evaluates from left to
right. In this case, the most SoC specific value needs to be kept in
the right so it take precedence.

This has been catch when finding out why i.MX6SL EVK where using the
wrong value as entry point, and this was the root cause.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2: None

 conf/machine/imx23evk.conf       | 2 +-
 conf/machine/imx28evk.conf       | 2 +-
 conf/machine/imx31pdk.conf       | 2 +-
 conf/machine/imx35pdk.conf       | 2 +-
 conf/machine/imx51evk.conf       | 2 +-
 conf/machine/imx53ard.conf       | 2 +-
 conf/machine/imx53qsb.conf       | 2 +-
 conf/machine/imx6dlsabresd.conf  | 2 +-
 conf/machine/imx6qsabreauto.conf | 2 +-
 conf/machine/imx6qsabresd.conf   | 2 +-
 conf/machine/imx6slevk.conf      | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/conf/machine/imx23evk.conf b/conf/machine/imx23evk.conf
index a5c0f98..80a771f 100644
--- a/conf/machine/imx23evk.conf
+++ b/conf/machine/imx23evk.conf
@@ -4,7 +4,7 @@
 
 include conf/machine/include/mxs-base.inc
 
-SOC_FAMILY = "mx23:mxs"
+SOC_FAMILY = "mxs:mx23"
 
 IMXBOOTLETS_MACHINE = "stmp378x_dev"
 UBOOT_MACHINE = "mx23evk_config"
diff --git a/conf/machine/imx28evk.conf b/conf/machine/imx28evk.conf
index df00203..d80e9d9 100644
--- a/conf/machine/imx28evk.conf
+++ b/conf/machine/imx28evk.conf
@@ -4,7 +4,7 @@
 
 include conf/machine/include/mxs-base.inc
 
-SOC_FAMILY = "mx28:mxs"
+SOC_FAMILY = "mxs:mx28"
 
 IMXBOOTLETS_MACHINE = "iMX28_EVK"
 UBOOT_MACHINE = "mx28evk_config"
diff --git a/conf/machine/imx31pdk.conf b/conf/machine/imx31pdk.conf
index 9b6da31..3aa6606 100644
--- a/conf/machine/imx31pdk.conf
+++ b/conf/machine/imx31pdk.conf
@@ -6,7 +6,7 @@ include conf/machine/include/soc-family.inc
 include conf/machine/include/imx-base.inc
 require conf/machine/include/tune-arm1136jf-s.inc
 
-SOC_FAMILY = "mx31:mx3"
+SOC_FAMILY = "mx3:mx31"
 
 GUI_MACHINE_CLASS = "smallscreen"
 
diff --git a/conf/machine/imx35pdk.conf b/conf/machine/imx35pdk.conf
index 62e6930..2d48699 100644
--- a/conf/machine/imx35pdk.conf
+++ b/conf/machine/imx35pdk.conf
@@ -6,7 +6,7 @@ include conf/machine/include/soc-family.inc
 include conf/machine/include/imx-base.inc
 require conf/machine/include/tune-arm1136jf-s.inc
 
-SOC_FAMILY = "mx35:mx3"
+SOC_FAMILY = "mx3:mx35"
 
 UBOOT_ENTRYPOINT = "0x80008000"
 UBOOT_LOADADDRESS = "0x80008000"
diff --git a/conf/machine/imx51evk.conf b/conf/machine/imx51evk.conf
index 2e27ed7..8ac38f0 100644
--- a/conf/machine/imx51evk.conf
+++ b/conf/machine/imx51evk.conf
@@ -5,7 +5,7 @@
 include conf/machine/include/imx-base.inc
 include conf/machine/include/tune-cortexa8.inc
 
-SOC_FAMILY = "mx51:mx5"
+SOC_FAMILY = "mx5:mx51"
 
 KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx51-babbage.dts"
 
diff --git a/conf/machine/imx53ard.conf b/conf/machine/imx53ard.conf
index 4f15493..20898c4 100644
--- a/conf/machine/imx53ard.conf
+++ b/conf/machine/imx53ard.conf
@@ -5,7 +5,7 @@
 include conf/machine/include/imx-base.inc
 include conf/machine/include/tune-cortexa8.inc
 
-SOC_FAMILY = "mx53:mx5"
+SOC_FAMILY = "mx5:mx53"
 
 KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx53-ard.dts"
 
diff --git a/conf/machine/imx53qsb.conf b/conf/machine/imx53qsb.conf
index 9aec913..1a95a71 100644
--- a/conf/machine/imx53qsb.conf
+++ b/conf/machine/imx53qsb.conf
@@ -5,7 +5,7 @@
 include conf/machine/include/imx-base.inc
 include conf/machine/include/tune-cortexa8.inc
 
-SOC_FAMILY = "mx53:mx5"
+SOC_FAMILY = "mx5:mx53"
 
 KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx53-qsb.dts"
 
diff --git a/conf/machine/imx6dlsabresd.conf b/conf/machine/imx6dlsabresd.conf
index 215ec1b..99c9b85 100644
--- a/conf/machine/imx6dlsabresd.conf
+++ b/conf/machine/imx6dlsabresd.conf
@@ -5,7 +5,7 @@
 include conf/machine/include/imx-base.inc
 include conf/machine/include/tune-cortexa9.inc
 
-SOC_FAMILY = "mx6dl:mx6"
+SOC_FAMILY = "mx6:mx6dl"
 
 PREFERRED_PROVIDER_u-boot = "u-boot-imx"
 
diff --git a/conf/machine/imx6qsabreauto.conf b/conf/machine/imx6qsabreauto.conf
index 6f0bd8c..8ebd156 100644
--- a/conf/machine/imx6qsabreauto.conf
+++ b/conf/machine/imx6qsabreauto.conf
@@ -5,7 +5,7 @@
 include conf/machine/include/imx-base.inc
 include conf/machine/include/tune-cortexa9.inc
 
-SOC_FAMILY = "mx6q:mx6"
+SOC_FAMILY = "mx6:mx6q"
 
 KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx6q-sabreauto.dts"
 
diff --git a/conf/machine/imx6qsabresd.conf b/conf/machine/imx6qsabresd.conf
index d5a5192..67bdc65 100644
--- a/conf/machine/imx6qsabresd.conf
+++ b/conf/machine/imx6qsabresd.conf
@@ -5,7 +5,7 @@
 include conf/machine/include/imx-base.inc
 include conf/machine/include/tune-cortexa9.inc
 
-SOC_FAMILY = "mx6q:mx6"
+SOC_FAMILY = "mx6:mx6q"
 
 KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx6q-sabresd.dts"
 
diff --git a/conf/machine/imx6slevk.conf b/conf/machine/imx6slevk.conf
index 454c34f..78bc24b 100644
--- a/conf/machine/imx6slevk.conf
+++ b/conf/machine/imx6slevk.conf
@@ -5,7 +5,7 @@
 include conf/machine/include/imx-base.inc
 include conf/machine/include/tune-cortexa9.inc
 
-SOC_FAMILY = "mx6sl:mx6"
+SOC_FAMILY = "mx6:mx6sl"
 
 UBOOT_MACHINE = "mx6slevk_config"
 
-- 
1.8.1

[meta-fsl-arm PATCH v3 11/13] xf86-dri-vivante: Ensure install fails if .la cannot be removed

[Otavio Salvador]

To ensure we catch when the makefile stops to install the .la file, we
ensure the install fails in case .la file does not exist.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2: None

 recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
index aa2361a..975041d 100644
--- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
@@ -28,8 +28,8 @@ do_install_append () {
     cp -axr ${S}/src/*.h ${D}${includedir}/xorg
     find ${D}${includedir} -type f -exec chmod 660 {} \;
 
-    # don't install libtool (*.la) archive not usefull, fix Makefile.am
-    find ${D}${libdir}/xorg/modules -regex ".*\.la$" | xargs rm -f --
+    # FIXME: don't install libtool (*.la) file
+    rm ${D}${libdir}/xorg/modules/extensions/*.la
 }
 
 FILES_${PN}-dev += "${includedir}/xorg/*.h"
-- 
1.8.1

[meta-fsl-arm PATCH v3 12/13] xf86-dri-vivante: Fix DRI module name

[Otavio Salvador]

The Xorg Vivante driver has a hardcoded module name as 'vivante_dri'
so we need to rename it for full Xorg acceleration to work.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2: None

 recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
index 975041d..6e8f8db 100644
--- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
@@ -30,6 +30,10 @@ do_install_append () {
 
     # FIXME: don't install libtool (*.la) file
     rm ${D}${libdir}/xorg/modules/extensions/*.la
+
+    # FIXME: The Xorg driver has a hardcoded library name
+    mv ${D}${libdir}/xorg/modules/extensions/libdri.so \
+       ${D}${libdir}/xorg/modules/extensions/libvivante_dri.so
 }
 
 FILES_${PN}-dev += "${includedir}/xorg/*.h"
-- 
1.8.1

[meta-fsl-arm PATCH v3 13/13] xf86-video-imxfb-vivante: Enable software rendering support

[Otavio Salvador]

This is used by Vivante for 2D acceleration support. Fixes some
slowness seen when testing GUI images.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2:
- New patch

 recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb
index 837b59c..22e8d6e 100644
--- a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb
@@ -36,7 +36,7 @@ do_install_append () {
 	find ${D}${includedir} -type f -exec chmod 660 {} \;
 }
 
-RDEPENDS_${PN} += "xserver-xorg-module-exa xf86-dri-vivante"
+RDEPENDS_${PN} += "xserver-xorg-module-exa mesa-driver-swrast xf86-dri-vivante"
 
 # Add the ABI dependency at package generation time, as otherwise bitbake will
 # attempt to find a provider for it (and fail) when it does the parse.
-- 
1.8.1

Re: [meta-fsl-arm PATCH v3 04/13] gst-fsl-plugin (3.0.6): Add 'virtual/kernel' dependency

[Daiane Angolini]

On 04/15/2013 08:51 AM, Otavio Salvador wrote:
> The code includes kernel headers during the build so the kernel needs
> to be built before doing the gst-fsl-plugins build.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v3:
> - New patch
>
> Changes in v2: None
>
>   recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
> index 0f5d5c3..77baa9a 100644
> --- a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
> +++ b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
> @@ -3,7 +3,7 @@
>
>   require gst-fsl-plugin.inc
>
> -DEPENDS = "gstreamer gst-plugins-base libfslcodec libfslparser"
> +DEPENDS = "virtual/kernel gstreamer gst-plugins-base libfslcodec libfslparser"
>
>   PR = "${INC_PR}.1"

Does it need to be BUMPED?

Daiane

Re: [meta-fsl-arm PATCH v3 05/13] imx-base.inc: Disable firmware include for not fully supported BSPs

[Daiane Angolini]

On 04/15/2013 08:51 AM, Otavio Salvador wrote:
> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
> don't have the firmware package for them so comment them out so it
> doesn't break the build.

Why to keep this code? I would prefer to remove the lines instead of 
comment them.


Daiane

Re: [meta-fsl-arm PATCH v3 04/13] gst-fsl-plugin (3.0.6): Add 'virtual/kernel' dependency

[Otavio Salvador]

On Mon, Apr 15, 2013 at 11:00 AM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>
>> The code includes kernel headers during the build so the kernel needs
>> to be built before doing the gst-fsl-plugins build.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Changes in v3:
>> - New patch
>>
>> Changes in v2: None
>>
>>   recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
>> b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
>> index 0f5d5c3..77baa9a 100644
>> --- a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
>> +++ b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.6.bb
>> @@ -3,7 +3,7 @@
>>
>>   require gst-fsl-plugin.inc
>>
>> -DEPENDS = "gstreamer gst-plugins-base libfslcodec libfslparser"
>> +DEPENDS = "virtual/kernel gstreamer gst-plugins-base libfslcodec
>> libfslparser"
>>
>>   PR = "${INC_PR}.1"
>
>
> Does it need to be BUMPED?

In master it is not need as it uses the internal hash to check for
changed recipes and is advised to use the PRServer.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm PATCH v3 05/13] imx-base.inc: Disable firmware include for not fully supported BSPs

[Otavio Salvador]

On Mon, Apr 15, 2013 at 11:02 AM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>
>> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
>> don't have the firmware package for them so comment them out so it
>> doesn't break the build.
>
> Why to keep this code? I would prefer to remove the lines instead of comment
> them.

I can remove it but I kept it as it is the name of the generated files
and makes it easier to add it back (also has the FIXME). So if someone
grep the code looking for firmware for it, it'll find it commented and
with a FIXME on top of it.

What do you think?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm PATCH v3 08/13] imx-base.inc: Fix i.MX6SL entry point hex format

[Daiane Angolini]

On 04/15/2013 08:51 AM, Otavio Salvador wrote:
> Trivial change just to make it using same code style as other entry
> point values.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v3: None
> Changes in v2:
> - New patch
>
>   conf/machine/include/imx-base.inc | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
> index 456bbfb..2cc8b70 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -22,8 +22,8 @@ UBOOT_LOADADDRESS_mx53 = "0x70800000"
>   UBOOT_ENTRYPOINT_mx6  = "0x10800000"
>   UBOOT_LOADADDRESS_mx6 = "0x10800000"
>
> -UBOOT_ENTRYPOINT_mx6sl = "0X80800000"
> -UBOOT_LOADADDRESS_mx6sl = "0X80800000"
> +UBOOT_ENTRYPOINT_mx6sl = "0x80800000"
> +UBOOT_LOADADDRESS_mx6sl = "0x80800000"

Are UBOOT_LOADADDRESS already being used? (didn't you remove it 
somewhere else?)

Daiane

Re: [meta-fsl-arm PATCH v3 09/13] imx-base.inc: Do not assign UBOOT_LOADADDRESS

[Daiane Angolini]

On 04/15/2013 08:51 AM, Otavio Salvador wrote:
> The code uses UBOOT_ENTRYPOINT as default value for UBOOT_LOADADDRESS
> so we don't need to have the variable UBOOT_LOADADDRESS set unless
> it's different from UBOOT_ENTRYPOINT.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---

Please, apply this patch *before* patch 8 ([meta-fsl-arm PATCH v3 08/13] 
imx-base.inc: Fix i.MX6SL entry point hex format)

In my point of view you don't need to "fix" a source code that you will 
remove.


Daiane

Re: [meta-fsl-arm PATCH v3 11/13] xf86-dri-vivante: Ensure install fails if .la cannot be removed

[Daiane Angolini]

On 04/15/2013 08:52 AM, Otavio Salvador wrote:
> To ensure we catch when the makefile stops to install the .la file, we
> ensure the install fails in case .la file does not exist.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---

Please, elaborate the commit log (i did not understand it)

Daiane

Re: [meta-fsl-arm PATCH v3 12/13] xf86-dri-vivante: Fix DRI module name

[Daiane Angolini]

On 04/15/2013 08:52 AM, Otavio Salvador wrote:
> The Xorg Vivante driver has a hardcoded module name as 'vivante_dri'
> so we need to rename it for full Xorg acceleration to work.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v3: None
> Changes in v2: None
>
>   recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
> index 975041d..6e8f8db 100644
> --- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
> @@ -30,6 +30,10 @@ do_install_append () {
>
>       # FIXME: don't install libtool (*.la) file
>       rm ${D}${libdir}/xorg/modules/extensions/*.la
> +
> +    # FIXME: The Xorg driver has a hardcoded library name
> +    mv ${D}${libdir}/xorg/modules/extensions/libdri.so \
> +       ${D}${libdir}/xorg/modules/extensions/libvivante_dri.so

I think you can use a symbolic link instead (as someone else has already 
pointed before in the ML).

Daiane

Re: [meta-fsl-arm PATCH v3 08/13] imx-base.inc: Fix i.MX6SL entry point hex format

[Otavio Salvador]

On Mon, Apr 15, 2013 at 12:24 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>
>> Trivial change just to make it using same code style as other entry
>> point values.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Changes in v3: None
>> Changes in v2:
>> - New patch
>>
>>   conf/machine/include/imx-base.inc | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/conf/machine/include/imx-base.inc
>> b/conf/machine/include/imx-base.inc
>> index 456bbfb..2cc8b70 100644
>> --- a/conf/machine/include/imx-base.inc
>> +++ b/conf/machine/include/imx-base.inc
>> @@ -22,8 +22,8 @@ UBOOT_LOADADDRESS_mx53 = "0x70800000"
>>   UBOOT_ENTRYPOINT_mx6  = "0x10800000"
>>   UBOOT_LOADADDRESS_mx6 = "0x10800000"
>>
>> -UBOOT_ENTRYPOINT_mx6sl = "0X80800000"
>> -UBOOT_LOADADDRESS_mx6sl = "0X80800000"
>> +UBOOT_ENTRYPOINT_mx6sl = "0x80800000"
>> +UBOOT_LOADADDRESS_mx6sl = "0x80800000"
>
>
> Are UBOOT_LOADADDRESS already being used? (didn't you remove it somewhere
> else?)

It is removed in 9/13 but the fix of format should be done before so
we don't mix fixes.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm PATCH v3 09/13] imx-base.inc: Do not assign UBOOT_LOADADDRESS

[Otavio Salvador]

On Mon, Apr 15, 2013 at 12:26 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>
>> The code uses UBOOT_ENTRYPOINT as default value for UBOOT_LOADADDRESS
>> so we don't need to have the variable UBOOT_LOADADDRESS set unless
>> it's different from UBOOT_ENTRYPOINT.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>
>
> Please, apply this patch *before* patch 8 ([meta-fsl-arm PATCH v3 08/13]
> imx-base.inc: Fix i.MX6SL entry point hex format)
>
> In my point of view you don't need to "fix" a source code that you will
> remove.

If that is the case, I prefer to merge both fixes in a single patch.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm PATCH v3 11/13] xf86-dri-vivante: Ensure install fails if .la cannot be removed

[Otavio Salvador]

On Mon, Apr 15, 2013 at 12:29 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:52 AM, Otavio Salvador wrote:
>>
>> To ensure we catch when the makefile stops to install the .la file, we
>> ensure the install fails in case .la file does not exist.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>
>
> Please, elaborate the commit log (i did not understand it)

rm wrong-filename.la

Makes install to fail so if it is ever fixed in a new BSP we'll find
it out and can remove this change.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm PATCH v3 12/13] xf86-dri-vivante: Fix DRI module name

[Otavio Salvador]

On Mon, Apr 15, 2013 at 12:30 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:52 AM, Otavio Salvador wrote:
>>
>> The Xorg Vivante driver has a hardcoded module name as 'vivante_dri'
>> so we need to rename it for full Xorg acceleration to work.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Changes in v3: None
>> Changes in v2: None
>>
>>   recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>> b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>> index 975041d..6e8f8db 100644
>> --- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>> @@ -30,6 +30,10 @@ do_install_append () {
>>
>>       # FIXME: don't install libtool (*.la) file
>>       rm ${D}${libdir}/xorg/modules/extensions/*.la
>> +
>> +    # FIXME: The Xorg driver has a hardcoded library name
>> +    mv ${D}${libdir}/xorg/modules/extensions/libdri.so \
>> +       ${D}${libdir}/xorg/modules/extensions/libvivante_dri.so
>
>
> I think you can use a symbolic link instead (as someone else has already
> pointed before in the ML).

This makes it harder to have regular libdri.so packaged in same rootfs
in future. With the support for multiple CPUs in a single kernel (as
done in mainline) this should be started to be considered.


--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [meta-fsl-arm PATCH v3 05/13] imx-base.inc: Disable firmware include for not fully supported BSPs

[Daiane Angolini]

On 04/15/2013 11:14 AM, Otavio Salvador wrote:
> On Mon, Apr 15, 2013 at 11:02 AM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>>
>>> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
>>> don't have the firmware package for them so comment them out so it
>>> doesn't break the build.
>>
>> Why to keep this code? I would prefer to remove the lines instead of comment
>> them.
>
> I can remove it but I kept it as it is the name of the generated files
> and makes it easier to add it back (also has the FIXME). So if someone
> grep the code looking for firmware for it, it'll find it commented and
> with a FIXME on top of it.
>
> What do you think?

I prefer to remove the code. But, it's not that hard preference.


Daiane

Re: [meta-fsl-arm PATCH v3 12/13] xf86-dri-vivante: Fix DRI module name

[Daiane Angolini]

On 04/15/2013 01:15 PM, Otavio Salvador wrote:
> On Mon, Apr 15, 2013 at 12:30 PM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> On 04/15/2013 08:52 AM, Otavio Salvador wrote:
>>>
>>> The Xorg Vivante driver has a hardcoded module name as 'vivante_dri'
>>> so we need to rename it for full Xorg acceleration to work.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ---
>>> Changes in v3: None
>>> Changes in v2: None
>>>
>>>    recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>>> b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>>> index 975041d..6e8f8db 100644
>>> --- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>>> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>>> @@ -30,6 +30,10 @@ do_install_append () {
>>>
>>>        # FIXME: don't install libtool (*.la) file
>>>        rm ${D}${libdir}/xorg/modules/extensions/*.la
>>> +
>>> +    # FIXME: The Xorg driver has a hardcoded library name
>>> +    mv ${D}${libdir}/xorg/modules/extensions/libdri.so \
>>> +       ${D}${libdir}/xorg/modules/extensions/libvivante_dri.so
>>
>>
>> I think you can use a symbolic link instead (as someone else has already
>> pointed before in the ML).
>
> This makes it harder to have regular libdri.so packaged in same rootfs
> in future. With the support for multiple CPUs in a single kernel (as
> done in mainline) this should be started to be considered.

I got that. Agreed


Daiane

Re: [meta-fsl-arm PATCH v3 09/13] imx-base.inc: Do not assign UBOOT_LOADADDRESS

[Daiane Angolini]

On 04/15/2013 01:13 PM, Otavio Salvador wrote:
> On Mon, Apr 15, 2013 at 12:26 PM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>>
>>> The code uses UBOOT_ENTRYPOINT as default value for UBOOT_LOADADDRESS
>>> so we don't need to have the variable UBOOT_LOADADDRESS set unless
>>> it's different from UBOOT_ENTRYPOINT.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ---
>>
>>
>> Please, apply this patch *before* patch 8 ([meta-fsl-arm PATCH v3 08/13]
>> imx-base.inc: Fix i.MX6SL entry point hex format)
>>
>> In my point of view you don't need to "fix" a source code that you will
>> remove.
>
> If that is the case, I prefer to merge both fixes in a single patch.

Well. I think I agree


Daiane

Re: [meta-fsl-arm PATCH v3 05/13] imx-base.inc: Disable firmware include for not fully supported BSPs

[Otavio Salvador]

On Mon, Apr 15, 2013 at 1:40 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 11:14 AM, Otavio Salvador wrote:
>>
>> On Mon, Apr 15, 2013 at 11:02 AM, Daiane Angolini
>> <daiane.angolini@freescale.com> wrote:
>>>
>>> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>>>
>>>>
>>>> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
>>>> don't have the firmware package for them so comment them out so it
>>>> doesn't break the build.
>>>
>>>
>>> Why to keep this code? I would prefer to remove the lines instead of
>>> comment
>>> them.
>>
>>
>> I can remove it but I kept it as it is the name of the generated files
>> and makes it easier to add it back (also has the FIXME). So if someone
>> grep the code looking for firmware for it, it'll find it commented and
>> with a FIXME on top of it.
>>
>> What do you think?
>
>
> I prefer to remove the code. But, it's not that hard preference.

And about the FIXME?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br