All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 02/15] block: Add driver-specific options for backing files
Date: Mon, 15 Apr 2013 11:38:08 -0600	[thread overview]
Message-ID: <516C3B00.9080105@redhat.com> (raw)
In-Reply-To: <1365799688-19918-3-git-send-email-kwolf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

On 04/12/2013 02:47 PM, Kevin Wolf wrote:
> Options starting in "backing." are passed to the backing file now. If
> you don't need to specify the filename for the backing file, you can add
> it on the command line instead of in the image file:
> 
> $ qemu-nbd -t /tmp/test.img
> $ qemu-img create -f qcow2 empty.qcow2 1G
> $ qemu-system-x86_64 -drive file=empty.qcow2,backing.file.driver=nbd,\
>     backing.file.host=localhost

So effectively empty.qcow2 is booted as though it had an explicit
nbd://localhost in its backing metadata?  Looks interesting!

> 
> Note that this doesn't override the backing filename from the image. If
> the image has one, this will fail because NBD doesn't want the options
> and a filename at the same time.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block.c               | 27 +++++++++++++++++++++++----
>  block/mirror.c        |  2 +-
>  include/block/block.h |  2 +-
>  3 files changed, 25 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  reply	other threads:[~2013-04-15 17:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12 20:47 [Qemu-devel] [PATCH 00/15] block: Overriding the backing file with -drive Kevin Wolf
2013-04-12 20:47 ` [Qemu-devel] [PATCH 01/15] block: Fail gracefully when using a format driver on protocol level Kevin Wolf
2013-04-12 22:50   ` Eric Blake
2013-04-15  9:06     ` Kevin Wolf
2013-04-15 12:02       ` Markus Armbruster
2013-04-12 20:47 ` [Qemu-devel] [PATCH 02/15] block: Add driver-specific options for backing files Kevin Wolf
2013-04-15 17:38   ` Eric Blake [this message]
2013-04-12 20:47 ` [Qemu-devel] [PATCH 03/15] block: Enable filename option Kevin Wolf
2013-04-15 17:43   ` Eric Blake
2013-04-12 20:47 ` [Qemu-devel] [PATCH 04/15] raw-posix: Use bdrv_open options instead of filename Kevin Wolf
2013-04-15 17:52   ` Eric Blake
2013-04-12 20:47 ` [Qemu-devel] [PATCH 05/15] raw-win32: " Kevin Wolf
2013-04-15 19:16   ` Eric Blake
2013-04-12 20:47 ` [Qemu-devel] [PATCH 06/15] blkdebug: " Kevin Wolf
2013-04-15 19:43   ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 07/15] blkverify: " Kevin Wolf
2013-04-15 19:47   ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 08/15] curl: " Kevin Wolf
2013-04-15 19:57   ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 09/15] gluster: " Kevin Wolf
2013-04-15 20:07   ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 10/15] iscsi: " Kevin Wolf
2013-04-15 20:26   ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 11/15] rbd: " Kevin Wolf
2013-04-15 20:27   ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 12/15] sheepdog: " Kevin Wolf
2013-04-15 20:29   ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 13/15] vvfat: " Kevin Wolf
2013-04-15 20:44   ` Eric Blake
2013-04-12 20:48 ` [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bdrv_file_open() Kevin Wolf
2013-04-15 20:47   ` Eric Blake
2013-04-22  9:41   ` [Qemu-devel] [PATCH v2 " Kevin Wolf
2013-04-12 20:48 ` [Qemu-devel] [PATCH 15/15] block: Allow overriding backing.file.filename Kevin Wolf
2013-04-15 21:03   ` Eric Blake
2013-04-18 11:42 ` [Qemu-devel] [PATCH 00/15] block: Overriding the backing file with -drive Stefan Hajnoczi
2013-04-18 13:34   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516C3B00.9080105@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.