Re: [Qemu-devel] [PATCH 03/15] block: Enable filename option

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

On 04/12/2013 02:47 PM, Kevin Wolf wrote:
> This allows using the file.filename option instead of the string that
> comes from -drive file=... and is passed around as a separate parameter.
> The goal is to get rid of this parameter and use the options QDict more
> consistently.
> 
> With this option you can access not only the top-level image, but
> specify a filename for the backing file (currently only if no backing
> file exists, but we'll allow overriding it later)
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block.c | 31 +++++++++++++++++++++++++++----
>  1 file changed, 27 insertions(+), 4 deletions(-)

Quite a few lines added for a net reduction in parameters, but the
results look nice.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]