Re: [Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bdrv_file_open()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

On 04/12/2013 02:48 PM, Kevin Wolf wrote:
> It is unused now in all block drivers.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> +++ b/block/gluster.c
> @@ -296,8 +296,8 @@ static QemuOptsList runtime_opts = {
>      },
>  };
>  
> -static int qemu_gluster_open(BlockDriverState *bs, const char *dummy,
> -    QDict *options, int bdrv_flags)
> +static int qemu_gluster_open(BlockDriverState *bs,  QDict *options,
> +                             int bdrv_flags)

Ah, one of my comments about inconsistent indentation in 9/15 has been
solved here (so it's fine to avoid the churn of touching it up twice).

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]