From: Zefir Kurtisi <zefir.kurtisi@neratec.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [patch] ath9k: use GFP_ATOMIC under spinlock
Date: Tue, 16 Apr 2013 14:10:26 +0200 [thread overview]
Message-ID: <516D3FB2.7070005@neratec.com> (raw)
In-Reply-To: <20130416075128.GB1571@elgon.mountain>
On 04/16/2013 09:51 AM, Dan Carpenter wrote:
> This is called with spinlocks held so we have to use GFP_ATOMIC. It's
> the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
> like this:
>
> ath9k_stop()
> ath_prepare_reset()
> ath_stoprecv()
> ath_flushrecv()
> ath_rx_tasklet()
> ath9k_dfs_process_phyerr()
> pd->add_pulse() => dpd_add_pulse()
> channel_detector_get()
> channel_detector_create()
> pri_detector_init()
>
> channel_detector_create() uses GFP_ATOMIC as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis stuff. I haven't tested this but it looks like a real
> bug to me.
>
Thanks Dan,
it is a bug that slipped through the related patch in [1].
Tested-by & Acked-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
[1] http://article.gmane.org/gmane.linux.kernel.wireless.general/106349/
WARNING: multiple messages have this Message-ID (diff)
From: Zefir Kurtisi <zefir.kurtisi@neratec.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ath9k: use GFP_ATOMIC under spinlock
Date: Tue, 16 Apr 2013 12:10:26 +0000 [thread overview]
Message-ID: <516D3FB2.7070005@neratec.com> (raw)
In-Reply-To: <20130416075128.GB1571@elgon.mountain>
On 04/16/2013 09:51 AM, Dan Carpenter wrote:
> This is called with spinlocks held so we have to use GFP_ATOMIC. It's
> the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
> like this:
>
> ath9k_stop()
> ath_prepare_reset()
> ath_stoprecv()
> ath_flushrecv()
> ath_rx_tasklet()
> ath9k_dfs_process_phyerr()
> pd->add_pulse() => dpd_add_pulse()
> channel_detector_get()
> channel_detector_create()
> pri_detector_init()
>
> channel_detector_create() uses GFP_ATOMIC as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis stuff. I haven't tested this but it looks like a real
> bug to me.
>
Thanks Dan,
it is a bug that slipped through the related patch in [1].
Tested-by & Acked-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
[1] http://article.gmane.org/gmane.linux.kernel.wireless.general/106349/
WARNING: multiple messages have this Message-ID (diff)
From: Zefir Kurtisi <zefir.kurtisi@neratec.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ath9k: use GFP_ATOMIC under spinlock
Date: Tue, 16 Apr 2013 14:10:26 +0200 [thread overview]
Message-ID: <516D3FB2.7070005@neratec.com> (raw)
In-Reply-To: <20130416075128.GB1571@elgon.mountain>
On 04/16/2013 09:51 AM, Dan Carpenter wrote:
> This is called with spinlocks held so we have to use GFP_ATOMIC. It's
> the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
> like this:
>
> ath9k_stop()
> ath_prepare_reset()
> ath_stoprecv()
> ath_flushrecv()
> ath_rx_tasklet()
> ath9k_dfs_process_phyerr()
> pd->add_pulse() => dpd_add_pulse()
> channel_detector_get()
> channel_detector_create()
> pri_detector_init()
>
> channel_detector_create() uses GFP_ATOMIC as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis stuff. I haven't tested this but it looks like a real
> bug to me.
>
Thanks Dan,
it is a bug that slipped through the related patch in [1].
Tested-by & Acked-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
[1] http://article.gmane.org/gmane.linux.kernel.wireless.general/106349/
next prev parent reply other threads:[~2013-04-16 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 7:51 [ath9k-devel] [patch] ath9k: use GFP_ATOMIC under spinlock Dan Carpenter
2013-04-16 7:51 ` Dan Carpenter
2013-04-16 7:51 ` Dan Carpenter
2013-04-16 12:10 ` Zefir Kurtisi [this message]
2013-04-16 12:10 ` Zefir Kurtisi
2013-04-16 12:10 ` Zefir Kurtisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D3FB2.7070005@neratec.com \
--to=zefir.kurtisi@neratec.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.