* [ath9k-devel] [patch] ath9k: use GFP_ATOMIC under spinlock
@ 2013-04-16 7:51 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2013-04-16 7:51 UTC (permalink / raw)
To: ath9k-devel
This is called with spinlocks held so we have to use GFP_ATOMIC. It's
the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
like this:
ath9k_stop()
ath_prepare_reset()
ath_stoprecv()
ath_flushrecv()
ath_rx_tasklet()
ath9k_dfs_process_phyerr()
pd->add_pulse() => dpd_add_pulse()
channel_detector_get()
channel_detector_create()
pri_detector_init()
channel_detector_create() uses GFP_ATOMIC as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis stuff. I haven't tested this but it looks like a real
bug to me.
diff --git a/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c b/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
index 5e48c55..e056c73 100644
--- a/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
+++ b/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
@@ -434,7 +434,8 @@ struct pri_detector *
pri_detector_init(const struct radar_detector_specs *rs)
{
struct pri_detector *de;
- de = kzalloc(sizeof(*de), GFP_KERNEL);
+
+ de = kzalloc(sizeof(*de), GFP_ATOMIC);
if (de == NULL)
return NULL;
de->exit = pri_detector_exit;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] ath9k: use GFP_ATOMIC under spinlock
@ 2013-04-16 7:51 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2013-04-16 7:51 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: Jouni Malinen, Vasanthakumar Thiagarajan, Senthil Balasubramanian,
John W. Linville, linux-wireless, ath9k-devel, kernel-janitors
This is called with spinlocks held so we have to use GFP_ATOMIC. It's
the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
like this:
ath9k_stop()
ath_prepare_reset()
ath_stoprecv()
ath_flushrecv()
ath_rx_tasklet()
ath9k_dfs_process_phyerr()
pd->add_pulse() => dpd_add_pulse()
channel_detector_get()
channel_detector_create()
pri_detector_init()
channel_detector_create() uses GFP_ATOMIC as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis stuff. I haven't tested this but it looks like a real
bug to me.
diff --git a/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c b/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
index 5e48c55..e056c73 100644
--- a/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
+++ b/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
@@ -434,7 +434,8 @@ struct pri_detector *
pri_detector_init(const struct radar_detector_specs *rs)
{
struct pri_detector *de;
- de = kzalloc(sizeof(*de), GFP_KERNEL);
+
+ de = kzalloc(sizeof(*de), GFP_ATOMIC);
if (de == NULL)
return NULL;
de->exit = pri_detector_exit;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] ath9k: use GFP_ATOMIC under spinlock
@ 2013-04-16 7:51 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2013-04-16 7:51 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: Jouni Malinen, Vasanthakumar Thiagarajan, Senthil Balasubramanian,
John W. Linville, linux-wireless, ath9k-devel, kernel-janitors
This is called with spinlocks held so we have to use GFP_ATOMIC. It's
the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
like this:
ath9k_stop()
ath_prepare_reset()
ath_stoprecv()
ath_flushrecv()
ath_rx_tasklet()
ath9k_dfs_process_phyerr()
pd->add_pulse() => dpd_add_pulse()
channel_detector_get()
channel_detector_create()
pri_detector_init()
channel_detector_create() uses GFP_ATOMIC as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis stuff. I haven't tested this but it looks like a real
bug to me.
diff --git a/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c b/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
index 5e48c55..e056c73 100644
--- a/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
+++ b/drivers/net/wireless/ath/ath9k/dfs_pri_detector.c
@@ -434,7 +434,8 @@ struct pri_detector *
pri_detector_init(const struct radar_detector_specs *rs)
{
struct pri_detector *de;
- de = kzalloc(sizeof(*de), GFP_KERNEL);
+
+ de = kzalloc(sizeof(*de), GFP_ATOMIC);
if (de = NULL)
return NULL;
de->exit = pri_detector_exit;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [ath9k-devel] [patch] ath9k: use GFP_ATOMIC under spinlock
2013-04-16 7:51 ` Dan Carpenter
(?)
@ 2013-04-16 12:10 ` Zefir Kurtisi
-1 siblings, 0 replies; 6+ messages in thread
From: Zefir Kurtisi @ 2013-04-16 12:10 UTC (permalink / raw)
To: ath9k-devel
On 04/16/2013 09:51 AM, Dan Carpenter wrote:
> This is called with spinlocks held so we have to use GFP_ATOMIC. It's
> the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
> like this:
>
> ath9k_stop()
> ath_prepare_reset()
> ath_stoprecv()
> ath_flushrecv()
> ath_rx_tasklet()
> ath9k_dfs_process_phyerr()
> pd->add_pulse() => dpd_add_pulse()
> channel_detector_get()
> channel_detector_create()
> pri_detector_init()
>
> channel_detector_create() uses GFP_ATOMIC as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis stuff. I haven't tested this but it looks like a real
> bug to me.
>
Thanks Dan,
it is a bug that slipped through the related patch in [1].
Tested-by & Acked-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
[1] http://article.gmane.org/gmane.linux.kernel.wireless.general/106349/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ath9k: use GFP_ATOMIC under spinlock
@ 2013-04-16 12:10 ` Zefir Kurtisi
0 siblings, 0 replies; 6+ messages in thread
From: Zefir Kurtisi @ 2013-04-16 12:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: Luis R. Rodriguez, Jouni Malinen, Vasanthakumar Thiagarajan,
Senthil Balasubramanian, John W. Linville, linux-wireless,
ath9k-devel, kernel-janitors
On 04/16/2013 09:51 AM, Dan Carpenter wrote:
> This is called with spinlocks held so we have to use GFP_ATOMIC. It's
> the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
> like this:
>
> ath9k_stop()
> ath_prepare_reset()
> ath_stoprecv()
> ath_flushrecv()
> ath_rx_tasklet()
> ath9k_dfs_process_phyerr()
> pd->add_pulse() => dpd_add_pulse()
> channel_detector_get()
> channel_detector_create()
> pri_detector_init()
>
> channel_detector_create() uses GFP_ATOMIC as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis stuff. I haven't tested this but it looks like a real
> bug to me.
>
Thanks Dan,
it is a bug that slipped through the related patch in [1].
Tested-by & Acked-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
[1] http://article.gmane.org/gmane.linux.kernel.wireless.general/106349/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ath9k: use GFP_ATOMIC under spinlock
@ 2013-04-16 12:10 ` Zefir Kurtisi
0 siblings, 0 replies; 6+ messages in thread
From: Zefir Kurtisi @ 2013-04-16 12:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: Luis R. Rodriguez, Jouni Malinen, Vasanthakumar Thiagarajan,
Senthil Balasubramanian, John W. Linville, linux-wireless,
ath9k-devel, kernel-janitors
On 04/16/2013 09:51 AM, Dan Carpenter wrote:
> This is called with spinlocks held so we have to use GFP_ATOMIC. It's
> the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks
> like this:
>
> ath9k_stop()
> ath_prepare_reset()
> ath_stoprecv()
> ath_flushrecv()
> ath_rx_tasklet()
> ath9k_dfs_process_phyerr()
> pd->add_pulse() => dpd_add_pulse()
> channel_detector_get()
> channel_detector_create()
> pri_detector_init()
>
> channel_detector_create() uses GFP_ATOMIC as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static analysis stuff. I haven't tested this but it looks like a real
> bug to me.
>
Thanks Dan,
it is a bug that slipped through the related patch in [1].
Tested-by & Acked-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
[1] http://article.gmane.org/gmane.linux.kernel.wireless.general/106349/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-16 12:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-16 7:51 [ath9k-devel] [patch] ath9k: use GFP_ATOMIC under spinlock Dan Carpenter
2013-04-16 7:51 ` Dan Carpenter
2013-04-16 7:51 ` Dan Carpenter
2013-04-16 12:10 ` [ath9k-devel] " Zefir Kurtisi
2013-04-16 12:10 ` Zefir Kurtisi
2013-04-16 12:10 ` Zefir Kurtisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.