Re: [PATCH] intel: Add pci id for Haswell Harris Beach Mobile GT2+

[Kenneth Graunke <kenneth@whitecape.org>]

On 04/15/2013 05:52 PM, Chad Versace wrote:
> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
> ---
>   intel/intel_chipset.h | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> index b73fa0f..da2fbee 100644
> --- a/intel/intel_chipset.h
> +++ b/intel/intel_chipset.h
> @@ -82,6 +82,7 @@
>   #define PCI_CHIP_HASWELL_CRW_S_GT1      0x0D1A /* Server */
>   #define PCI_CHIP_HASWELL_CRW_S_GT2      0x0D2A
>   #define PCI_CHIP_HASWELL_CRW_S_GT2_PLUS 0x0D3A
> +#define PCI_CHIP_HASWELL_HSB_M_GT2_PLUS 0x0A26 /* Mobile */
>
>   #define IS_830(dev) (dev == 0x3577)
>   #define IS_845(dev) (dev == 0x2562)
> @@ -198,7 +199,8 @@
>   				 devid == PCI_CHIP_HASWELL_ULT_S_GT2_PLUS || \
>   				 devid == PCI_CHIP_HASWELL_CRW_GT2_PLUS || \
>   				 devid == PCI_CHIP_HASWELL_CRW_M_GT2_PLUS || \
> -				 devid == PCI_CHIP_HASWELL_CRW_S_GT2_PLUS)
> +				 devid == PCI_CHIP_HASWELL_CRW_S_GT2_PLUS || \
> +				 devid == PCI_CHIP_HASWELL_HSB_M_GT2_PLUS)
>
>   #define IS_HASWELL(devid)       (IS_HSW_GT1(devid) || \
>                                    IS_HSW_GT2(devid))
>


What project is this patch for?  libdrm?

Regardless, NAK - see above line:

#define PCI_CHIP_HASWELL_ULT_M_GT2_PLUS 0x0A26

It's already been supported for ages:

commit 93fef04b1e3a83e2f884880ed1c3395f67b038ab
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date:   Mon Aug 6 14:55:23 2012 -0300

     intel: add more Haswell PCI IDs

     Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
     Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>

--Ken