From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org,
"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 5/7] KVM: Extract generic irqchip logic into irqchip.c
Date: Wed, 17 Apr 2013 12:05:15 +0000 [thread overview]
Message-ID: <516E8FFB.1020805@redhat.com> (raw)
In-Reply-To: <1366133175-23986-6-git-send-email-agraf@suse.de>
Il 16/04/2013 19:26, Alexander Graf ha scritto:
> +#ifdef kvm_irqchip
> TP_printk("irqchip %s pin %u",
> __print_symbolic(__entry->irqchip, kvm_irqchips),
> __entry->pin)
> +#else
> + TP_printk("irqchip %d pin %u", __entry->irqchip, __entry->pin)
> +#endif
Ah, spotted this too. Must be "#ifdef kvm_irqchips", but perhaps you
can just use #ifdef __KVM_HAVE_IOAPIC.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org,
"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 5/7] KVM: Extract generic irqchip logic into irqchip.c
Date: Wed, 17 Apr 2013 14:05:15 +0200 [thread overview]
Message-ID: <516E8FFB.1020805@redhat.com> (raw)
In-Reply-To: <1366133175-23986-6-git-send-email-agraf@suse.de>
Il 16/04/2013 19:26, Alexander Graf ha scritto:
> +#ifdef kvm_irqchip
> TP_printk("irqchip %s pin %u",
> __print_symbolic(__entry->irqchip, kvm_irqchips),
> __entry->pin)
> +#else
> + TP_printk("irqchip %d pin %u", __entry->irqchip, __entry->pin)
> +#endif
Ah, spotted this too. Must be "#ifdef kvm_irqchips", but perhaps you
can just use #ifdef __KVM_HAVE_IOAPIC.
Paolo
next prev parent reply other threads:[~2013-04-17 12:05 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 17:26 [PATCH 0/7] KVM: irqfd generalization prepare patch set Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 1/7] KVM: Add KVM_IRQCHIP_NUM_PINS in addition to KVM_IOAPIC_NUM_PINS Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-17 11:51 ` Paolo Bonzini
2013-04-17 11:51 ` Paolo Bonzini
2013-04-16 17:26 ` [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-17 11:49 ` Paolo Bonzini
2013-04-17 11:49 ` Paolo Bonzini
2013-04-17 11:53 ` Alexander Graf
2013-04-17 11:53 ` Alexander Graf
2013-04-17 11:54 ` Paolo Bonzini
2013-04-17 11:54 ` Paolo Bonzini
2013-04-17 11:59 ` Alexander Graf
2013-04-17 11:59 ` Alexander Graf
2013-04-17 12:06 ` Paolo Bonzini
2013-04-17 12:06 ` Paolo Bonzini
2013-04-17 12:10 ` Alexander Graf
2013-04-17 12:10 ` Alexander Graf
2013-04-17 12:15 ` Paolo Bonzini
2013-04-17 12:15 ` Paolo Bonzini
2013-04-17 12:16 ` Alexander Graf
2013-04-17 12:16 ` Alexander Graf
2013-04-24 9:55 ` Gleb Natapov
2013-04-24 9:55 ` Gleb Natapov
2013-04-16 17:26 ` [PATCH 3/7] KVM: Remove kvm_get_intr_delivery_bitmask Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 4/7] KVM: Move irq routing to generic code Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 5/7] KVM: Extract generic irqchip logic into irqchip.c Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-17 11:50 ` Paolo Bonzini
2013-04-17 11:50 ` Paolo Bonzini
2013-04-17 11:54 ` Alexander Graf
2013-04-17 11:54 ` Alexander Graf
2013-04-17 12:05 ` Paolo Bonzini [this message]
2013-04-17 12:05 ` Paolo Bonzini
2013-04-17 12:06 ` Alexander Graf
2013-04-17 12:06 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 6/7] KVM: Move irq routing setup to irqchip.c Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 7/7] KVM: Move irqfd resample cap handling to generic code Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-21 10:51 ` [PATCH 0/7] KVM: irqfd generalization prepare patch set Michael S. Tsirkin
2013-04-21 10:51 ` Michael S. Tsirkin
2013-04-25 9:39 ` Alexander Graf
2013-04-25 9:39 ` Alexander Graf
2013-04-24 10:20 ` Gleb Natapov
2013-04-24 10:20 ` Gleb Natapov
2013-04-25 7:28 ` Gleb Natapov
2013-04-25 7:28 ` Gleb Natapov
2013-04-25 9:35 ` Alexander Graf
2013-04-25 9:35 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E8FFB.1020805@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=gleb@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.