From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org,
"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP
Date: Wed, 17 Apr 2013 12:06:11 +0000 [thread overview]
Message-ID: <516E9033.2030904@redhat.com> (raw)
In-Reply-To: <E7CFFE06-5144-4157-A0ED-2446F9A71162@suse.de>
Il 17/04/2013 13:59, Alexander Graf ha scritto:
>> > Well, we just got a patch to make it at least compile,
> That was really just Yang (blindly?) fixing an issue I pointed out on
> ARM. There is no kvm user space support for IA64. The kernel side has
> been KConfig depending on BROKEN for a year already:
Yes, I know.
Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC;
defining one without the other makes no sense and will cause compilation
or link errors for trace_kvm_ack_irq.
Either we drop it altogether, or we should not break compilation
consciously---especially if the problem is so trivial and obvious that
you had to think of leaving it out.
Paolo
> commit a6bb7929677aacfce3f864c3cdacaa7d527945d5
> Author: Avi Kivity <avi@redhat.com>
> Date: Thu May 17 13:14:08 2012 +0300
>
> KVM: ia64: Mark ia64 KVM as BROKEN
>
> Practically all patches to ia64 KVM are build fixes; numerous warnings remain;
> the last patch from the maintainer was committed more than three years ago. It
> is clear that no one is using this thing.
>
> Mark as BROKEN to ensure people don't get hit by pointless build problems.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> Signed-off-by: Avi Kivity <avi@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org,
"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP
Date: Wed, 17 Apr 2013 14:06:11 +0200 [thread overview]
Message-ID: <516E9033.2030904@redhat.com> (raw)
In-Reply-To: <E7CFFE06-5144-4157-A0ED-2446F9A71162@suse.de>
Il 17/04/2013 13:59, Alexander Graf ha scritto:
>> > Well, we just got a patch to make it at least compile,
> That was really just Yang (blindly?) fixing an issue I pointed out on
> ARM. There is no kvm user space support for IA64. The kernel side has
> been KConfig depending on BROKEN for a year already:
Yes, I know.
Still, __KVM_HAVE_IRQCHIP is clearly a subset of __KVM_HAVE_IOAPIC;
defining one without the other makes no sense and will cause compilation
or link errors for trace_kvm_ack_irq.
Either we drop it altogether, or we should not break compilation
consciously---especially if the problem is so trivial and obvious that
you had to think of leaving it out.
Paolo
> commit a6bb7929677aacfce3f864c3cdacaa7d527945d5
> Author: Avi Kivity <avi@redhat.com>
> Date: Thu May 17 13:14:08 2012 +0300
>
> KVM: ia64: Mark ia64 KVM as BROKEN
>
> Practically all patches to ia64 KVM are build fixes; numerous warnings remain;
> the last patch from the maintainer was committed more than three years ago. It
> is clear that no one is using this thing.
>
> Mark as BROKEN to ensure people don't get hit by pointless build problems.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> Signed-off-by: Avi Kivity <avi@redhat.com>
next prev parent reply other threads:[~2013-04-17 12:06 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 17:26 [PATCH 0/7] KVM: irqfd generalization prepare patch set Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 1/7] KVM: Add KVM_IRQCHIP_NUM_PINS in addition to KVM_IOAPIC_NUM_PINS Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-17 11:51 ` Paolo Bonzini
2013-04-17 11:51 ` Paolo Bonzini
2013-04-16 17:26 ` [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-17 11:49 ` Paolo Bonzini
2013-04-17 11:49 ` Paolo Bonzini
2013-04-17 11:53 ` Alexander Graf
2013-04-17 11:53 ` Alexander Graf
2013-04-17 11:54 ` Paolo Bonzini
2013-04-17 11:54 ` Paolo Bonzini
2013-04-17 11:59 ` Alexander Graf
2013-04-17 11:59 ` Alexander Graf
2013-04-17 12:06 ` Paolo Bonzini [this message]
2013-04-17 12:06 ` Paolo Bonzini
2013-04-17 12:10 ` Alexander Graf
2013-04-17 12:10 ` Alexander Graf
2013-04-17 12:15 ` Paolo Bonzini
2013-04-17 12:15 ` Paolo Bonzini
2013-04-17 12:16 ` Alexander Graf
2013-04-17 12:16 ` Alexander Graf
2013-04-24 9:55 ` Gleb Natapov
2013-04-24 9:55 ` Gleb Natapov
2013-04-16 17:26 ` [PATCH 3/7] KVM: Remove kvm_get_intr_delivery_bitmask Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 4/7] KVM: Move irq routing to generic code Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 5/7] KVM: Extract generic irqchip logic into irqchip.c Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-17 11:50 ` Paolo Bonzini
2013-04-17 11:50 ` Paolo Bonzini
2013-04-17 11:54 ` Alexander Graf
2013-04-17 11:54 ` Alexander Graf
2013-04-17 12:05 ` Paolo Bonzini
2013-04-17 12:05 ` Paolo Bonzini
2013-04-17 12:06 ` Alexander Graf
2013-04-17 12:06 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 6/7] KVM: Move irq routing setup to irqchip.c Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-16 17:26 ` [PATCH 7/7] KVM: Move irqfd resample cap handling to generic code Alexander Graf
2013-04-16 17:26 ` Alexander Graf
2013-04-21 10:51 ` [PATCH 0/7] KVM: irqfd generalization prepare patch set Michael S. Tsirkin
2013-04-21 10:51 ` Michael S. Tsirkin
2013-04-25 9:39 ` Alexander Graf
2013-04-25 9:39 ` Alexander Graf
2013-04-24 10:20 ` Gleb Natapov
2013-04-24 10:20 ` Gleb Natapov
2013-04-25 7:28 ` Gleb Natapov
2013-04-25 7:28 ` Gleb Natapov
2013-04-25 9:35 ` Alexander Graf
2013-04-25 9:35 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E9033.2030904@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=gleb@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.