From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Thu, 18 Apr 2013 17:38:54 +0000 [thread overview]
Message-ID: <51702FAE.4040104@cogentembedded.com> (raw)
In-Reply-To: <20130418153611.GX14496@n2100.arm.linux.org.uk>
Hello.
On 18-04-2013 19:36, Russell King - ARM Linux wrote:
>> +/* Ether */
>> +static struct resource ether_resources[] = {
>> + {
>> + .start = 0xfde00000,
>> + .end = 0xfde003ff,
>> + .flags = IORESOURCE_MEM,
>> + }, {
>> + .start = gic_iid(0xb4),
>> + .flags = IORESOURCE_IRQ,
>> + },
> There are macros for initializing these which have been around for a
> few years now.
I know, I know, just didn't know they're that old.
> Please consider using them in future.
This file uses the old style resource intializers generally, it just needs
wholesale conversion.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Thu, 18 Apr 2013 21:38:54 +0400 [thread overview]
Message-ID: <51702FAE.4040104@cogentembedded.com> (raw)
In-Reply-To: <20130418153611.GX14496@n2100.arm.linux.org.uk>
Hello.
On 18-04-2013 19:36, Russell King - ARM Linux wrote:
>> +/* Ether */
>> +static struct resource ether_resources[] = {
>> + {
>> + .start = 0xfde00000,
>> + .end = 0xfde003ff,
>> + .flags = IORESOURCE_MEM,
>> + }, {
>> + .start = gic_iid(0xb4),
>> + .flags = IORESOURCE_IRQ,
>> + },
> There are macros for initializing these which have been around for a
> few years now.
I know, I know, just didn't know they're that old.
> Please consider using them in future.
This file uses the old style resource intializers generally, it just needs
wholesale conversion.
WBR, Sergei
next prev parent reply other threads:[~2013-04-18 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 18:53 [PATCH v2 1/2] ARM: shmobile: R8A7779: add Ether support Sergei Shtylyov
2013-04-04 18:53 ` Sergei Shtylyov
2013-04-05 1:21 ` Kuninori Morimoto
2013-04-05 1:21 ` Kuninori Morimoto
2013-04-05 1:47 ` Simon Horman
2013-04-05 1:47 ` Simon Horman
2013-04-18 15:36 ` Russell King - ARM Linux
2013-04-18 15:36 ` Russell King - ARM Linux
2013-04-18 17:38 ` Sergei Shtylyov [this message]
2013-04-18 17:38 ` Sergei Shtylyov
2013-04-19 2:16 ` Simon Horman
2013-04-19 2:16 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51702FAE.4040104@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.