Re: [PATCH 5/6] x86: enable multi-vector MSI

[Suravee Suthikulanit <suravee.suthikulpanit@amd.com>]

On 4/19/2013 5:59 AM, Jan Beulich wrote:
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -238,6 +238,11 @@ static int write_msi_msg(struct msi_desc
>           u8 bus = dev->bus;
>           u8 slot = PCI_SLOT(dev->devfn);
>           u8 func = PCI_FUNC(dev->devfn);
> +        int nr = entry->msi_attrib.entry_nr;
> +
> +        ASSERT((msg->data & (entry[-nr].msi.nvec - 1)) == nr);
> +        if ( nr )
> +            return 0;
>   
Jan,

This logic seems incorrect.  Do you meant to write --nr?  This causes 
assertion here.  Also, investigation showing the value of nr is 0 here.

Suravee