* [PATCH] efi: Check EFI revision in setup_efi_vars @ 2013-04-24 14:37 ` Josh Boyer 0 siblings, 0 replies; 12+ messages in thread From: Josh Boyer @ 2013-04-24 14:37 UTC (permalink / raw) To: Matthew Garrett, Matt Fleming Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA We need to check the runtime sys_table for the EFI version the firmware specifies instead of just checking for a NULL QueryVariableInfo. Older implementations of EFI don't have QueryVariableInfo but the runtime is a smaller structure, so the pointer to it may be pointing off into garbage. This is apparently the case with several Apple firmwares that support EFI 1.10, and the current check causes them to no longer boot. Fix based on a suggestion from Matthew Garrett. Signed-off-by: Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> --- arch/x86/boot/compressed/eboot.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index 8615f75..b46efbf 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -258,7 +258,9 @@ static efi_status_t setup_efi_vars(struct boot_params *params) u64 store_size, remaining_size, var_size; efi_status_t status; - if (!sys_table->runtime->query_variable_info) + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) + return EFI_UNSUPPORTED; + else if(!sys_table->runtime->query_variable_info) return EFI_UNSUPPORTED; data = (struct setup_data *)(unsigned long)params->hdr.setup_data; -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] efi: Check EFI revision in setup_efi_vars @ 2013-04-24 14:37 ` Josh Boyer 0 siblings, 0 replies; 12+ messages in thread From: Josh Boyer @ 2013-04-24 14:37 UTC (permalink / raw) To: Matthew Garrett, Matt Fleming; +Cc: linux-efi, linux-kernel We need to check the runtime sys_table for the EFI version the firmware specifies instead of just checking for a NULL QueryVariableInfo. Older implementations of EFI don't have QueryVariableInfo but the runtime is a smaller structure, so the pointer to it may be pointing off into garbage. This is apparently the case with several Apple firmwares that support EFI 1.10, and the current check causes them to no longer boot. Fix based on a suggestion from Matthew Garrett. Signed-off-by: Josh Boyer <jwboyer@redhat.com> --- arch/x86/boot/compressed/eboot.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index 8615f75..b46efbf 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -258,7 +258,9 @@ static efi_status_t setup_efi_vars(struct boot_params *params) u64 store_size, remaining_size, var_size; efi_status_t status; - if (!sys_table->runtime->query_variable_info) + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) + return EFI_UNSUPPORTED; + else if(!sys_table->runtime->query_variable_info) return EFI_UNSUPPORTED; data = (struct setup_data *)(unsigned long)params->hdr.setup_data; -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
[parent not found: <20130424143738.GB15272-dHPIJuKSOV01V+h/cAXI7w8O6CCKKCg3HZ5vskTnxNA@public.gmane.org>]
* Re: [PATCH] efi: Check EFI revision in setup_efi_vars 2013-04-24 14:37 ` Josh Boyer @ 2013-04-24 14:44 ` Matt Fleming -1 siblings, 0 replies; 12+ messages in thread From: Matt Fleming @ 2013-04-24 14:44 UTC (permalink / raw) To: Josh Boyer Cc: Matthew Garrett, linux-efi-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 24/04/13 15:37, Josh Boyer wrote: > We need to check the runtime sys_table for the EFI version the firmware > specifies instead of just checking for a NULL QueryVariableInfo. Older > implementations of EFI don't have QueryVariableInfo but the runtime is > a smaller structure, so the pointer to it may be pointing off into garbage. > > This is apparently the case with several Apple firmwares that support EFI > 1.10, and the current check causes them to no longer boot. Fix based on > a suggestion from Matthew Garrett. > > Signed-off-by: Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > --- > arch/x86/boot/compressed/eboot.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c > index 8615f75..b46efbf 100644 > --- a/arch/x86/boot/compressed/eboot.c > +++ b/arch/x86/boot/compressed/eboot.c > @@ -258,7 +258,9 @@ static efi_status_t setup_efi_vars(struct boot_params *params) > u64 store_size, remaining_size, var_size; > efi_status_t status; > > - if (!sys_table->runtime->query_variable_info) > + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) > + return EFI_UNSUPPORTED; > + else if(!sys_table->runtime->query_variable_info) > return EFI_UNSUPPORTED; > > data = (struct setup_data *)(unsigned long)params->hdr.setup_data; > Thanks Josh, that looks correct. It's a small point, but does the check against NULL actually make sense? I don't think we ever check other system table pointers against NULL. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] efi: Check EFI revision in setup_efi_vars @ 2013-04-24 14:44 ` Matt Fleming 0 siblings, 0 replies; 12+ messages in thread From: Matt Fleming @ 2013-04-24 14:44 UTC (permalink / raw) To: Josh Boyer; +Cc: Matthew Garrett, linux-efi, linux-kernel On 24/04/13 15:37, Josh Boyer wrote: > We need to check the runtime sys_table for the EFI version the firmware > specifies instead of just checking for a NULL QueryVariableInfo. Older > implementations of EFI don't have QueryVariableInfo but the runtime is > a smaller structure, so the pointer to it may be pointing off into garbage. > > This is apparently the case with several Apple firmwares that support EFI > 1.10, and the current check causes them to no longer boot. Fix based on > a suggestion from Matthew Garrett. > > Signed-off-by: Josh Boyer <jwboyer@redhat.com> > --- > arch/x86/boot/compressed/eboot.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c > index 8615f75..b46efbf 100644 > --- a/arch/x86/boot/compressed/eboot.c > +++ b/arch/x86/boot/compressed/eboot.c > @@ -258,7 +258,9 @@ static efi_status_t setup_efi_vars(struct boot_params *params) > u64 store_size, remaining_size, var_size; > efi_status_t status; > > - if (!sys_table->runtime->query_variable_info) > + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) > + return EFI_UNSUPPORTED; > + else if(!sys_table->runtime->query_variable_info) > return EFI_UNSUPPORTED; > > data = (struct setup_data *)(unsigned long)params->hdr.setup_data; > Thanks Josh, that looks correct. It's a small point, but does the check against NULL actually make sense? I don't think we ever check other system table pointers against NULL. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] efi: Check EFI revision in setup_efi_vars 2013-04-24 14:44 ` Matt Fleming (?) @ 2013-04-24 14:54 ` Josh Boyer [not found] ` <20130424145449.GC15272-dHPIJuKSOV01V+h/cAXI7w8O6CCKKCg3HZ5vskTnxNA@public.gmane.org> -1 siblings, 1 reply; 12+ messages in thread From: Josh Boyer @ 2013-04-24 14:54 UTC (permalink / raw) To: Matt Fleming; +Cc: Matthew Garrett, linux-efi, linux-kernel On Wed, Apr 24, 2013 at 03:44:30PM +0100, Matt Fleming wrote: > On 24/04/13 15:37, Josh Boyer wrote: > > We need to check the runtime sys_table for the EFI version the firmware > > specifies instead of just checking for a NULL QueryVariableInfo. Older > > implementations of EFI don't have QueryVariableInfo but the runtime is > > a smaller structure, so the pointer to it may be pointing off into garbage. > > > > This is apparently the case with several Apple firmwares that support EFI > > 1.10, and the current check causes them to no longer boot. Fix based on > > a suggestion from Matthew Garrett. > > > > Signed-off-by: Josh Boyer <jwboyer@redhat.com> > > --- > > arch/x86/boot/compressed/eboot.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c > > index 8615f75..b46efbf 100644 > > --- a/arch/x86/boot/compressed/eboot.c > > +++ b/arch/x86/boot/compressed/eboot.c > > @@ -258,7 +258,9 @@ static efi_status_t setup_efi_vars(struct boot_params *params) > > u64 store_size, remaining_size, var_size; > > efi_status_t status; > > > > - if (!sys_table->runtime->query_variable_info) > > + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) > > + return EFI_UNSUPPORTED; > > + else if(!sys_table->runtime->query_variable_info) > > return EFI_UNSUPPORTED; > > > > data = (struct setup_data *)(unsigned long)params->hdr.setup_data; > > > > Thanks Josh, that looks correct. > > It's a small point, but does the check against NULL actually make sense? > I don't think we ever check other system table pointers against NULL. That I'm not sure of. I was going off of the assumption that Matthew put it there because someone's EFI 2.0 implementation was crappy and didn't actually implement it. So I left that check in place for now. josh ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <20130424145449.GC15272-dHPIJuKSOV01V+h/cAXI7w8O6CCKKCg3HZ5vskTnxNA@public.gmane.org>]
* Re: [PATCH] efi: Check EFI revision in setup_efi_vars 2013-04-24 14:54 ` Josh Boyer @ 2013-04-24 14:57 ` Matt Fleming 0 siblings, 0 replies; 12+ messages in thread From: Matt Fleming @ 2013-04-24 14:57 UTC (permalink / raw) To: Josh Boyer Cc: Matthew Garrett, linux-efi-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 24/04/13 15:54, Josh Boyer wrote: > On Wed, Apr 24, 2013 at 03:44:30PM +0100, Matt Fleming wrote: >> On 24/04/13 15:37, Josh Boyer wrote: >>> We need to check the runtime sys_table for the EFI version the firmware >>> specifies instead of just checking for a NULL QueryVariableInfo. Older >>> implementations of EFI don't have QueryVariableInfo but the runtime is >>> a smaller structure, so the pointer to it may be pointing off into garbage. >>> >>> This is apparently the case with several Apple firmwares that support EFI >>> 1.10, and the current check causes them to no longer boot. Fix based on >>> a suggestion from Matthew Garrett. >>> >>> Signed-off-by: Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> >>> --- >>> arch/x86/boot/compressed/eboot.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c >>> index 8615f75..b46efbf 100644 >>> --- a/arch/x86/boot/compressed/eboot.c >>> +++ b/arch/x86/boot/compressed/eboot.c >>> @@ -258,7 +258,9 @@ static efi_status_t setup_efi_vars(struct boot_params *params) >>> u64 store_size, remaining_size, var_size; >>> efi_status_t status; >>> >>> - if (!sys_table->runtime->query_variable_info) >>> + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) >>> + return EFI_UNSUPPORTED; >>> + else if(!sys_table->runtime->query_variable_info) >>> return EFI_UNSUPPORTED; >>> >>> data = (struct setup_data *)(unsigned long)params->hdr.setup_data; >>> >> >> Thanks Josh, that looks correct. >> >> It's a small point, but does the check against NULL actually make sense? >> I don't think we ever check other system table pointers against NULL. > > That I'm not sure of. I was going off of the assumption that Matthew > put it there because someone's EFI 2.0 implementation was crappy and > didn't actually implement it. So I left that check in place for now. I presume that if that were true, virt_efi_query_variable_info() (which is called indirectly from the efivars code) would have exploded before now. Matthew? ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] efi: Check EFI revision in setup_efi_vars @ 2013-04-24 14:57 ` Matt Fleming 0 siblings, 0 replies; 12+ messages in thread From: Matt Fleming @ 2013-04-24 14:57 UTC (permalink / raw) To: Josh Boyer; +Cc: Matthew Garrett, linux-efi, linux-kernel On 24/04/13 15:54, Josh Boyer wrote: > On Wed, Apr 24, 2013 at 03:44:30PM +0100, Matt Fleming wrote: >> On 24/04/13 15:37, Josh Boyer wrote: >>> We need to check the runtime sys_table for the EFI version the firmware >>> specifies instead of just checking for a NULL QueryVariableInfo. Older >>> implementations of EFI don't have QueryVariableInfo but the runtime is >>> a smaller structure, so the pointer to it may be pointing off into garbage. >>> >>> This is apparently the case with several Apple firmwares that support EFI >>> 1.10, and the current check causes them to no longer boot. Fix based on >>> a suggestion from Matthew Garrett. >>> >>> Signed-off-by: Josh Boyer <jwboyer@redhat.com> >>> --- >>> arch/x86/boot/compressed/eboot.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c >>> index 8615f75..b46efbf 100644 >>> --- a/arch/x86/boot/compressed/eboot.c >>> +++ b/arch/x86/boot/compressed/eboot.c >>> @@ -258,7 +258,9 @@ static efi_status_t setup_efi_vars(struct boot_params *params) >>> u64 store_size, remaining_size, var_size; >>> efi_status_t status; >>> >>> - if (!sys_table->runtime->query_variable_info) >>> + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) >>> + return EFI_UNSUPPORTED; >>> + else if(!sys_table->runtime->query_variable_info) >>> return EFI_UNSUPPORTED; >>> >>> data = (struct setup_data *)(unsigned long)params->hdr.setup_data; >>> >> >> Thanks Josh, that looks correct. >> >> It's a small point, but does the check against NULL actually make sense? >> I don't think we ever check other system table pointers against NULL. > > That I'm not sure of. I was going off of the assumption that Matthew > put it there because someone's EFI 2.0 implementation was crappy and > didn't actually implement it. So I left that check in place for now. I presume that if that were true, virt_efi_query_variable_info() (which is called indirectly from the efivars code) would have exploded before now. Matthew? ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <5177F2C3.5080907-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] efi: Check EFI revision in setup_efi_vars 2013-04-24 14:57 ` Matt Fleming @ 2013-04-24 15:01 ` Matthew Garrett -1 siblings, 0 replies; 12+ messages in thread From: Matthew Garrett @ 2013-04-24 15:01 UTC (permalink / raw) To: Matt Fleming Cc: Josh Boyer, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, 2013-04-24 at 15:57 +0100, Matt Fleming wrote: > I presume that if that were true, virt_efi_query_variable_info() (which > is called indirectly from the efivars code) would have exploded before > now. Matthew? Yeah, it's probably safe to lose it. -- Matthew Garrett | mjg59@srcf.ucam.org ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] efi: Check EFI revision in setup_efi_vars @ 2013-04-24 15:01 ` Matthew Garrett 0 siblings, 0 replies; 12+ messages in thread From: Matthew Garrett @ 2013-04-24 15:01 UTC (permalink / raw) To: Matt Fleming Cc: Josh Boyer, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 460 bytes --] On Wed, 2013-04-24 at 15:57 +0100, Matt Fleming wrote: > I presume that if that were true, virt_efi_query_variable_info() (which > is called indirectly from the efivars code) would have exploded before > now. Matthew? Yeah, it's probably safe to lose it. -- Matthew Garrett | mjg59@srcf.ucam.org ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥ ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] efi: Check EFI revision in setup_efi_vars 2013-04-24 15:01 ` Matthew Garrett @ 2013-04-24 15:16 ` Josh Boyer -1 siblings, 0 replies; 12+ messages in thread From: Josh Boyer @ 2013-04-24 15:16 UTC (permalink / raw) To: Matt Fleming, Matthew Garrett Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org We need to check the runtime sys_table for the EFI version the firmware specifies instead of just checking for a NULL QueryVariableInfo. Older implementations of EFI don't have QueryVariableInfo but the runtime is a smaller structure, so the pointer to it may be pointing off into garbage. This is apparently the case with several Apple firmwares that support EFI 1.10, and the current check causes them to no longer boot. Fix based on a suggestion from Matthew Garrett. Signed-off-by: Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> --- v2: Drop the unnecessary NULL check arch/x86/boot/compressed/eboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index 8615f75..4060c8d 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -258,7 +258,7 @@ static efi_status_t setup_efi_vars(struct boot_params *params) u64 store_size, remaining_size, var_size; efi_status_t status; - if (!sys_table->runtime->query_variable_info) + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) return EFI_UNSUPPORTED; data = (struct setup_data *)(unsigned long)params->hdr.setup_data; -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2] efi: Check EFI revision in setup_efi_vars @ 2013-04-24 15:16 ` Josh Boyer 0 siblings, 0 replies; 12+ messages in thread From: Josh Boyer @ 2013-04-24 15:16 UTC (permalink / raw) To: Matt Fleming, Matthew Garrett Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org We need to check the runtime sys_table for the EFI version the firmware specifies instead of just checking for a NULL QueryVariableInfo. Older implementations of EFI don't have QueryVariableInfo but the runtime is a smaller structure, so the pointer to it may be pointing off into garbage. This is apparently the case with several Apple firmwares that support EFI 1.10, and the current check causes them to no longer boot. Fix based on a suggestion from Matthew Garrett. Signed-off-by: Josh Boyer <jwboyer@redhat.com> --- v2: Drop the unnecessary NULL check arch/x86/boot/compressed/eboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index 8615f75..4060c8d 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -258,7 +258,7 @@ static efi_status_t setup_efi_vars(struct boot_params *params) u64 store_size, remaining_size, var_size; efi_status_t status; - if (!sys_table->runtime->query_variable_info) + if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION) return EFI_UNSUPPORTED; data = (struct setup_data *)(unsigned long)params->hdr.setup_data; -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] efi: Check EFI revision in setup_efi_vars 2013-04-24 15:16 ` Josh Boyer (?) @ 2013-04-24 15:20 ` Matt Fleming -1 siblings, 0 replies; 12+ messages in thread From: Matt Fleming @ 2013-04-24 15:20 UTC (permalink / raw) To: Josh Boyer Cc: Matthew Garrett, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org On 24/04/13 16:16, Josh Boyer wrote: > We need to check the runtime sys_table for the EFI version the firmware > specifies instead of just checking for a NULL QueryVariableInfo. Older > implementations of EFI don't have QueryVariableInfo but the runtime is > a smaller structure, so the pointer to it may be pointing off into garbage. > > This is apparently the case with several Apple firmwares that support EFI > 1.10, and the current check causes them to no longer boot. Fix based on > a suggestion from Matthew Garrett. > > Signed-off-by: Josh Boyer <jwboyer@redhat.com> > --- > v2: Drop the unnecessary NULL check > > arch/x86/boot/compressed/eboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied. ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-04-24 15:20 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-24 14:37 [PATCH] efi: Check EFI revision in setup_efi_vars Josh Boyer
2013-04-24 14:37 ` Josh Boyer
[not found] ` <20130424143738.GB15272-dHPIJuKSOV01V+h/cAXI7w8O6CCKKCg3HZ5vskTnxNA@public.gmane.org>
2013-04-24 14:44 ` Matt Fleming
2013-04-24 14:44 ` Matt Fleming
2013-04-24 14:54 ` Josh Boyer
[not found] ` <20130424145449.GC15272-dHPIJuKSOV01V+h/cAXI7w8O6CCKKCg3HZ5vskTnxNA@public.gmane.org>
2013-04-24 14:57 ` Matt Fleming
2013-04-24 14:57 ` Matt Fleming
[not found] ` <5177F2C3.5080907-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-04-24 15:01 ` Matthew Garrett
2013-04-24 15:01 ` Matthew Garrett
2013-04-24 15:16 ` [PATCH v2] " Josh Boyer
2013-04-24 15:16 ` Josh Boyer
2013-04-24 15:20 ` Matt Fleming
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.