Re: [Qemu-devel] [PATCH 4/7] m48t59: register a QOM type for each nvram type we support

["Hervé Poussineau" <hpoussin@reactos.org>]

Artyom Tarasenko a écrit :
> On Fri, May 3, 2013 at 7:50 AM, Hervé Poussineau <hpoussin@reactos.org> wrote:
>> Artyom Tarasenko a écrit :
>>
>>> On Thu, May 2, 2013 at 10:09 PM, Hervé Poussineau <hpoussin@reactos.org>
>>> wrote:
>>>> As m48t59 devices can only be created with m48t59_init() or
>>>> m48t59_init_isa(),
>>>> we know exactly which nvram types are required. Register only those three
>>>> types.
>>>
>>> Wasn't this patch NACKed by Blue?
>>
>> I think I changed what's requested, ie I kept the io-base property of the
>> ISA variant, so the sun4u emulation can be changed later to the right
>> address. However, fixing sun4u emulation is not part of this patchset.
> 
> Sorry, I misread the patch. The value 0x74 is now just a default value for
> the isa port, right? How would I create an isa m48t59 card on some other port?

Yes, 0x74 is now the default value.

You can create an isa m48t59 device on port 0x100
- with command line: -device isa-m4859,iobase=0x100
- in code using the helper: m48t59_init_isa(isa_bus, 0x100, 0x2000, 59);
- with QOM: DeviceState *dev;
             dev = DEVICE(isa_create(isa_bus, "isa-m48t59"));
             qdev_prop_set_uint16(dev, "iobase", 0x100);
             qdev_init_nofail(dev);

Hervé