From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
tony@atomide.com, linux-omap@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND][PATCH 1/3] arm: dts: introduce config HAS_BANDGAP
Date: Tue, 7 May 2013 09:15:00 -0400 [thread overview]
Message-ID: <5188FE54.6050200@ti.com> (raw)
In-Reply-To: <20130507003651.GA26035@obsidianresearch.com>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
Hello Jason,
On 06-05-2013 20:36, Jason Gunthorpe wrote:
> On Mon, May 06, 2013 at 08:23:13PM -0400, Eduardo Valentin wrote:
>
>>> I get the impression it is desired to minimize driver kconfig
>>> dependencies to the minimum required to compile to increase build
>>> testing coverage, so maybe it would be appropriate to drop this
>>> entirely?
>
>> Well, it is also desired to compile things to the correct target
>> right?
>
> There is some of that too..
>
> But broadly the direction seems that drivers should have minimal
> dependencies so, eg, the thermal maintainer compiling for x86 should
> be able to compile test/static analyze your driver..
>
Well, I do not see much of this attempt actually. Do you have some link
/ evidene that shows someone who actually cares about compiling drivers
for targets that they are not used for? On this specific driver, I
actually have had exactly the opposite advice [1]. I am not convinced
people actually want to do that.
>> Thats the idea behind this config option. It follows the same design as
>> CONFIG_ARCH_HAS_CPUFREQ, for instance.
>
> That is entirely contained inside arch/arm and doesn't involve
> drivers.
It actually goes outside arch/arm.
>
> Jason
>
>
[1] - https://patchwork.kernel.org/patch/1185431/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: eduardo.valentin@ti.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND][PATCH 1/3] arm: dts: introduce config HAS_BANDGAP
Date: Tue, 7 May 2013 09:15:00 -0400 [thread overview]
Message-ID: <5188FE54.6050200@ti.com> (raw)
In-Reply-To: <20130507003651.GA26035@obsidianresearch.com>
Hello Jason,
On 06-05-2013 20:36, Jason Gunthorpe wrote:
> On Mon, May 06, 2013 at 08:23:13PM -0400, Eduardo Valentin wrote:
>
>>> I get the impression it is desired to minimize driver kconfig
>>> dependencies to the minimum required to compile to increase build
>>> testing coverage, so maybe it would be appropriate to drop this
>>> entirely?
>
>> Well, it is also desired to compile things to the correct target
>> right?
>
> There is some of that too..
>
> But broadly the direction seems that drivers should have minimal
> dependencies so, eg, the thermal maintainer compiling for x86 should
> be able to compile test/static analyze your driver..
>
Well, I do not see much of this attempt actually. Do you have some link
/ evidene that shows someone who actually cares about compiling drivers
for targets that they are not used for? On this specific driver, I
actually have had exactly the opposite advice [1]. I am not convinced
people actually want to do that.
>> Thats the idea behind this config option. It follows the same design as
>> CONFIG_ARCH_HAS_CPUFREQ, for instance.
>
> That is entirely contained inside arch/arm and doesn't involve
> drivers.
It actually goes outside arch/arm.
>
> Jason
>
>
[1] - https://patchwork.kernel.org/patch/1185431/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 295 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130507/97d2e2b2/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>, <tony@atomide.com>,
<linux-omap@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND][PATCH 1/3] arm: dts: introduce config HAS_BANDGAP
Date: Tue, 7 May 2013 09:15:00 -0400 [thread overview]
Message-ID: <5188FE54.6050200@ti.com> (raw)
In-Reply-To: <20130507003651.GA26035@obsidianresearch.com>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
Hello Jason,
On 06-05-2013 20:36, Jason Gunthorpe wrote:
> On Mon, May 06, 2013 at 08:23:13PM -0400, Eduardo Valentin wrote:
>
>>> I get the impression it is desired to minimize driver kconfig
>>> dependencies to the minimum required to compile to increase build
>>> testing coverage, so maybe it would be appropriate to drop this
>>> entirely?
>
>> Well, it is also desired to compile things to the correct target
>> right?
>
> There is some of that too..
>
> But broadly the direction seems that drivers should have minimal
> dependencies so, eg, the thermal maintainer compiling for x86 should
> be able to compile test/static analyze your driver..
>
Well, I do not see much of this attempt actually. Do you have some link
/ evidene that shows someone who actually cares about compiling drivers
for targets that they are not used for? On this specific driver, I
actually have had exactly the opposite advice [1]. I am not convinced
people actually want to do that.
>> Thats the idea behind this config option. It follows the same design as
>> CONFIG_ARCH_HAS_CPUFREQ, for instance.
>
> That is entirely contained inside arch/arm and doesn't involve
> drivers.
It actually goes outside arch/arm.
>
> Jason
>
>
[1] - https://patchwork.kernel.org/patch/1185431/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
next prev parent reply other threads:[~2013-05-07 13:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 21:00 [RESEND][PATCH 0/3] arm: enable TI SoC thermal driver Eduardo Valentin
2013-05-06 21:00 ` [RESEND][PATCH 1/3] arm: dts: introduce config HAS_BANDGAP Eduardo Valentin
2013-05-06 21:00 ` Eduardo Valentin
2013-05-06 21:00 ` Eduardo Valentin
2013-05-06 21:31 ` Stephen Warren
2013-05-06 21:31 ` Stephen Warren
2013-05-07 0:20 ` Eduardo Valentin
2013-05-07 0:20 ` Eduardo Valentin
2013-05-07 0:20 ` Eduardo Valentin
2013-05-06 21:34 ` Aaro Koskinen
2013-05-06 21:34 ` Aaro Koskinen
2013-05-06 22:36 ` Jason Gunthorpe
2013-05-06 22:36 ` Jason Gunthorpe
2013-05-07 0:23 ` Eduardo Valentin
2013-05-07 0:23 ` Eduardo Valentin
2013-05-07 0:23 ` Eduardo Valentin
2013-05-07 0:36 ` Jason Gunthorpe
2013-05-07 0:36 ` Jason Gunthorpe
2013-05-07 0:36 ` Jason Gunthorpe
2013-05-07 13:15 ` Eduardo Valentin [this message]
2013-05-07 13:15 ` Eduardo Valentin
2013-05-07 13:15 ` Eduardo Valentin
2013-05-07 18:27 ` Jason Gunthorpe
2013-05-07 18:27 ` Jason Gunthorpe
2013-05-07 19:06 ` Aaro Koskinen
2013-05-07 19:06 ` Aaro Koskinen
2013-05-08 6:04 ` Tomi Valkeinen
2013-05-08 6:04 ` Tomi Valkeinen
2013-05-08 6:04 ` Tomi Valkeinen
2013-05-06 22:40 ` Eduardo Valentin
2013-05-06 22:40 ` Eduardo Valentin
2013-05-06 22:40 ` Eduardo Valentin
2013-05-06 21:00 ` [RESEND][PATCH 2/3] arm: dts: add bandgap entry for OMAP443x devices Eduardo Valentin
2013-05-06 21:00 ` Eduardo Valentin
2013-05-06 21:00 ` Eduardo Valentin
2013-05-06 21:00 ` [RESEND][PATCH 3/3] arm: add bandgap entry for OMAP4460 devices Eduardo Valentin
2013-05-06 21:00 ` Eduardo Valentin
2013-05-06 21:00 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188FE54.6050200@ti.com \
--to=eduardo.valentin@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.