From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Chen Gang <gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'
Date: Wed, 8 May 2013 08:50:46 +0800 [thread overview]
Message-ID: <5189A166.9080301@huawei.com> (raw)
In-Reply-To: <5188E391.6040505-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
>> There's a bug in cgroup_unload_subsys() that idr_destroy() should be called after
>> ss->css_free(). That said, given there's no modular cgroup subsystem using css_id,
>> and the whole css_id thing will be eliminated in 3.11, why bother fixing it.
>>
>
> I just find it by reading code (I also want to learn about kernel).
>
> I guess, for some stable versions, may focus on it, they are the
> different branches from the latest version.
>
> So, is it suitable to send related patch for the bug ?
>
As I said, there's no modular cgroup subsystem using css_id, so the bug
doesn't exist in real world.
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: <tj@kernel.org>, <containers@lists.linux-foundation.org>,
<cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'
Date: Wed, 8 May 2013 08:50:46 +0800 [thread overview]
Message-ID: <5189A166.9080301@huawei.com> (raw)
In-Reply-To: <5188E391.6040505@asianux.com>
>> There's a bug in cgroup_unload_subsys() that idr_destroy() should be called after
>> ss->css_free(). That said, given there's no modular cgroup subsystem using css_id,
>> and the whole css_id thing will be eliminated in 3.11, why bother fixing it.
>>
>
> I just find it by reading code (I also want to learn about kernel).
>
> I guess, for some stable versions, may focus on it, they are the
> different branches from the latest version.
>
> So, is it suitable to send related patch for the bug ?
>
As I said, there's no modular cgroup subsystem using css_id, so the bug
doesn't exist in real world.
next prev parent reply other threads:[~2013-05-08 0:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 10:46 [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid' Chen Gang
2013-05-07 10:46 ` Chen Gang
[not found] ` <5188DB93.2080504-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-07 11:01 ` Li Zefan
2013-05-07 11:01 ` Li Zefan
[not found] ` <5188DF27.4080000-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-07 11:20 ` Chen Gang
2013-05-07 11:20 ` Chen Gang
[not found] ` <5188E391.6040505-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-08 0:50 ` Li Zefan [this message]
2013-05-08 0:50 ` Li Zefan
[not found] ` <5189A166.9080301-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-08 2:00 ` Chen Gang
2013-05-08 2:00 ` Chen Gang
2013-05-07 11:20 ` Chen Gang
-- strict thread matches above, loose matches on Subject: below --
2013-05-07 10:46 Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5189A166.9080301@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.