All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'
Date: Wed, 08 May 2013 10:00:14 +0800	[thread overview]
Message-ID: <5189B1AE.4000906@asianux.com> (raw)
In-Reply-To: <5189A166.9080301-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On 2013年05月08日 08:50, Li Zefan wrote:
>>> There's a bug in cgroup_unload_subsys() that idr_destroy() should be called after
>>> >> ss->css_free(). That said, given there's no modular cgroup subsystem using css_id,
>>> >> and the whole css_id thing will be eliminated in 3.11, why bother fixing it.
>>> >>
>> > 
>> > I just find it by reading code (I also want to learn about kernel).
>> > 
>> > I guess, for some stable versions, may focus on it, they are the
>> > different branches from the latest version.
>> > 
>> > So, is it suitable to send related patch for the bug ?
>> > 
> As I said, there's no modular cgroup subsystem using css_id, so the bug
> doesn't exist in real world.
> 
> 
> 

Excuse me, my English is not quite well, I guess what you said is:

  a. idr_destroy() should be called after ss->css_free()
  b. need check the return value of cgroup_init_idr() in cgroup_init().

  but all features which related with the 2 issues above, never be used
in any main linux main branches.
  so, the 2 bugs doesn't exist in real world.

Is what I guess correct ?

Thanks.

-- 
Chen Gang

Asianux Corporation
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers

WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen@asianux.com>
To: Li Zefan <lizefan@huawei.com>
Cc: tj@kernel.org, containers@lists.linux-foundation.org,
	cgroups@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'
Date: Wed, 08 May 2013 10:00:14 +0800	[thread overview]
Message-ID: <5189B1AE.4000906@asianux.com> (raw)
In-Reply-To: <5189A166.9080301@huawei.com>

On 2013年05月08日 08:50, Li Zefan wrote:
>>> There's a bug in cgroup_unload_subsys() that idr_destroy() should be called after
>>> >> ss->css_free(). That said, given there's no modular cgroup subsystem using css_id,
>>> >> and the whole css_id thing will be eliminated in 3.11, why bother fixing it.
>>> >>
>> > 
>> > I just find it by reading code (I also want to learn about kernel).
>> > 
>> > I guess, for some stable versions, may focus on it, they are the
>> > different branches from the latest version.
>> > 
>> > So, is it suitable to send related patch for the bug ?
>> > 
> As I said, there's no modular cgroup subsystem using css_id, so the bug
> doesn't exist in real world.
> 
> 
> 

Excuse me, my English is not quite well, I guess what you said is:

  a. idr_destroy() should be called after ss->css_free()
  b. need check the return value of cgroup_init_idr() in cgroup_init().

  but all features which related with the 2 issues above, never be used
in any main linux main branches.
  so, the 2 bugs doesn't exist in real world.

Is what I guess correct ?

Thanks.

-- 
Chen Gang

Asianux Corporation

  parent reply	other threads:[~2013-05-08  2:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07 10:46 [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid' Chen Gang
2013-05-07 10:46 ` Chen Gang
     [not found] ` <5188DB93.2080504-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-07 11:01   ` Li Zefan
2013-05-07 11:01     ` Li Zefan
     [not found]     ` <5188DF27.4080000-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-07 11:20       ` Chen Gang
2013-05-07 11:20       ` Chen Gang
2013-05-07 11:20         ` Chen Gang
     [not found]         ` <5188E391.6040505-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-08  0:50           ` Li Zefan
2013-05-08  0:50             ` Li Zefan
     [not found]             ` <5189A166.9080301-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-08  2:00               ` Chen Gang [this message]
2013-05-08  2:00                 ` Chen Gang
  -- strict thread matches above, loose matches on Subject: below --
2013-05-07 10:46 Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5189B1AE.4000906@asianux.com \
    --to=gang.chen-boixzgp5f+dbdgjk7y7tuq@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.