From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH (trivial)] remove some double-includes
Date: Tue, 14 May 2013 18:15:16 +0400 [thread overview]
Message-ID: <519246F4.4040803@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAFEAcA_P78TYqZGr0reev4Oa=4j1qoKaGbC6rEnBDeMtUo-TTg@mail.gmail.com>
14.05.2013 15:30, Peter Maydell wrote:
> On 14 May 2013 12:18, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Some source files #include the same header more than
>> once for no good reason. Remove second #includes in
>> such cases.
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..a18bf55 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -52,21 +52,20 @@
>> #include <libutil.h>
>> #endif
>> #endif
>> #else
>> #include "exec/address-spaces.h"
>> #endif
>> #include "qemu/timer.h"
>>
>> #include "exec/cputlb.h"
>> #include "translate-all.h"
>> -#include "qemu/timer.h"
>
> There's already been a patch on the list for this one:
> http://patchwork.ozlabs.org/patch/240540/
>
Yes I know Peter, and actually this is the patch which prompte
me to look for other places. The person in question does not
reply (so far), so I thought maybe cleaning up more duplicates
is a good idea, or else the patch will just stuck.
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH (trivial)] remove some double-includes
Date: Tue, 14 May 2013 18:15:16 +0400 [thread overview]
Message-ID: <519246F4.4040803@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAFEAcA_P78TYqZGr0reev4Oa=4j1qoKaGbC6rEnBDeMtUo-TTg@mail.gmail.com>
14.05.2013 15:30, Peter Maydell wrote:
> On 14 May 2013 12:18, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Some source files #include the same header more than
>> once for no good reason. Remove second #includes in
>> such cases.
>>
>> diff --git a/translate-all.c b/translate-all.c
>> index da93608..a18bf55 100644
>> --- a/translate-all.c
>> +++ b/translate-all.c
>> @@ -52,21 +52,20 @@
>> #include <libutil.h>
>> #endif
>> #endif
>> #else
>> #include "exec/address-spaces.h"
>> #endif
>> #include "qemu/timer.h"
>>
>> #include "exec/cputlb.h"
>> #include "translate-all.h"
>> -#include "qemu/timer.h"
>
> There's already been a patch on the list for this one:
> http://patchwork.ozlabs.org/patch/240540/
>
Yes I know Peter, and actually this is the patch which prompte
me to look for other places. The person in question does not
reply (so far), so I thought maybe cleaning up more duplicates
is a good idea, or else the patch will just stuck.
/mjt
next prev parent reply other threads:[~2013-05-14 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 11:18 [Qemu-trivial] [PATCH (trivial)] remove some double-includes Michael Tokarev
2013-05-14 11:18 ` [Qemu-devel] " Michael Tokarev
2013-05-14 11:30 ` [Qemu-trivial] " Peter Maydell
2013-05-14 11:30 ` Peter Maydell
2013-05-14 14:15 ` Michael Tokarev [this message]
2013-05-14 14:15 ` Michael Tokarev
2013-05-14 14:16 ` [Qemu-trivial] " Peter Maydell
2013-05-14 14:16 ` Peter Maydell
2013-05-14 14:20 ` [Qemu-trivial] " Michael Tokarev
2013-05-14 14:20 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519246F4.4040803@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.