All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Jenifer Hopper <jhopper@us.ibm.com>, Mel Gorman <mgorman@suse.de>,
	Johannes Weiner <jweiner@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Larry Woodman <lwoodman@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joe Perches <joe@perches.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Cody P Schafer <cody@linux.vnet.ibm.com>,
	Hugh Dickens <hughd@google.com>,
	Paul Mackerras <paulus@samba.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org
Subject: Re: [PATCHv11 3/4] zswap: add to mm/
Date: Wed, 15 May 2013 13:24:07 -0700	[thread overview]
Message-ID: <5193EEE7.80603@sr71.net> (raw)
In-Reply-To: <20130515200942.GA17724@cerebellum>

On 05/15/2013 01:09 PM, Seth Jennings wrote:
> On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote:
>>> Sorry, but I don't think that's appropriate for a patch in the MM subsystem.
>>
>> Perhaps a compromise can be reached where this code is merged as a driver
>> not a core mm component. There is a high bar to be in the MM - it has to
>> work with many many different configurations. 
>>
>> And drivers don't have such a high bar. They just need to work on a specific
>> issue and that is it. If zswap ended up in say, drivers/mm that would make
>> it more palpable I think.

The issue is not whether it is a loadable module or a driver.  Nobody
here is stupid enough to say, "hey, now it's a driver/module, all of the
complex VM interactions are finally fixed!"

If folks don't want this in their system, there's a way to turn it off,
today, with the sysfs tunables.  We don't need _another_ way to turn it
off at runtime (unloading the module/driver).


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Jenifer Hopper <jhopper@us.ibm.com>, Mel Gorman <mgorman@suse.de>,
	Johannes Weiner <jweiner@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Larry Woodman <lwoodman@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joe Perches <joe@perches.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Cody P Schafer <cody@linux.vnet.ibm.com>,
	Hugh Dickens <hughd@google.com>,
	Paul Mackerras <paulus@samba.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org
Subject: Re: [PATCHv11 3/4] zswap: add to mm/
Date: Wed, 15 May 2013 13:24:07 -0700	[thread overview]
Message-ID: <5193EEE7.80603@sr71.net> (raw)
In-Reply-To: <20130515200942.GA17724@cerebellum>

On 05/15/2013 01:09 PM, Seth Jennings wrote:
> On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote:
>>> Sorry, but I don't think that's appropriate for a patch in the MM subsystem.
>>
>> Perhaps a compromise can be reached where this code is merged as a driver
>> not a core mm component. There is a high bar to be in the MM - it has to
>> work with many many different configurations. 
>>
>> And drivers don't have such a high bar. They just need to work on a specific
>> issue and that is it. If zswap ended up in say, drivers/mm that would make
>> it more palpable I think.

The issue is not whether it is a loadable module or a driver.  Nobody
here is stupid enough to say, "hey, now it's a driver/module, all of the
complex VM interactions are finally fixed!"

If folks don't want this in their system, there's a way to turn it off,
today, with the sysfs tunables.  We don't need _another_ way to turn it
off at runtime (unloading the module/driver).



  reply	other threads:[~2013-05-15 20:24 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<1368448803-2089-1-git-send-email-sjenning@linux.vnet.ibm.com>
     [not found] ` <<1368448803-2089-3-git-send-email-sjenning@linux.vnet.ibm.com>
2013-05-13 15:43   ` [PATCHv11 2/4] zbud: add to mm/ Dan Magenheimer
2013-05-13 15:43     ` Dan Magenheimer
2013-05-13 20:59     ` Seth Jennings
2013-05-13 20:59       ` Seth Jennings
2013-05-16 15:30       ` Rik van Riel
2013-05-16 15:30         ` Rik van Riel
     [not found] ` <<1368448803-2089-4-git-send-email-sjenning@linux.vnet.ibm.com>
2013-05-13 22:31   ` [PATCHv11 3/4] zswap: " Dan Magenheimer
2013-05-13 22:31     ` Dan Magenheimer
2013-05-14 16:35     ` Seth Jennings
2013-05-14 16:35       ` Seth Jennings
2013-05-14 20:18       ` Dan Magenheimer
2013-05-14 20:18         ` Dan Magenheimer
2013-05-14 22:55         ` Seth Jennings
2013-05-14 22:55           ` Seth Jennings
2013-05-15 17:09           ` Dan Magenheimer
2013-05-15 17:09             ` Dan Magenheimer
2013-05-15 18:55             ` Konrad Rzeszutek Wilk
2013-05-15 18:55               ` Konrad Rzeszutek Wilk
2013-05-15 19:35               ` Dan Magenheimer
2013-05-15 19:35                 ` Dan Magenheimer
2013-05-15 20:45                 ` Rik van Riel
2013-05-15 20:45                   ` Rik van Riel
2013-05-15 21:36                   ` Dan Magenheimer
2013-05-15 21:36                     ` Dan Magenheimer
2013-05-15 22:01                     ` Rik van Riel
2013-05-15 22:01                       ` Rik van Riel
2013-05-15 20:09               ` Seth Jennings
2013-05-15 20:09                 ` Seth Jennings
2013-05-15 20:24                 ` Dave Hansen [this message]
2013-05-15 20:24                   ` Dave Hansen
2013-05-15 20:55                   ` Dan Magenheimer
2013-05-15 20:55                     ` Dan Magenheimer
2013-05-15 20:45                 ` Konrad Rzeszutek Wilk
2013-05-15 20:45                   ` Konrad Rzeszutek Wilk
2013-05-15 20:52                 ` Dan Magenheimer
2013-05-15 20:52                   ` Dan Magenheimer
2013-05-15 22:14         ` Rik van Riel
2013-05-15 22:14           ` Rik van Riel
2013-05-16 16:45           ` Dan Magenheimer
2013-05-16 16:45             ` Dan Magenheimer
2013-05-16 17:06             ` Rik van Riel
2013-05-16 17:06               ` Rik van Riel
2013-05-13 12:39 [PATCHv11 0/4] zswap: compressed swap caching Seth Jennings
2013-05-13 12:39 ` Seth Jennings
2013-05-13 12:40 ` [PATCHv11 1/4] debugfs: add get/set for atomic types Seth Jennings
2013-05-13 12:40   ` Seth Jennings
2013-05-16 14:58   ` Rik van Riel
2013-05-16 14:58     ` Rik van Riel
2013-05-13 12:40 ` [PATCHv11 2/4] zbud: add to mm/ Seth Jennings
2013-05-13 12:40   ` Seth Jennings
2013-05-14  8:47   ` Bob Liu
2013-05-14  8:47     ` Bob Liu
2013-05-14 17:03     ` Seth Jennings
2013-05-14 17:03       ` Seth Jennings
2013-05-16 15:30   ` Rik van Riel
2013-05-16 15:30     ` Rik van Riel
2013-05-17 15:48   ` Mel Gorman
2013-05-17 15:48     ` Mel Gorman
2013-05-19 20:52     ` Seth Jennings
2013-05-19 20:52       ` Seth Jennings
2013-05-20 13:54       ` Mel Gorman
2013-05-20 13:54         ` Mel Gorman
2013-05-20 15:42         ` Seth Jennings
2013-05-20 15:42           ` Seth Jennings
2013-05-21  8:10           ` Mel Gorman
2013-05-21  8:10             ` Mel Gorman
2013-05-23  2:00             ` Bob Liu
2013-05-23  2:00               ` Bob Liu
2013-05-23  9:52               ` Mel Gorman
2013-05-23  9:52                 ` Mel Gorman
2013-05-13 12:40 ` [PATCHv11 3/4] zswap: " Seth Jennings
2013-05-13 12:40   ` Seth Jennings
2013-05-14  9:19   ` Bob Liu
2013-05-14  9:19     ` Bob Liu
2013-05-14 16:00     ` Seth Jennings
2013-05-14 16:00       ` Seth Jennings
2013-05-14 16:37       ` Dan Magenheimer
2013-05-14 16:37         ` Dan Magenheimer
2013-05-14 17:28         ` Seth Jennings
2013-05-14 17:28           ` Seth Jennings
2013-05-14 20:54           ` Dan Magenheimer
2013-05-14 20:54             ` Dan Magenheimer
2013-05-17 17:00         ` Mel Gorman
2013-05-17 17:00           ` Mel Gorman
2013-05-16 17:16   ` Rik van Riel
2013-05-16 17:16     ` Rik van Riel
2013-05-17 16:54   ` Mel Gorman
2013-05-17 16:54     ` Mel Gorman
2013-05-19 23:33     ` Seth Jennings
2013-05-19 23:33       ` Seth Jennings
2013-05-13 12:40 ` [PATCHv11 4/4] zswap: add documentation Seth Jennings
2013-05-13 12:40   ` Seth Jennings
2013-05-16 17:06   ` Rik van Riel
2013-05-16 17:06     ` Rik van Riel
2013-05-17 16:04   ` Mel Gorman
2013-05-17 16:04     ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5193EEE7.80603@sr71.net \
    --to=dave@sr71.net \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=cody@linux.vnet.ibm.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jhopper@us.ibm.com \
    --cc=joe@perches.com \
    --cc=jweiner@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lwoodman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=paulus@samba.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.