Re: 3.9.2 kernel - IR / em28xx_rc broken?

["Frank Schäfer" <fschaefer.oss@googlemail.com>]

Am 19.05.2013 16:11, schrieb Chris Rankin:
> ----- Original Message -----
>
>> em28xx_ir_change_protocol() should be called at least twice:
>> First from em28xx_ir_init() with RC_BIT_UNKNOWN (initial configuration) 
>> and later from the RC core with RC_BIT_RC5.
>> Can you confirm that ?
> Yes, it does appear to be called twice: first with *rc_type=1 and then later with *rc_type=8.

Good, that's how it should be.

>  But that still doesn't seem to stop ir->rc_type being RC_BIT_UNKNOWN in em2874_polling_getkey().

Hmm... that's weird. Are you sure about that ? Is this really a 3.9.2
vanilla kernel ?
The code looks good, ir->rc_type is updated by
em2874_ir_change_protocol() when the protocol is changed.
I also tried to reproduce your problem with a em2884 device with a RC5
remote control a few minutes ago, but everything works as expected...

One thing I noticed is that in em28xx_ir_handle_key() ir->last_readcount
is reset to 0 for the em2874 and em2884.
I assume the same should be done for em28174, too...
Anyway, that's a separate issue and older kernels did the same.

Regards,
Frank