All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bestcomm: no need to free when kzalloc fail
@ 2013-05-05  8:38 chenlibo.3
  2013-05-22  4:49   ` Libo Chen
  0 siblings, 1 reply; 11+ messages in thread
From: chenlibo.3 @ 2013-05-05  8:38 UTC (permalink / raw)
  To: grant.likely, rob.herring; +Cc: linux-kernel, devicetree-discuss, Libo Chen

From: Libo Chen <libo.chen@huawei.com>

There is no need to free bcom_eng if kzalloc fail

Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
 drivers/dma/bestcomm/bestcomm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c
index a8c2e29..300ee2d 100644
--- a/drivers/dma/bestcomm/bestcomm.c
+++ b/drivers/dma/bestcomm/bestcomm.c
@@ -400,7 +400,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op)
 		printk(KERN_ERR DRIVER_NAME ": "
 			"Can't allocate state structure\n");
 		rv = -ENOMEM;
-		goto error_sramclean;
+		goto error_kzalloc;
 	}
 
 	/* Save the node */
@@ -449,6 +449,7 @@ error_release:
 	release_mem_region(res_bcom.start, sizeof(struct mpc52xx_sdma));
 error_sramclean:
 	kfree(bcom_eng);
+error_kzalloc:
 	bcom_sram_cleanup();
 error_ofput:
 	of_node_put(op->dev.of_node);
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2013-05-22  6:38 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-05  8:38 [PATCH] bestcomm: no need to free when kzalloc fail chenlibo.3
2013-05-22  4:49 ` Libo Chen
2013-05-22  4:49   ` Libo Chen
2013-05-22  4:58   ` Li Zefan
2013-05-22  4:58     ` Li Zefan
2013-05-22  6:03     ` Libo Chen
2013-05-22  6:03       ` Libo Chen
     [not found]   ` <519C4E4D.1060101-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-22  6:06     ` Benjamin Herrenschmidt
2013-05-22  6:06       ` Benjamin Herrenschmidt
2013-05-22  6:35       ` Libo Chen
2013-05-22  6:35         ` Libo Chen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.