From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: jirislaby@gmail.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Mahoney <jeffm@suse.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
"Keller, Jacob E" <jacob.e.keller@intel.com>
Subject: Re: [PATCH] build some drivers only when compile-testing
Date: Thu, 23 May 2013 07:46:57 +0000 [thread overview]
Message-ID: <519DC971.80406@ti.com> (raw)
In-Reply-To: <1369214326-6558-1-git-send-email-jslaby@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]
Hi,
On 22/05/13 12:18, Jiri Slaby wrote:
> Some drivers can be built on more platforms than they run on. This
> causes users and distributors packaging burden when they have to
> manually deselect some drivers from their allmodconfigs. Or sometimes
> it is even impossible to disable the drivers without patching the
> kernel.
>
> Introduce a new config option COMPILE_TEST and make all those drivers
> to depend on the platform they run on, or on the COMPILE_TEST option.
> Now, when users/distributors choose COMPILE_TEST=n they will not have
> the drivers in their allmodconfig setups, but developers still can
> compile-test them with COMPILE_TEST=y.
>
> Now the drivers where we use this new option:
> * PTP_1588_CLOCK_PCH: The PCH EG20T is only compatible with Intel Atom
> processors so it should depend on x86.
> * FB_GEODE: Geode is 32-bit only so only enable it for X86_32.
> * USB_CHIPIDEA_IMX: The OF_DEVICE dependency will be met on powerpc
> systems -- which do not actually support the hardware via that
> method.
I had this exact same idea some time ago. The mail below contains some
of my reasoning for this:
http://comments.gmane.org/gmane.linux.kbuild.devel/9829
I proposed a new Kconfig keyword, but Sam was quite against it as the
Kconfig language already does what is required.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: <jirislaby@gmail.com>, <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Mahoney <jeffm@suse.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
<linux-geode@lists.infradead.org>, <linux-fbdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
<netdev@vger.kernel.org>, Ben Hutchings <ben@decadent.org.uk>,
"Keller, Jacob E" <jacob.e.keller@intel.com>
Subject: Re: [PATCH] build some drivers only when compile-testing
Date: Thu, 23 May 2013 10:46:57 +0300 [thread overview]
Message-ID: <519DC971.80406@ti.com> (raw)
In-Reply-To: <1369214326-6558-1-git-send-email-jslaby@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]
Hi,
On 22/05/13 12:18, Jiri Slaby wrote:
> Some drivers can be built on more platforms than they run on. This
> causes users and distributors packaging burden when they have to
> manually deselect some drivers from their allmodconfigs. Or sometimes
> it is even impossible to disable the drivers without patching the
> kernel.
>
> Introduce a new config option COMPILE_TEST and make all those drivers
> to depend on the platform they run on, or on the COMPILE_TEST option.
> Now, when users/distributors choose COMPILE_TEST=n they will not have
> the drivers in their allmodconfig setups, but developers still can
> compile-test them with COMPILE_TEST=y.
>
> Now the drivers where we use this new option:
> * PTP_1588_CLOCK_PCH: The PCH EG20T is only compatible with Intel Atom
> processors so it should depend on x86.
> * FB_GEODE: Geode is 32-bit only so only enable it for X86_32.
> * USB_CHIPIDEA_IMX: The OF_DEVICE dependency will be met on powerpc
> systems -- which do not actually support the hardware via that
> method.
I had this exact same idea some time ago. The mail below contains some
of my reasoning for this:
http://comments.gmane.org/gmane.linux.kbuild.devel/9829
I proposed a new Kconfig keyword, but Sam was quite against it as the
Kconfig language already does what is required.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-05-23 7:46 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 9:18 [PATCH] build some drivers only when compile-testing Jiri Slaby
2013-05-23 2:23 ` Greg Kroah-Hartman
2013-05-23 2:23 ` Greg Kroah-Hartman
2013-05-23 3:09 ` Jeff Mahoney
2013-05-23 3:09 ` Jeff Mahoney
2013-05-23 3:09 ` Jeff Mahoney
2013-06-17 20:05 ` Jiri Slaby
2013-06-17 20:05 ` Jiri Slaby
2013-06-18 4:51 ` Michal Marek
2013-06-18 4:51 ` Michal Marek
2013-06-18 8:18 ` Felipe Balbi
2013-06-18 8:18 ` Felipe Balbi
2013-06-18 8:24 ` Jiri Slaby
2013-06-18 8:24 ` Jiri Slaby
2013-06-18 8:34 ` Felipe Balbi
2013-06-18 8:34 ` Felipe Balbi
2013-06-18 8:34 ` Felipe Balbi
2013-06-18 8:44 ` Michal Marek
2013-06-18 8:44 ` Michal Marek
2013-06-18 8:51 ` Felipe Balbi
2013-06-18 8:51 ` Felipe Balbi
2013-06-18 8:51 ` Felipe Balbi
2013-06-18 9:21 ` Jiri Slaby
2013-06-18 9:21 ` Jiri Slaby
2013-06-19 16:38 ` Mark Brown
2013-06-19 16:38 ` Mark Brown
2013-06-18 8:35 ` Tomi Valkeinen
2013-06-18 8:35 ` Tomi Valkeinen
2013-06-18 16:04 ` Greg Kroah-Hartman
2013-06-18 16:04 ` Greg Kroah-Hartman
2013-06-19 6:50 ` Jiri Slaby
2013-06-19 6:50 ` Jiri Slaby
2013-06-19 6:50 ` Jiri Slaby
2013-06-24 23:42 ` Greg Kroah-Hartman
2013-06-24 23:42 ` Greg Kroah-Hartman
2013-06-25 8:16 ` Jiri Slaby
2013-06-25 8:16 ` Jiri Slaby
2013-06-19 7:10 ` Tomi Valkeinen
2013-06-19 7:10 ` Tomi Valkeinen
2013-06-19 7:12 ` Jiri Slaby
2013-06-19 7:12 ` Jiri Slaby
2013-06-19 7:19 ` Tomi Valkeinen
2013-06-19 7:19 ` Tomi Valkeinen
2013-06-19 14:27 ` Greg Kroah-Hartman
2013-06-19 14:27 ` Greg Kroah-Hartman
2013-06-19 14:27 ` Greg Kroah-Hartman
2013-06-21 11:11 ` [PATCH v3] " Jiri Slaby
2013-05-23 14:01 ` [PATCH] " Ben Hutchings
2013-05-23 14:01 ` Ben Hutchings
2013-05-23 14:01 ` Ben Hutchings
2013-05-24 4:50 ` Rob Landley
2013-05-24 4:50 ` Rob Landley
2013-05-23 7:46 ` Tomi Valkeinen [this message]
2013-05-23 7:46 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519DC971.80406@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.e.keller@intel.com \
--cc=jeffm@suse.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.