From: Jiri Slaby <jslaby@suse.cz>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jeff Mahoney <jeffm@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
jirislaby@gmail.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-usb@vger.kernel.org,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] build some drivers only when compile-testing
Date: Wed, 19 Jun 2013 07:12:56 +0000 [thread overview]
Message-ID: <51C159F8.8090604@suse.cz> (raw)
In-Reply-To: <51C1595D.60706@ti.com>
On 06/19/2013 09:10 AM, Tomi Valkeinen wrote:
> On 17/06/13 23:05, Jiri Slaby wrote:
>
>> The last point I inclined to the Greg's argument to remove the
>> EXPERT dependency.
>>
>> So currently I have what is attached... Comments?
>
> The patch looks a bit odd with the USB_CHIPIDEA_IMX parts. You're
> not adding COMPILE_TEST there, but you're adding a totally new
> config option, and also changing the Makefile.
Look:
+config USB_CHIPIDEA_IMX
+ bool "ChipIdea IMX support"
+ depends on OF_DEVICE && (ARM || COMPILE_TEST)
COMPILE_TEST added here ----------------^^^^^^^^^^^^
--
js
suse labs
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jslaby@suse.cz>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jeff Mahoney <jeffm@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
jirislaby@gmail.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-usb@vger.kernel.org,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] build some drivers only when compile-testing
Date: Wed, 19 Jun 2013 09:12:56 +0200 [thread overview]
Message-ID: <51C159F8.8090604@suse.cz> (raw)
In-Reply-To: <51C1595D.60706@ti.com>
On 06/19/2013 09:10 AM, Tomi Valkeinen wrote:
> On 17/06/13 23:05, Jiri Slaby wrote:
>
>> The last point I inclined to the Greg's argument to remove the
>> EXPERT dependency.
>>
>> So currently I have what is attached... Comments?
>
> The patch looks a bit odd with the USB_CHIPIDEA_IMX parts. You're
> not adding COMPILE_TEST there, but you're adding a totally new
> config option, and also changing the Makefile.
Look:
+config USB_CHIPIDEA_IMX
+ bool "ChipIdea IMX support"
+ depends on OF_DEVICE && (ARM || COMPILE_TEST)
COMPILE_TEST added here ----------------^^^^^^^^^^^^
--
js
suse labs
next prev parent reply other threads:[~2013-06-19 7:12 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 9:18 [PATCH] build some drivers only when compile-testing Jiri Slaby
2013-05-23 2:23 ` Greg Kroah-Hartman
2013-05-23 2:23 ` Greg Kroah-Hartman
2013-05-23 3:09 ` Jeff Mahoney
2013-05-23 3:09 ` Jeff Mahoney
2013-05-23 3:09 ` Jeff Mahoney
2013-06-17 20:05 ` Jiri Slaby
2013-06-17 20:05 ` Jiri Slaby
2013-06-18 4:51 ` Michal Marek
2013-06-18 4:51 ` Michal Marek
2013-06-18 8:18 ` Felipe Balbi
2013-06-18 8:18 ` Felipe Balbi
2013-06-18 8:24 ` Jiri Slaby
2013-06-18 8:24 ` Jiri Slaby
2013-06-18 8:34 ` Felipe Balbi
2013-06-18 8:34 ` Felipe Balbi
2013-06-18 8:34 ` Felipe Balbi
2013-06-18 8:44 ` Michal Marek
2013-06-18 8:44 ` Michal Marek
2013-06-18 8:51 ` Felipe Balbi
2013-06-18 8:51 ` Felipe Balbi
2013-06-18 8:51 ` Felipe Balbi
2013-06-18 9:21 ` Jiri Slaby
2013-06-18 9:21 ` Jiri Slaby
2013-06-19 16:38 ` Mark Brown
2013-06-19 16:38 ` Mark Brown
2013-06-18 8:35 ` Tomi Valkeinen
2013-06-18 8:35 ` Tomi Valkeinen
2013-06-18 16:04 ` Greg Kroah-Hartman
2013-06-18 16:04 ` Greg Kroah-Hartman
2013-06-19 6:50 ` Jiri Slaby
2013-06-19 6:50 ` Jiri Slaby
2013-06-19 6:50 ` Jiri Slaby
2013-06-24 23:42 ` Greg Kroah-Hartman
2013-06-24 23:42 ` Greg Kroah-Hartman
2013-06-25 8:16 ` Jiri Slaby
2013-06-25 8:16 ` Jiri Slaby
2013-06-19 7:10 ` Tomi Valkeinen
2013-06-19 7:10 ` Tomi Valkeinen
2013-06-19 7:12 ` Jiri Slaby [this message]
2013-06-19 7:12 ` Jiri Slaby
2013-06-19 7:19 ` Tomi Valkeinen
2013-06-19 7:19 ` Tomi Valkeinen
2013-06-19 14:27 ` Greg Kroah-Hartman
2013-06-19 14:27 ` Greg Kroah-Hartman
2013-06-19 14:27 ` Greg Kroah-Hartman
2013-06-21 11:11 ` [PATCH v3] " Jiri Slaby
2013-05-23 14:01 ` [PATCH] " Ben Hutchings
2013-05-23 14:01 ` Ben Hutchings
2013-05-23 14:01 ` Ben Hutchings
2013-05-24 4:50 ` Rob Landley
2013-05-24 4:50 ` Rob Landley
2013-05-23 7:46 ` Tomi Valkeinen
2013-05-23 7:46 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C159F8.8090604@suse.cz \
--to=jslaby@suse.cz \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.e.keller@intel.com \
--cc=jeffm@suse.com \
--cc=jirislaby@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.