From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3 v3] net/macb: Try to optimize struct macb layout
Date: Tue, 28 May 2013 10:08:40 +0200 [thread overview]
Message-ID: <51A46608.2020906@atmel.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B723A@saturn3.aculab.com>
On 15/05/2013 11:37, David Laight :
>> From: Havard Skinnemoen <havard@skinnemoen.net>
>
>> Move the NAPI struct below that since it is used
>> from the interrupt handler. This field is also marked as
>> ___cacheline_aligned_in_smp.
>
> Is that a good idea if the cache line size is 256 bytes?
> Indeed is that ever sane - except for a few special structures
> that really need it, and are guaranteed to be allocated
> with that much alignment.
I do not know if that was really needed, it was a recommendation by Ben.
(previous email here:
https://patchwork.kernel.org/patch/1887101/
)
Anyway, it seems that this patch needs more work whereas the others of
the series are not commented.
So maybe, I can resend patches 1, 2 for making this big enhancement go
forward (as it is in review process for quite a long time...).
David, do you want me to resend or can you retrieve these v3 patches in
patchwork?
Best regards,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: David Laight <David.Laight@ACULAB.COM>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
<hein_tibosch@yahoo.es>, <s.trumtrar@pengutronix.de>,
<michal.simek@xilinx.com>, <monstr@monstr.eu>,
Havard Skinnemoen <havard@skinnemoen.net>,
Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH 3/3 v3] net/macb: Try to optimize struct macb layout
Date: Tue, 28 May 2013 10:08:40 +0200 [thread overview]
Message-ID: <51A46608.2020906@atmel.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B723A@saturn3.aculab.com>
On 15/05/2013 11:37, David Laight :
>> From: Havard Skinnemoen <havard@skinnemoen.net>
>
>> Move the NAPI struct below that since it is used
>> from the interrupt handler. This field is also marked as
>> ___cacheline_aligned_in_smp.
>
> Is that a good idea if the cache line size is 256 bytes?
> Indeed is that ever sane - except for a few special structures
> that really need it, and are guaranteed to be allocated
> with that much alignment.
I do not know if that was really needed, it was a recommendation by Ben.
(previous email here:
https://patchwork.kernel.org/patch/1887101/
)
Anyway, it seems that this patch needs more work whereas the others of
the series are not commented.
So maybe, I can resend patches 1, 2 for making this big enhancement go
forward (as it is in review process for quite a long time...).
David, do you want me to resend or can you retrieve these v3 patches in
patchwork?
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-05-28 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 9:18 [PATCH 0/3 v3] net/macb: RX path enhancement Nicolas Ferre
2013-05-15 9:18 ` Nicolas Ferre
2013-05-15 9:18 ` [PATCH 1/3 v3] net/macb: increase RX buffer size for GEM Nicolas Ferre
2013-05-15 9:18 ` Nicolas Ferre
2013-05-15 9:18 ` [PATCH 2/3 v3] net/macb: change RX path " Nicolas Ferre
2013-05-15 9:18 ` Nicolas Ferre
2013-05-15 9:18 ` [PATCH 3/3 v3] net/macb: Try to optimize struct macb layout Nicolas Ferre
2013-05-15 9:18 ` Nicolas Ferre
2013-05-15 9:37 ` David Laight
2013-05-15 9:37 ` David Laight
2013-05-28 8:08 ` Nicolas Ferre [this message]
2013-05-28 8:08 ` Nicolas Ferre
2013-05-15 9:38 ` David Laight
2013-05-15 9:38 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A46608.2020906@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.