[GIT PULL] go7007 firmware updates

[GIT PULL] go7007 firmware updates

[Hans Verkuil]

Hi Ben, David,

The go7007 staging driver has been substantially overhauled for kernel 3.10.
As part of that process the firmware situation has been improved as well.

While Micronas allowed the firmware to be redistributed, it was never made
part of linux-firmware. Only the firmwares for the Sensoray S2250 were added
in the past, but those need the go7007*.bin firmwares as well to work.

This pull request collects all the firmwares necessary to support all the
go7007 devices into the go7007 directory. With this change the go7007 driver
will work out-of-the-box starting with kernel 3.10.

Regards,

	Hans

The following changes since commit 07ea598af5b9dde3acdf279846b062fa1b2987b8:

  Merge branch 'linux-firmware' of git://github.com/TI-OpenLink/firmwares (2013-05-06 14:21:49 +0100)

are available in the git repository at:


  git://linuxtv.org/hverkuil/linux-firmware.git go7007

for you to fetch changes up to 88512c918b5f7fd7f41ced07dbc59251c9215c8f:

  Add go7007 firmware. (2013-05-23 10:04:25 +0200)

----------------------------------------------------------------
Hans Verkuil (1):
      Add go7007 firmware.

 LICENCE.go7007                       |  457 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 WHENCE                               |   25 +++-
 go7007/go7007fw.bin                  |  Bin 0 -> 30800 bytes
 go7007/go7007tv.bin                  |  Bin 0 -> 124668 bytes
 go7007/lr192.fw                      |  Bin 0 -> 5793 bytes
 go7007/px-m402u.fw                   |  Bin 0 -> 5838 bytes
 go7007/px-tv402u.fw                  |  Bin 0 -> 6581 bytes
 s2250_loader.fw => go7007/s2250-1.fw |  Bin 1092 -> 1092 bytes
 s2250.fw => go7007/s2250-2.fw        |  Bin 9508 -> 9508 bytes
 go7007/wis-startrek.fw               |  Bin 0 -> 6381 bytes
 10 files changed, 480 insertions(+), 2 deletions(-)
 create mode 100644 LICENCE.go7007
 create mode 100644 go7007/go7007fw.bin
 create mode 100644 go7007/go7007tv.bin
 create mode 100644 go7007/lr192.fw
 create mode 100644 go7007/px-m402u.fw
 create mode 100644 go7007/px-tv402u.fw
 rename s2250_loader.fw => go7007/s2250-1.fw (100%)
 rename s2250.fw => go7007/s2250-2.fw (100%)
 create mode 100644 go7007/wis-startrek.fw

Re: [GIT PULL] go7007 firmware updates

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote:
> Hi Ben, David,
> 
> The go7007 staging driver has been substantially overhauled for kernel 3.10.
> As part of that process the firmware situation has been improved as well.
> 
> While Micronas allowed the firmware to be redistributed, it was never made
> part of linux-firmware. Only the firmwares for the Sensoray S2250 were added
> in the past, but those need the go7007*.bin firmwares as well to work.
> 
> This pull request collects all the firmwares necessary to support all the
> go7007 devices into the go7007 directory. With this change the go7007 driver
> will work out-of-the-box starting with kernel 3.10.
[...]

You should not rename files like this.  linux-firmware is not versioned
and needs to be compatible with old and new kernel versions, so far as
possible.

So the filenames in linux-firmware should match whatever the driver has
used up to now.  If the driver has been changed in 3.10-rc to use
different filenames, it's not too late to revert this mistake in the
driver.  But if such a change was made earlier, we'll need to add
symlinks.

Ben.

-- 
Ben Hutchings
Experience is what causes a person to make new mistakes instead of old ones.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [GIT PULL] go7007 firmware updates

[Hans Verkuil]

On Mon May 27 2013 18:24:32 Ben Hutchings wrote:
> On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote:
> > Hi Ben, David,
> > 
> > The go7007 staging driver has been substantially overhauled for kernel 3.10.
> > As part of that process the firmware situation has been improved as well.
> > 
> > While Micronas allowed the firmware to be redistributed, it was never made
> > part of linux-firmware. Only the firmwares for the Sensoray S2250 were added
> > in the past, but those need the go7007*.bin firmwares as well to work.
> > 
> > This pull request collects all the firmwares necessary to support all the
> > go7007 devices into the go7007 directory. With this change the go7007 driver
> > will work out-of-the-box starting with kernel 3.10.
> [...]
> 
> You should not rename files like this.  linux-firmware is not versioned
> and needs to be compatible with old and new kernel versions, so far as
> possible.

I understand, and I wouldn't have renamed these two firmware files if it
wasn't for the fact that 1) it concerns a staging driver, so in my view
backwards compatibility is not a requirement, and 2) the firmware files
currently in linux-firmware were never enough to make the Sensoray S2250
work, you always needed additional external firmwares as well.

> So the filenames in linux-firmware should match whatever the driver has
> used up to now.  If the driver has been changed in 3.10-rc to use
> different filenames, it's not too late to revert this mistake in the
> driver.  But if such a change was made earlier, we'll need to add
> symlinks.

I can revert the rename action, but I would rather not do it. I believe
there are good reasons for doing this, especially since the current
situation is effectively broken anyway due to the missing firmware files.

If you really don't want to rename the two S2250 files, then I'll make
a patch reverting those to the original filename.

Pete, if you have an opinion regarding this, please let us know. After all,
it concerns a Sensoray device.

Regards,

	Hans

Re: [GIT PULL] go7007 firmware updates

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 2597 bytes --]

On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote:
> On Mon May 27 2013 18:24:32 Ben Hutchings wrote:
> > On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote:
> > > Hi Ben, David,
> > > 
> > > The go7007 staging driver has been substantially overhauled for kernel 3.10.
> > > As part of that process the firmware situation has been improved as well.
> > > 
> > > While Micronas allowed the firmware to be redistributed, it was never made
> > > part of linux-firmware. Only the firmwares for the Sensoray S2250 were added
> > > in the past, but those need the go7007*.bin firmwares as well to work.
> > > 
> > > This pull request collects all the firmwares necessary to support all the
> > > go7007 devices into the go7007 directory. With this change the go7007 driver
> > > will work out-of-the-box starting with kernel 3.10.
> > [...]
> > 
> > You should not rename files like this.  linux-firmware is not versioned
> > and needs to be compatible with old and new kernel versions, so far as
> > possible.
> 
> I understand, and I wouldn't have renamed these two firmware files if it
> wasn't for the fact that 1) it concerns a staging driver, so in my view
> backwards compatibility is not a requirement,

This driver (or set of drivers) has been requesting go7007fw.bin,
go7007tv.bin, s2250.fw and s2250_loader.fw for nearly 5 years.  It's a
bit late to say those were just temporary filenames.

> and 2) the firmware files
> currently in linux-firmware were never enough to make the Sensoray S2250
> work, you always needed additional external firmwares as well.
> 
> > So the filenames in linux-firmware should match whatever the driver has
> > used up to now.  If the driver has been changed in 3.10-rc to use
> > different filenames, it's not too late to revert this mistake in the
> > driver.  But if such a change was made earlier, we'll need to add
> > symlinks.
> 
> I can revert the rename action, but I would rather not do it. I believe
> there are good reasons for doing this, especially since the current
> situation is effectively broken anyway due to the missing firmware files.

Were the 'new' files unavailable to the public, or only available from a
manufacturer web site?

Ben.

> If you really don't want to rename the two S2250 files, then I'll make
> a patch reverting those to the original filename.
> 
> Pete, if you have an opinion regarding this, please let us know. After all,
> it concerns a Sensoray device.

-- 
Ben Hutchings
Experience is what causes a person to make new mistakes instead of old ones.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [GIT PULL] go7007 firmware updates

[Hans Verkuil]

On Mon May 27 2013 23:53:15 Ben Hutchings wrote:
> On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote:
> > On Mon May 27 2013 18:24:32 Ben Hutchings wrote:
> > > On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote:
> > > > Hi Ben, David,
> > > > 
> > > > The go7007 staging driver has been substantially overhauled for kernel 3.10.
> > > > As part of that process the firmware situation has been improved as well.
> > > > 
> > > > While Micronas allowed the firmware to be redistributed, it was never made
> > > > part of linux-firmware. Only the firmwares for the Sensoray S2250 were added
> > > > in the past, but those need the go7007*.bin firmwares as well to work.
> > > > 
> > > > This pull request collects all the firmwares necessary to support all the
> > > > go7007 devices into the go7007 directory. With this change the go7007 driver
> > > > will work out-of-the-box starting with kernel 3.10.
> > > [...]
> > > 
> > > You should not rename files like this.  linux-firmware is not versioned
> > > and needs to be compatible with old and new kernel versions, so far as
> > > possible.
> > 
> > I understand, and I wouldn't have renamed these two firmware files if it
> > wasn't for the fact that 1) it concerns a staging driver, so in my view
> > backwards compatibility is not a requirement,
> 
> This driver (or set of drivers) has been requesting go7007fw.bin,
> go7007tv.bin, s2250.fw and s2250_loader.fw for nearly 5 years.  It's a
> bit late to say those were just temporary filenames.

Why not? It is a staging driver for good reasons. Just because it is in staging
for a long time (because nobody found the time to actually work on it until
3.10) doesn't mean it magically becomes non-staging. The Kconfig in staging
says:

          This option allows you to select a number of drivers that are
          not of the "normal" Linux kernel quality level.  These drivers
          are placed here in order to get a wider audience to make use of
          them.  Please note that these drivers are under heavy
          development, may or may not work, and may contain userspace
          interfaces that most likely will be changed in the near
          future.

In other words, there are no guarantees. That's the whole point of staging.
Once it is moved out of staging everything changes, of course.

Note that it is not just the firmware loading that has changed in 3.10, also
several custom ioctls were removed, thus changing the userspace API, and for
3.11/12 I will add new ioctls to support motion detection. Once that's done
the driver can move out of staging.

> > and 2) the firmware files
> > currently in linux-firmware were never enough to make the Sensoray S2250
> > work, you always needed additional external firmwares as well.
> > 
> > > So the filenames in linux-firmware should match whatever the driver has
> > > used up to now.  If the driver has been changed in 3.10-rc to use
> > > different filenames, it's not too late to revert this mistake in the
> > > driver.  But if such a change was made earlier, we'll need to add
> > > symlinks.
> > 
> > I can revert the rename action, but I would rather not do it. I believe
> > there are good reasons for doing this, especially since the current
> > situation is effectively broken anyway due to the missing firmware files.
> 
> Were the 'new' files unavailable to the public, or only available from a
> manufacturer web site?

They have been available from various websites where people hosted their own
version of the out-of-tree driver from before the driver was moved to staging.
They originated from the manufacturer, which no longer exists. To my knowledge
there isn't any 'canonical' site containing the firmwares.

Loading the firmware was actually quite complex for some go7007 devices,
requiring a userspace utility and special udev rules. That's all changed in
3.10.

Also note that some of the firmware files on those websites were in a hex
format. Starting with 3.10 these files are converted to a smaller binary
format and now use a standard cypress loader kernel module instead of requiring
in-kernel hex parsing.

Regards,

	Hans

> 
> Ben.
> 
> > If you really don't want to rename the two S2250 files, then I'll make
> > a patch reverting those to the original filename.
> > 
> > Pete, if you have an opinion regarding this, please let us know. After all,
> > it concerns a Sensoray device.
> 
> 

Re: [GIT PULL] go7007 firmware updates

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 3023 bytes --]

On Tue, 2013-05-28 at 08:42 +0200, Hans Verkuil wrote:
> On Mon May 27 2013 23:53:15 Ben Hutchings wrote:
> > On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote:
> > > On Mon May 27 2013 18:24:32 Ben Hutchings wrote:
> > > > On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote:
> > > > > Hi Ben, David,
> > > > > 
> > > > > The go7007 staging driver has been substantially overhauled for kernel 3.10.
> > > > > As part of that process the firmware situation has been improved as well.
> > > > > 
> > > > > While Micronas allowed the firmware to be redistributed, it was never made
> > > > > part of linux-firmware. Only the firmwares for the Sensoray S2250 were added
> > > > > in the past, but those need the go7007*.bin firmwares as well to work.
> > > > > 
> > > > > This pull request collects all the firmwares necessary to support all the
> > > > > go7007 devices into the go7007 directory. With this change the go7007 driver
> > > > > will work out-of-the-box starting with kernel 3.10.
> > > > [...]
> > > > 
> > > > You should not rename files like this.  linux-firmware is not versioned
> > > > and needs to be compatible with old and new kernel versions, so far as
> > > > possible.
> > > 
> > > I understand, and I wouldn't have renamed these two firmware files if it
> > > wasn't for the fact that 1) it concerns a staging driver, so in my view
> > > backwards compatibility is not a requirement,
> > 
> > This driver (or set of drivers) has been requesting go7007fw.bin,
> > go7007tv.bin, s2250.fw and s2250_loader.fw for nearly 5 years.  It's a
> > bit late to say those were just temporary filenames.
> 
> Why not? It is a staging driver for good reasons. Just because it is in staging
> for a long time (because nobody found the time to actually work on it until
> 3.10) doesn't mean it magically becomes non-staging. The Kconfig in staging
> says:
> 
>           This option allows you to select a number of drivers that are
>           not of the "normal" Linux kernel quality level.  These drivers
>           are placed here in order to get a wider audience to make use of
>           them.  Please note that these drivers are under heavy
>           development, may or may not work, and may contain userspace
>           interfaces that most likely will be changed in the near
>           future.
> 
> In other words, there are no guarantees. That's the whole point of staging.
[...]

But the reality is that many drivers don't get that heavy development,
and so they linger in staging for a long time.  So it shouldn't be
surprising that users start to rely on them, and distributions ship
them, and then it's a bit rough to pull the rug from under them some
years later.

I don't know how true that is of go7007 but I'd like to avoid causing
regressions.  So I've pulled from you, but I've then added back s2250.fw
and s2250_loader.fw as symlinks.

Ben.

-- 
Ben Hutchings
If at first you don't succeed, you're doing about average.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [GIT PULL] go7007 firmware updates

[Pete Eberlein]

Hi Hans,

On 05/27/2013 12:56 PM, Hans Verkuil wrote:
> I can revert the rename action,  but I would rather not do it. I
 > believe there are good reasons for doing this, especially since the
 > current situation is effectively broken anyway due to the missing
 > firmware files.
 >
 > If you really don't want to rename the two S2250 files, then I'll
 > make a patch reverting those to the original filename.
 >
 > Pete, if you have an opinion regarding this, please let us know.
 > After all, it concerns a Sensoray device.

I am okay with the change of the firmware filenames.  I've changed them 
myself several times in the past before it got into kernel staging.

> Regards,
 >
 > Hans
 >

Regards,
Pete