* [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()
@ 2013-05-26 7:51 Chen Gang
2013-05-28 12:29 ` John Crispin
0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2013-05-26 7:51 UTC (permalink / raw)
To: ralf, blogic; +Cc: linux-mips, Linux-Arch
'compatible' is used by strlen() in __of_device_is_compatible().
So for NUL terminated string, need always be sure of ended by zero.
'of_ids' is not a structure in "include/uapi/*", so not need initialize
all bytes, just use strlcpy() instead of strncpy().
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/mips/lantiq/prom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/lantiq/prom.c b/arch/mips/lantiq/prom.c
index 9f9e875..49c4603 100644
--- a/arch/mips/lantiq/prom.c
+++ b/arch/mips/lantiq/prom.c
@@ -112,7 +112,7 @@ int __init plat_of_setup(void)
if (!of_have_populated_dt())
panic("device tree not present");
- strncpy(of_ids[0].compatible, soc_info.compatible,
+ strlcpy(of_ids[0].compatible, soc_info.compatible,
sizeof(of_ids[0].compatible));
strncpy(of_ids[1].compatible, "simple-bus",
sizeof(of_ids[1].compatible));
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()
2013-05-26 7:51 [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy() Chen Gang
@ 2013-05-28 12:29 ` John Crispin
2013-05-29 1:29 ` Chen Gang
0 siblings, 1 reply; 3+ messages in thread
From: John Crispin @ 2013-05-28 12:29 UTC (permalink / raw)
To: Chen Gang; +Cc: linux-mips
On 26/05/13 09:51, Chen Gang wrote:
> 'compatible' is used by strlen() in __of_device_is_compatible().
>
> So for NUL terminated string, need always be sure of ended by zero.
>
> 'of_ids' is not a structure in "include/uapi/*", so not need initialize
> all bytes, just use strlcpy() instead of strncpy().
>
>
> Signed-off-by: Chen Gang<gang.chen@asianux.com>
Acked-by: John Crispin <blogic@openwrt.org>
> ---
> arch/mips/lantiq/prom.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/lantiq/prom.c b/arch/mips/lantiq/prom.c
> index 9f9e875..49c4603 100644
> --- a/arch/mips/lantiq/prom.c
> +++ b/arch/mips/lantiq/prom.c
> @@ -112,7 +112,7 @@ int __init plat_of_setup(void)
> if (!of_have_populated_dt())
> panic("device tree not present");
>
> - strncpy(of_ids[0].compatible, soc_info.compatible,
> + strlcpy(of_ids[0].compatible, soc_info.compatible,
> sizeof(of_ids[0].compatible));
> strncpy(of_ids[1].compatible, "simple-bus",
> sizeof(of_ids[1].compatible));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()
2013-05-28 12:29 ` John Crispin
@ 2013-05-29 1:29 ` Chen Gang
0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2013-05-29 1:29 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mips
On 05/28/2013 08:29 PM, John Crispin wrote:
> On 26/05/13 09:51, Chen Gang wrote:
>> 'compatible' is used by strlen() in __of_device_is_compatible().
>>
>> So for NUL terminated string, need always be sure of ended by zero.
>>
>> 'of_ids' is not a structure in "include/uapi/*", so not need initialize
>> all bytes, just use strlcpy() instead of strncpy().
>>
>>
>> Signed-off-by: Chen Gang<gang.chen@asianux.com>
>
> Acked-by: John Crispin <blogic@openwrt.org>
Thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-29 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-26 7:51 [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy() Chen Gang
2013-05-28 12:29 ` John Crispin
2013-05-29 1:29 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.