From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] at_hdmac: add FIFO configuration parameter to DMA DT binding
Date: Fri, 31 May 2013 11:31:33 +0200 [thread overview]
Message-ID: <51A86DF5.4010808@atmel.com> (raw)
In-Reply-To: <20130531091627.GD11384@ludovic.desroches@atmel.com>
On 31/05/2013 11:16, Ludovic Desroches :
> On Thu, May 30, 2013 at 06:39:36PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 18:32 Thu 30 May , Nicolas Ferre wrote:
>>> On 30/05/2013 18:08, ludovic.desroches at atmel.com :
>>>> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>>>>
>>>> For most devices the FIFO configuration is the same i.e. when half FIFO size is
>>>> available/filled, a source/destination request is serviced. But USART devices
>>>> have to do it when there is enough space/data available to perform a single
>>>> AHB access so the ASAP configuration.
>>>>
>>>> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>>>
>>> Clear and neat: thanks Ludo.
>>
>> agreed
>>
>> can we apply this via AT91 as this depends on some cleanup I did on DT and
>> could result on some nigthmware conflict
>>
>
> In fact, I am not sure it's the best solution. I have noticed that there is a
> conflict with a patch sent by Nicolas (dmaengine: at_hdmac: extend hardware
> handshaking interface identification) which is already in Vinod's tree but
> which is not present on Jean-Christophe's cleanup tree on which I based these
> patches.
>
> Moreover this patch doesn't use macros introduced by Nicolas' patch. I may
> update it and it should go through Vinod's tree with a dependence on patch 1/3.
>
> What's your point of view?
Indeed. Another option could be to push patches 1 and 3 in dmaengine's
tree and make the 2nd patch go through arm-soc with a dependency on
slave-dma GIT tree (it seems it is an usual patern).
Arnd, Jean-Christophe, what do you think?
Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Ludovic Desroches
<ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] at_hdmac: add FIFO configuration parameter to DMA DT binding
Date: Fri, 31 May 2013 11:31:33 +0200 [thread overview]
Message-ID: <51A86DF5.4010808@atmel.com> (raw)
In-Reply-To: <20130531091627.GD11384-tOglhBvtKaELqBSMlTbpHvU/3Eu2kcEP@public.gmane.org@atmel.com>
On 31/05/2013 11:16, Ludovic Desroches :
> On Thu, May 30, 2013 at 06:39:36PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 18:32 Thu 30 May , Nicolas Ferre wrote:
>>> On 30/05/2013 18:08, ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org :
>>>> From: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>>>>
>>>> For most devices the FIFO configuration is the same i.e. when half FIFO size is
>>>> available/filled, a source/destination request is serviced. But USART devices
>>>> have to do it when there is enough space/data available to perform a single
>>>> AHB access so the ASAP configuration.
>>>>
>>>> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
>>>> Signed-off-by: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>>>
>>> Clear and neat: thanks Ludo.
>>
>> agreed
>>
>> can we apply this via AT91 as this depends on some cleanup I did on DT and
>> could result on some nigthmware conflict
>>
>
> In fact, I am not sure it's the best solution. I have noticed that there is a
> conflict with a patch sent by Nicolas (dmaengine: at_hdmac: extend hardware
> handshaking interface identification) which is already in Vinod's tree but
> which is not present on Jean-Christophe's cleanup tree on which I based these
> patches.
>
> Moreover this patch doesn't use macros introduced by Nicolas' patch. I may
> update it and it should go through Vinod's tree with a dependence on patch 1/3.
>
> What's your point of view?
Indeed. Another option could be to push patches 1 and 3 in dmaengine's
tree and make the 2nd patch go through arm-soc with a dependency on
slave-dma GIT tree (it seems it is an usual patern).
Arnd, Jean-Christophe, what do you think?
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-05-31 9:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 16:08 [PATCH 0/3] at_hdmac: dt dma bindings update ludovic.desroches at atmel.com
2013-05-30 16:08 ` ludovic.desroches
2013-05-30 16:08 ` [PATCH 1/3] ARM: at91: dt: add header to define at_hdmac configuration ludovic.desroches at atmel.com
2013-05-30 16:08 ` ludovic.desroches
2013-05-31 21:30 ` Arnd Bergmann
2013-05-31 21:30 ` Arnd Bergmann
2013-06-03 7:32 ` Ludovic Desroches
2013-06-04 13:17 ` Nicolas Ferre
2013-06-04 13:17 ` Nicolas Ferre
2013-06-03 7:32 ` Ludovic Desroches
[not found] ` <201305312330.29364.arnd-r2nGTMty4D4@public.gmane.org>
2013-06-03 7:32 ` Ludovic Desroches
2013-05-30 16:08 ` [PATCH 2/3] ARM: at91: dt: switch DMA DT bindings to pre-processor ludovic.desroches at atmel.com
2013-05-30 16:08 ` ludovic.desroches
2013-05-30 16:08 ` [PATCH 3/3] at_hdmac: add FIFO configuration parameter to DMA DT binding ludovic.desroches at atmel.com
2013-05-30 16:08 ` ludovic.desroches
2013-05-30 16:32 ` Nicolas Ferre
2013-05-30 16:32 ` Nicolas Ferre
2013-05-30 16:39 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 16:39 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20130530163936.GC23653-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2013-05-31 9:16 ` Ludovic Desroches
2013-05-31 9:16 ` Ludovic Desroches
2013-05-31 9:31 ` Nicolas Ferre [this message]
2013-05-31 9:31 ` Nicolas Ferre
2013-05-31 15:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31 15:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31 23:11 ` Olof Johansson
2013-05-31 23:11 ` Olof Johansson
2013-06-03 7:39 ` Ludovic Desroches
[not found] ` <CAOesGMhQetZfyzMpCax63xoRqtRW2ZRXt04MCbgCT-CcvUq43A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-03 7:39 ` Ludovic Desroches
2013-06-03 7:39 ` Ludovic Desroches
2013-05-31 9:16 ` Ludovic Desroches
2013-05-30 16:37 ` [PATCH 0/3] at_hdmac: dt dma bindings update Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 16:37 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 17:26 ` Vinod Koul
2013-05-30 17:26 ` Vinod Koul
2013-05-30 20:13 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 20:13 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-31 8:04 ` Nicolas Ferre
2013-05-31 8:04 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A86DF5.4010808@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.