* [PATCH] Revert "irq: Add extra debugging to help track down why an assertion is failing"
@ 2013-06-05 9:13 Jan Beulich
2013-06-05 9:19 ` Andrew Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2013-06-05 9:13 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Keir Fraser
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
This reverts commits 2ae8b9173fb2388af6514c730d620ed5f450bc34 and
98e10364bde098e12104caa4f566b17d05f8b791.
This was never reported to be hit, and we assume to have taken care of
the problem by excluding legacy IRQs from the IRQ move cleanup logic.
Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -624,8 +624,6 @@ void move_native_irq(struct irq_desc *de
desc->handler->enable(desc);
}
-static void dump_irqs(unsigned char key);
-
void irq_move_cleanup_interrupt(struct cpu_user_regs *regs)
{
unsigned vector, me;
@@ -687,19 +685,7 @@ void irq_move_cleanup_interrupt(struct c
if ( desc->arch.used_vectors )
{
- if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
- {
- spin_unlock(&desc->lock);
- bitmap_scnlistprintf(keyhandler_scratch,
- sizeof(keyhandler_scratch),
- desc->arch.used_vectors->_bits,
- NR_VECTORS);
- printk("*** IRQ BUG found ***\n"
- "CPU%d -Testing vector %d from bitmap %s\n",
- me, vector, keyhandler_scratch);
- dump_irqs('i');
- BUG();
- }
+ ASSERT(test_bit(vector, desc->arch.used_vectors));
clear_bit(vector, desc->arch.used_vectors);
}
}
[-- Attachment #2: x86-revert-irq-debugging.patch --]
[-- Type: text/plain, Size: 1719 bytes --]
Revert "irq: Add extra debugging to help track down why an assertion is failing"
This reverts commits 2ae8b9173fb2388af6514c730d620ed5f450bc34 and
98e10364bde098e12104caa4f566b17d05f8b791.
This was never reported to be hit, and we assume to have taken care of
the problem by excluding legacy IRQs from the IRQ move cleanup logic.
Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -624,8 +624,6 @@ void move_native_irq(struct irq_desc *de
desc->handler->enable(desc);
}
-static void dump_irqs(unsigned char key);
-
void irq_move_cleanup_interrupt(struct cpu_user_regs *regs)
{
unsigned vector, me;
@@ -687,19 +685,7 @@ void irq_move_cleanup_interrupt(struct c
if ( desc->arch.used_vectors )
{
- if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
- {
- spin_unlock(&desc->lock);
- bitmap_scnlistprintf(keyhandler_scratch,
- sizeof(keyhandler_scratch),
- desc->arch.used_vectors->_bits,
- NR_VECTORS);
- printk("*** IRQ BUG found ***\n"
- "CPU%d -Testing vector %d from bitmap %s\n",
- me, vector, keyhandler_scratch);
- dump_irqs('i');
- BUG();
- }
+ ASSERT(test_bit(vector, desc->arch.used_vectors));
clear_bit(vector, desc->arch.used_vectors);
}
}
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Revert "irq: Add extra debugging to help track down why an assertion is failing"
2013-06-05 9:13 [PATCH] Revert "irq: Add extra debugging to help track down why an assertion is failing" Jan Beulich
@ 2013-06-05 9:19 ` Andrew Cooper
2013-06-05 10:37 ` George Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2013-06-05 9:19 UTC (permalink / raw)
To: Jan Beulich; +Cc: Keir (Xen.org), xen-devel
On 05/06/13 10:13, Jan Beulich wrote:
> This reverts commits 2ae8b9173fb2388af6514c730d620ed5f450bc34 and
> 98e10364bde098e12104caa4f566b17d05f8b791.
>
> This was never reported to be hit, and we assume to have taken care of
> the problem by excluding legacy IRQs from the IRQ move cleanup logic.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -624,8 +624,6 @@ void move_native_irq(struct irq_desc *de
> desc->handler->enable(desc);
> }
>
> -static void dump_irqs(unsigned char key);
> -
> void irq_move_cleanup_interrupt(struct cpu_user_regs *regs)
> {
> unsigned vector, me;
> @@ -687,19 +685,7 @@ void irq_move_cleanup_interrupt(struct c
>
> if ( desc->arch.used_vectors )
> {
> - if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
> - {
> - spin_unlock(&desc->lock);
> - bitmap_scnlistprintf(keyhandler_scratch,
> - sizeof(keyhandler_scratch),
> - desc->arch.used_vectors->_bits,
> - NR_VECTORS);
> - printk("*** IRQ BUG found ***\n"
> - "CPU%d -Testing vector %d from bitmap %s\n",
> - me, vector, keyhandler_scratch);
> - dump_irqs('i');
> - BUG();
> - }
> + ASSERT(test_bit(vector, desc->arch.used_vectors));
> clear_bit(vector, desc->arch.used_vectors);
> }
> }
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Revert "irq: Add extra debugging to help track down why an assertion is failing"
2013-06-05 9:19 ` Andrew Cooper
@ 2013-06-05 10:37 ` George Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: George Dunlap @ 2013-06-05 10:37 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Keir (Xen.org), Jan Beulich, xen-devel
On Wed, Jun 5, 2013 at 10:19 AM, Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
> On 05/06/13 10:13, Jan Beulich wrote:
>> This reverts commits 2ae8b9173fb2388af6514c730d620ed5f450bc34 and
>> 98e10364bde098e12104caa4f566b17d05f8b791.
>>
>> This was never reported to be hit, and we assume to have taken care of
>> the problem by excluding legacy IRQs from the IRQ move cleanup logic.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-wise:
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-05 10:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-05 9:13 [PATCH] Revert "irq: Add extra debugging to help track down why an assertion is failing" Jan Beulich
2013-06-05 9:19 ` Andrew Cooper
2013-06-05 10:37 ` George Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.