Re: [PATCH v2 5/5] ARM: davinci: serial: platform code cleanup

[Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>]

On 6/5/2013 5:11 PM, Sekhar Nori wrote:
> 
> On 5/28/2013 1:58 PM, Manjunathappa, Prakash wrote:
>> 1) "struct davinci_uart_config" is introduced to specify
>>    UART ports brought out or enabled on the board. But
>>    none of the boards use them for that purpose, so clean
>>    it up.
>> 2) Have pointer to platform device as a argument for
>>    davinci_serial_init(), no need of serial_dev in
>>    struct soc_info now.
>> 3) No need of davinci_serial_setup_clk(), not called from
>>    multiple places, hence reduce function call overhead.
>>
>> Signed-off-by: Manjunathappa, Prakash <prakash.pm-l0cyMroinI0@public.gmane.org>
>> Suggested-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> 
> We generally clean up code before undertaking modifications. Is there a
> reason why this cannot be done first-up?

Never mind this question. I figured it out myself. You need to have the
serial clock setup removed from DT before you can do any reasonable
clean-up and that happens only with 4/5.

Thanks,
Sekhar