From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
rjw@sisk.pl, patches@linaro.org, linaro-kernel@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
Colin Cross <ccross@android.com>
Subject: Re: [PATCH] cpuidle: fix ARCH_NEEDS_CPU_IDLE_COUPLED dependency warning
Date: Fri, 7 Jun 2013 19:21:35 -0400 [thread overview]
Message-ID: <51B26AFF.9080908@ti.com> (raw)
In-Reply-To: <201306072121.58719.arnd@arndb.de>
On Friday 07 June 2013 03:21 PM, Arnd Bergmann wrote:
> On Friday 07 June 2013, Santosh Shilimkar wrote:
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index f49cd51..831e89e 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -83,7 +83,7 @@ config ARCH_OMAP4
>>> depends on ARCH_OMAP2PLUS
>>> depends on ARCH_MULTI_V7
>>> select ARCH_HAS_OPP
>>> - select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
>>> + select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
>>
>> I remember Colin mentioning about above dependency is taken care
>> already in design [1]
>
> It's a matter of how it gets represented in Kconfig. Right now
> the ARCH_NEEDS_CPU_IDLE_COUPLED symbol has a dependency on CPU_IDLE,
> so we cannot select it if CPU_IDLE is not set (or get a build time
> warning).
>
> I originally suggested removing the dependency, but Daniel preferred
> to leave it there as an explicit dependency so it is required to
> do this change instead.
>
I see. Thanks for clarifying.
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpuidle: fix ARCH_NEEDS_CPU_IDLE_COUPLED dependency warning
Date: Fri, 7 Jun 2013 19:21:35 -0400 [thread overview]
Message-ID: <51B26AFF.9080908@ti.com> (raw)
In-Reply-To: <201306072121.58719.arnd@arndb.de>
On Friday 07 June 2013 03:21 PM, Arnd Bergmann wrote:
> On Friday 07 June 2013, Santosh Shilimkar wrote:
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index f49cd51..831e89e 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -83,7 +83,7 @@ config ARCH_OMAP4
>>> depends on ARCH_OMAP2PLUS
>>> depends on ARCH_MULTI_V7
>>> select ARCH_HAS_OPP
>>> - select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
>>> + select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE)
>>
>> I remember Colin mentioning about above dependency is taken care
>> already in design [1]
>
> It's a matter of how it gets represented in Kconfig. Right now
> the ARCH_NEEDS_CPU_IDLE_COUPLED symbol has a dependency on CPU_IDLE,
> so we cannot select it if CPU_IDLE is not set (or get a build time
> warning).
>
> I originally suggested removing the dependency, but Daniel preferred
> to leave it there as an explicit dependency so it is required to
> do this change instead.
>
I see. Thanks for clarifying.
Regards,
Santosh
next prev parent reply other threads:[~2013-06-07 23:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 17:40 [PATCH] cpuidle: fix ARCH_NEEDS_CPU_IDLE_COUPLED dependency warning Daniel Lezcano
2013-06-07 17:40 ` Daniel Lezcano
2013-06-07 17:50 ` Santosh Shilimkar
2013-06-07 17:50 ` Santosh Shilimkar
2013-06-07 19:21 ` Arnd Bergmann
2013-06-07 19:21 ` Arnd Bergmann
2013-06-07 23:21 ` Santosh Shilimkar [this message]
2013-06-07 23:21 ` Santosh Shilimkar
2013-06-10 0:38 ` Colin Cross
2013-06-10 0:38 ` Colin Cross
2013-06-10 9:29 ` Daniel Lezcano
2013-06-10 9:29 ` Daniel Lezcano
2013-06-07 19:22 ` Arnd Bergmann
2013-06-07 19:22 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2013-06-11 8:09 [PATCH] cpuidle: Fix " Daniel Lezcano
2013-06-11 8:09 ` Daniel Lezcano
2013-06-11 22:42 ` Rafael J. Wysocki
2013-06-11 22:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B26AFF.9080908@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.