From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH 6/6] mtd: ofpart: add compatible check for child nodes
Date: Thu, 13 Jun 2013 17:13:43 +0400 [thread overview]
Message-ID: <51B9C587.4020307@cogentembedded.com> (raw)
In-Reply-To: <51B93FA2.7040206@atmel.com>
Hello.
On 13-06-2013 7:42, Josh Wu wrote:
>>> If the child node has compatible property then it is a driver not
>>> partition.
>>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>>> ---
>>> drivers/mtd/ofpart.c | 14 +++++++++++++-
>>> 1 file changed, 13 insertions(+), 1 deletion(-)
>>> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
>>> index 553d6d6..61ce1f8 100644
>>> --- a/drivers/mtd/ofpart.c
>>> +++ b/drivers/mtd/ofpart.c
>> [...]
>>> @@ -40,8 +44,13 @@ static int parse_ofpart_partitions(struct mtd_info
>>> *master,
>>> /* First count the subnodes */
>>> pp = NULL;
>>> nr_parts = 0;
>>> - while ((pp = of_get_next_child(node, pp)))
>>> + while ((pp = of_get_next_child(node, pp))) {
>> Assignment in *while*? Is scripts/checkpatch.pl happy about that?
> yes, checkpatch.pl has no complain ;-)
It seems checkpatch.pl only complains about *if*. Not very consistent...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] mtd: ofpart: add compatible check for child nodes
Date: Thu, 13 Jun 2013 17:13:43 +0400 [thread overview]
Message-ID: <51B9C587.4020307@cogentembedded.com> (raw)
In-Reply-To: <51B93FA2.7040206@atmel.com>
Hello.
On 13-06-2013 7:42, Josh Wu wrote:
>>> If the child node has compatible property then it is a driver not
>>> partition.
>>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>>> ---
>>> drivers/mtd/ofpart.c | 14 +++++++++++++-
>>> 1 file changed, 13 insertions(+), 1 deletion(-)
>>> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
>>> index 553d6d6..61ce1f8 100644
>>> --- a/drivers/mtd/ofpart.c
>>> +++ b/drivers/mtd/ofpart.c
>> [...]
>>> @@ -40,8 +44,13 @@ static int parse_ofpart_partitions(struct mtd_info
>>> *master,
>>> /* First count the subnodes */
>>> pp = NULL;
>>> nr_parts = 0;
>>> - while ((pp = of_get_next_child(node, pp)))
>>> + while ((pp = of_get_next_child(node, pp))) {
>> Assignment in *while*? Is scripts/checkpatch.pl happy about that?
> yes, checkpatch.pl has no complain ;-)
It seems checkpatch.pl only complains about *if*. Not very consistent...
WBR, Sergei
next prev parent reply other threads:[~2013-06-13 13:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 10:26 [PATCH v3 0/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-06-10 10:26 ` Josh Wu
2013-06-10 10:26 ` [PATCH 1/6] MTD: atmel_nand: use devm_xxx gpio kzalloc, gpio and ioremap Josh Wu
2013-06-10 10:26 ` Josh Wu
2013-06-10 10:26 ` [PATCH 2/6] mtd: atmel_nand: replace pmecc enable code with one function Josh Wu
2013-06-10 10:26 ` Josh Wu
2013-06-12 11:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-12 11:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-10 10:26 ` [PATCH 3/6] mtd: atmel_nand: add Nand Flash Controller (NFC) support Josh Wu
2013-06-10 10:26 ` Josh Wu
2013-06-10 13:22 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-10 13:22 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-13 1:59 ` Josh Wu
2013-06-13 1:59 ` Josh Wu
2013-06-10 10:26 ` [PATCH 4/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) read data via sram Josh Wu
2013-06-10 10:26 ` Josh Wu
2013-06-12 11:58 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-12 11:58 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-10 10:26 ` [PATCH 5/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) write " Josh Wu
2013-06-10 10:26 ` Josh Wu
2013-06-12 11:58 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-12 11:58 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-10 10:26 ` [PATCH 6/6] mtd: ofpart: add compatible check for child nodes Josh Wu
2013-06-10 10:26 ` Josh Wu
2013-06-10 12:35 ` Sergei Shtylyov
2013-06-10 12:35 ` Sergei Shtylyov
2013-06-13 3:42 ` Josh Wu
2013-06-13 3:42 ` Josh Wu
2013-06-13 13:13 ` Sergei Shtylyov [this message]
2013-06-13 13:13 ` Sergei Shtylyov
2013-06-11 23:34 ` Brian Norris
2013-06-11 23:34 ` Brian Norris
2013-06-13 3:38 ` Josh Wu
2013-06-13 3:38 ` Josh Wu
-- strict thread matches above, loose matches on Subject: below --
2013-06-19 6:23 [PATCH v4 0/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-06-19 6:23 ` [PATCH 6/6] mtd: ofpart: add compatible check for child nodes Josh Wu
2013-06-19 6:23 ` Josh Wu
2013-07-03 9:50 [PATCH v5 0/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-07-03 9:50 ` [PATCH 6/6] mtd: ofpart: add compatible check for child nodes Josh Wu
2013-07-03 9:50 ` Josh Wu
2013-07-18 7:14 ` Brian Norris
2013-07-18 7:14 ` Brian Norris
2013-07-18 7:14 ` Brian Norris
2013-07-18 8:28 ` Jean-Christophe PLAGNIOL-VILLARD
2013-07-18 8:28 ` Jean-Christophe PLAGNIOL-VILLARD
2013-07-18 8:28 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-05 11:14 [PATCH v6 0/6] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Josh Wu
2013-08-05 11:14 ` [PATCH 6/6] mtd: ofpart: add compatible check for child nodes Josh Wu
2013-08-05 11:14 ` Josh Wu
2013-08-05 11:33 ` Josh Wu
2013-08-05 11:33 ` Josh Wu
2013-08-05 11:33 ` Josh Wu
2013-08-05 18:56 ` Brian Norris
2013-08-05 18:56 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B9C587.4020307@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dedekind1@gmail.com \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.