Re: [PATCH 6/6] mtd: ofpart: add compatible check for child nodes

[Josh Wu <josh.wu@atmel.com>]

Hi, Sergei

On 6/10/2013 8:35 PM, Sergei Shtylyov wrote:
> hello.
>
> On 10-06-2013 14:26, Josh Wu wrote:
>
>> If the child node has compatible property then it is a driver not 
>> partition.
>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>> ---
>>   drivers/mtd/ofpart.c |   14 +++++++++++++-
>>   1 file changed, 13 insertions(+), 1 deletion(-)
>
>
>> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
>> index 553d6d6..61ce1f8 100644
>> --- a/drivers/mtd/ofpart.c
>> +++ b/drivers/mtd/ofpart.c
> [...]
>> @@ -40,8 +44,13 @@ static int parse_ofpart_partitions(struct mtd_info 
>> *master,
>>       /* First count the subnodes */
>>       pp = NULL;
>>       nr_parts = 0;
>> -    while ((pp = of_get_next_child(node, pp)))
>> +    while ((pp = of_get_next_child(node, pp))) {
>
>    Assignment in *while*? Is scripts/checkpatch.pl happy about that?

yes, checkpatch.pl has no complain  ;-)

>
>> +        int len;
>
>    Empty line wouldn't hurt here, after declaration.

Ok, as Brian said, I will no need to use a 'int len' here. So I will 
remove those declaration.

>
>> +        if (node_has_compatible(pp, &len))
>> +            continue;
>> +
>>           nr_parts++;
>> +    }
>>
>>       if (nr_parts == 0)
>>           return 0;
>
> WBR, Sergei
>

Thanks.
Best Regards,
Josh Wu