Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled

[David Daney <ddaney.cavm@gmail.com>]

On 06/13/2013 08:42 AM, Markos Chandras wrote:
> Commit 94d83649e1c2f25c87dc4ead9c2ab073305
> "USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol"
>
> caused the following regression in cavium_octeon_defconfig:
>
> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects
> USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies
> (USB_SUPPORT && USB && USB_EHCI_HCD)
>
> We fix this problem by selecting the USB_EHCI_HCD missing dependency
> if USB_SUPPORT is enabled.
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>

NAK.  This is incorrect.

It is completely backwards and forces us to have EHCI unconditionally.

The proper fix is to move USB_EHCI_BIG_ENDIAN_MMIO (and similar other 
Kconifg variables) out of the conditional section and make them 
universally visible/usable.

David Daney


> ---
> This patch is for the upstream-sfr/mips-for-linux-next
> ---
>   arch/mips/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 87ddac9..a058ba8 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1411,6 +1411,7 @@ config CPU_CAVIUM_OCTEON
>   	select CPU_SUPPORTS_HUGEPAGES
>   	select LIBFDT
>   	select USE_OF
> +	select USB_EHCI_HCD if USB_SUPPORT
>   	select USB_EHCI_BIG_ENDIAN_MMIO
>   	help
>   	  The Cavium Octeon processor is a highly integrated chip containing
>