* [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled
@ 2013-06-13 15:42 ` Markos Chandras
0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-06-13 15:42 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras
Commit 94d83649e1c2f25c87dc4ead9c2ab073305
"USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol"
caused the following regression in cavium_octeon_defconfig:
warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects
USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies
(USB_SUPPORT && USB && USB_EHCI_HCD)
We fix this problem by selecting the USB_EHCI_HCD missing dependency
if USB_SUPPORT is enabled.
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
This patch is for the upstream-sfr/mips-for-linux-next
---
arch/mips/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 87ddac9..a058ba8 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1411,6 +1411,7 @@ config CPU_CAVIUM_OCTEON
select CPU_SUPPORTS_HUGEPAGES
select LIBFDT
select USE_OF
+ select USB_EHCI_HCD if USB_SUPPORT
select USB_EHCI_BIG_ENDIAN_MMIO
help
The Cavium Octeon processor is a highly integrated chip containing
--
1.8.2.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled
@ 2013-06-13 15:42 ` Markos Chandras
0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-06-13 15:42 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras
Commit 94d83649e1c2f25c87dc4ead9c2ab073305
"USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol"
caused the following regression in cavium_octeon_defconfig:
warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects
USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies
(USB_SUPPORT && USB && USB_EHCI_HCD)
We fix this problem by selecting the USB_EHCI_HCD missing dependency
if USB_SUPPORT is enabled.
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
This patch is for the upstream-sfr/mips-for-linux-next
---
arch/mips/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 87ddac9..a058ba8 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1411,6 +1411,7 @@ config CPU_CAVIUM_OCTEON
select CPU_SUPPORTS_HUGEPAGES
select LIBFDT
select USE_OF
+ select USB_EHCI_HCD if USB_SUPPORT
select USB_EHCI_BIG_ENDIAN_MMIO
help
The Cavium Octeon processor is a highly integrated chip containing
--
1.8.2.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled
2013-06-13 15:42 ` Markos Chandras
(?)
@ 2013-06-13 16:41 ` David Daney
2013-06-14 8:26 ` Markos Chandras
-1 siblings, 1 reply; 5+ messages in thread
From: David Daney @ 2013-06-13 16:41 UTC (permalink / raw)
To: Markos Chandras, USB list, Ralf Baechle; +Cc: linux-mips
On 06/13/2013 08:42 AM, Markos Chandras wrote:
> Commit 94d83649e1c2f25c87dc4ead9c2ab073305
> "USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol"
>
> caused the following regression in cavium_octeon_defconfig:
>
> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects
> USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies
> (USB_SUPPORT && USB && USB_EHCI_HCD)
>
> We fix this problem by selecting the USB_EHCI_HCD missing dependency
> if USB_SUPPORT is enabled.
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
NAK. This is incorrect.
It is completely backwards and forces us to have EHCI unconditionally.
The proper fix is to move USB_EHCI_BIG_ENDIAN_MMIO (and similar other
Kconifg variables) out of the conditional section and make them
universally visible/usable.
David Daney
> ---
> This patch is for the upstream-sfr/mips-for-linux-next
> ---
> arch/mips/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 87ddac9..a058ba8 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1411,6 +1411,7 @@ config CPU_CAVIUM_OCTEON
> select CPU_SUPPORTS_HUGEPAGES
> select LIBFDT
> select USE_OF
> + select USB_EHCI_HCD if USB_SUPPORT
> select USB_EHCI_BIG_ENDIAN_MMIO
> help
> The Cavium Octeon processor is a highly integrated chip containing
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled
@ 2013-06-14 8:26 ` Markos Chandras
0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-06-14 8:26 UTC (permalink / raw)
To: David Daney; +Cc: USB list, Ralf Baechle, linux-mips
On 06/13/13 17:41, David Daney wrote:
> On 06/13/2013 08:42 AM, Markos Chandras wrote:
>> Commit 94d83649e1c2f25c87dc4ead9c2ab073305
>> "USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture
>> symbol"
>>
>> caused the following regression in cavium_octeon_defconfig:
>>
>> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects
>> USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies
>> (USB_SUPPORT && USB && USB_EHCI_HCD)
>>
>> We fix this problem by selecting the USB_EHCI_HCD missing dependency
>> if USB_SUPPORT is enabled.
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
>
> NAK. This is incorrect.
>
> It is completely backwards and forces us to have EHCI unconditionally.
>
> The proper fix is to move USB_EHCI_BIG_ENDIAN_MMIO (and similar other
> Kconifg variables) out of the conditional section and make them
> universally visible/usable.
>
> David Daney
>
>
Hi David,
Thanks. I will prepare a new patch.
--
markos
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled
@ 2013-06-14 8:26 ` Markos Chandras
0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-06-14 8:26 UTC (permalink / raw)
To: David Daney; +Cc: USB list, Ralf Baechle, linux-mips
On 06/13/13 17:41, David Daney wrote:
> On 06/13/2013 08:42 AM, Markos Chandras wrote:
>> Commit 94d83649e1c2f25c87dc4ead9c2ab073305
>> "USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture
>> symbol"
>>
>> caused the following regression in cavium_octeon_defconfig:
>>
>> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects
>> USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies
>> (USB_SUPPORT && USB && USB_EHCI_HCD)
>>
>> We fix this problem by selecting the USB_EHCI_HCD missing dependency
>> if USB_SUPPORT is enabled.
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
>
> NAK. This is incorrect.
>
> It is completely backwards and forces us to have EHCI unconditionally.
>
> The proper fix is to move USB_EHCI_BIG_ENDIAN_MMIO (and similar other
> Kconifg variables) out of the conditional section and make them
> universally visible/usable.
>
> David Daney
>
>
Hi David,
Thanks. I will prepare a new patch.
--
markos
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-14 8:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-13 15:42 [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled Markos Chandras
2013-06-13 15:42 ` Markos Chandras
2013-06-13 16:41 ` David Daney
2013-06-14 8:26 ` Markos Chandras
2013-06-14 8:26 ` Markos Chandras
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.