Re: [PATCH] MIPS: Kconfig: Select USB_EHCI_HCD if USB_SUPPORt is enabled

[Markos Chandras <Markos.Chandras@imgtec.com>]

On 06/13/13 17:41, David Daney wrote:
> On 06/13/2013 08:42 AM, Markos Chandras wrote:
>> Commit 94d83649e1c2f25c87dc4ead9c2ab073305
>> "USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture
>> symbol"
>>
>> caused the following regression in cavium_octeon_defconfig:
>>
>> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects
>> USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies
>> (USB_SUPPORT && USB && USB_EHCI_HCD)
>>
>> We fix this problem by selecting the USB_EHCI_HCD missing dependency
>> if USB_SUPPORT is enabled.
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
>
> NAK.  This is incorrect.
>
> It is completely backwards and forces us to have EHCI unconditionally.
>
> The proper fix is to move USB_EHCI_BIG_ENDIAN_MMIO (and similar other
> Kconifg variables) out of the conditional section and make them
> universally visible/usable.
>
> David Daney
>
>

Hi David,

Thanks. I will prepare a new patch.

-- 
markos