From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v4 0/8] sh_eth: deal with #ifdef'fery
Date: Sat, 15 Jun 2013 00:00:23 +0000 [thread overview]
Message-ID: <51BBAE97.30009@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoTM7KUn6Cm9hhQpyVT3qsAFANuD+CufarETSNZwqc5_Sw@mail.gmail.com>
On 06/06/2013 07:25 AM, Magnus Damm wrote:
>> This series deals mostly with excess #ifdef'fery in the 'sh_eth' driver.
>> It doesn't yet get rid of all the #ifdef'fery but that's a matter of another
>> patchset. The last patch (it was almost in the middle of the series before),
>> contrarywise, adds one missing #ifdef...
>> [1/8] sh_eth: remove #ifdef around EDSR and GECMR bit definitions
>> [2/8] sh_eth: use EDSR_ENALL to set EDSR
>> [3/8] sh_eth: remove duplicate sh_eth_set_duplex() definitions
>> [4/8] sh_eth: remove SH_ETH_HAS_TSU
>> [5/8] sh_eth: add IRQ flags to 'struct sh_eth_cpu_data'
>> [6/8] sh_eth: remove #ifdef around sh_eth_select_mii()
>> [7/8] sh_eth: consolidate sh_eth_reset()
>> [8/8] sh_eth: enclose PM code into #ifdef CONFIG_PM
> Thanks for your work on this. I'm looking forward to a sh-eth driver
> without #ifdef hell.
> It may be just me misunderstanding, but the other day I noticed that
> external PHY handling seems broken in the sh-eth driver. I tried to
> enable a micron PHY driver but could not make the pieces fit together.
What kernel you were using, net-next? It seems that the PHY support
is indeed broken after this series. The phylib simply reports that it
didn't find a PHY at the specified address. :-/
I'll continue to investigate this on the weekend...
> Cheers,
> / magnus
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v4 0/8] sh_eth: deal with #ifdef'fery
Date: Sat, 15 Jun 2013 04:00:23 +0400 [thread overview]
Message-ID: <51BBAE97.30009@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoTM7KUn6Cm9hhQpyVT3qsAFANuD+CufarETSNZwqc5_Sw@mail.gmail.com>
On 06/06/2013 07:25 AM, Magnus Damm wrote:
>> This series deals mostly with excess #ifdef'fery in the 'sh_eth' driver.
>> It doesn't yet get rid of all the #ifdef'fery but that's a matter of another
>> patchset. The last patch (it was almost in the middle of the series before),
>> contrarywise, adds one missing #ifdef...
>> [1/8] sh_eth: remove #ifdef around EDSR and GECMR bit definitions
>> [2/8] sh_eth: use EDSR_ENALL to set EDSR
>> [3/8] sh_eth: remove duplicate sh_eth_set_duplex() definitions
>> [4/8] sh_eth: remove SH_ETH_HAS_TSU
>> [5/8] sh_eth: add IRQ flags to 'struct sh_eth_cpu_data'
>> [6/8] sh_eth: remove #ifdef around sh_eth_select_mii()
>> [7/8] sh_eth: consolidate sh_eth_reset()
>> [8/8] sh_eth: enclose PM code into #ifdef CONFIG_PM
> Thanks for your work on this. I'm looking forward to a sh-eth driver
> without #ifdef hell.
> It may be just me misunderstanding, but the other day I noticed that
> external PHY handling seems broken in the sh-eth driver. I tried to
> enable a micron PHY driver but could not make the pieces fit together.
What kernel you were using, net-next? It seems that the PHY support
is indeed broken after this series. The phylib simply reports that it
didn't find a PHY at the specified address. :-/
I'll continue to investigate this on the weekend...
> Cheers,
> / magnus
WBR, Sergei
next prev parent reply other threads:[~2013-06-15 0:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 21:06 [PATCH v4 0/8] sh_eth: deal with #ifdef'fery Sergei Shtylyov
2013-06-05 21:06 ` Sergei Shtylyov
2013-06-05 21:09 ` [PATCH v4 1/8] sh_eth: remove #ifdef around EDSR and GECMR bit definitions Sergei Shtylyov
2013-06-05 21:09 ` Sergei Shtylyov
2013-06-05 21:11 ` [PATCH v4 2/8] sh_eth: use EDSR_ENALL to set EDSR Sergei Shtylyov
2013-06-05 21:11 ` Sergei Shtylyov
2013-06-05 21:12 ` [PATCH v4 3/8] sh_eth: remove duplicate sh_eth_set_duplex() definitions Sergei Shtylyov
2013-06-05 21:12 ` Sergei Shtylyov
2013-06-05 21:14 ` [PATCH v4 4/8] sh_eth: remove SH_ETH_HAS_TSU Sergei Shtylyov
2013-06-05 21:14 ` Sergei Shtylyov
2013-06-05 21:15 ` [PATCH v4 5/8] sh_eth: add IRQ flags to 'struct sh_eth_cpu_data' Sergei Shtylyov
2013-06-05 21:15 ` Sergei Shtylyov
2013-06-05 21:16 ` [PATCH v4 6/8] sh_eth: remove #ifdef around sh_eth_select_mii() Sergei Shtylyov
2013-06-05 21:16 ` Sergei Shtylyov
2013-06-05 21:19 ` [PATCH v4 7/8] sh_eth: consolidate sh_eth_reset() Sergei Shtylyov
2013-06-05 21:19 ` Sergei Shtylyov
2013-06-05 22:50 ` Sergei Shtylyov
2013-06-05 22:50 ` Sergei Shtylyov
2013-06-05 21:20 ` [PATCH v4 8/8] sh_eth: enclose PM code into #ifdef CONFIG_PM Sergei Shtylyov
2013-06-05 21:20 ` Sergei Shtylyov
2013-06-05 22:50 ` [PATCH v4 0/8] sh_eth: deal with #ifdef'fery Sergei Shtylyov
2013-06-05 22:50 ` Sergei Shtylyov
2013-06-06 3:25 ` Magnus Damm
2013-06-06 3:25 ` Magnus Damm
2013-06-06 14:36 ` Sergei Shtylyov
2013-06-06 14:36 ` Sergei Shtylyov
2013-06-15 0:00 ` Sergei Shtylyov [this message]
2013-06-15 0:00 ` Sergei Shtylyov
2013-06-15 0:02 ` Sergei Shtylyov
2013-06-15 0:02 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BBAE97.30009@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.