From: "Andreas Färber" <afaerber@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
Peter Wu <lekensteyn@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] vl: always define no_frame
Date: Sun, 16 Jun 2013 19:26:46 +0200 [thread overview]
Message-ID: <51BDF556.9040807@suse.de> (raw)
In-Reply-To: <1371292923-28105-1-git-send-email-mjt@msgid.tls.msk.ru>
Am 15.06.2013 12:42, schrieb Michael Tokarev:
> Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke
> build of qemu without sdl, by referencing `no_frame' variable which is defined
> inside #if SDL block. Fix that by defining that variable unconditionally.
>
> This is a better fix for the build issue introduced by that patch than
> a revert. This change keeps the new functinality introduced by that patch
> and just fixes the compilation. It still is not a complete fix around the
> original issue (not working -no-frame et al with -display gtk), because it
> makes only the legacy interface working, not the new suboption interface,
> so a few more changes are needed.
>
> Cc: Peter Wu <lekensteyn@gmail.com>
> Cc: qemu-trivial@nongnu.org
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Tested-by: Andreas Färber <afaerber@suse.de>
Unbreaks my headless ppc build.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
Peter Wu <lekensteyn@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH trivial] vl: always define no_frame
Date: Sun, 16 Jun 2013 19:26:46 +0200 [thread overview]
Message-ID: <51BDF556.9040807@suse.de> (raw)
In-Reply-To: <1371292923-28105-1-git-send-email-mjt@msgid.tls.msk.ru>
Am 15.06.2013 12:42, schrieb Michael Tokarev:
> Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke
> build of qemu without sdl, by referencing `no_frame' variable which is defined
> inside #if SDL block. Fix that by defining that variable unconditionally.
>
> This is a better fix for the build issue introduced by that patch than
> a revert. This change keeps the new functinality introduced by that patch
> and just fixes the compilation. It still is not a complete fix around the
> original issue (not working -no-frame et al with -display gtk), because it
> makes only the legacy interface working, not the new suboption interface,
> so a few more changes are needed.
>
> Cc: Peter Wu <lekensteyn@gmail.com>
> Cc: qemu-trivial@nongnu.org
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Tested-by: Andreas Färber <afaerber@suse.de>
Unbreaks my headless ppc build.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-16 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 10:42 [Qemu-trivial] [PATCH trivial] vl: always define no_frame Michael Tokarev
2013-06-15 10:42 ` [Qemu-devel] " Michael Tokarev
2013-06-15 10:51 ` [Qemu-trivial] " Peter Wu
2013-06-15 10:51 ` [Qemu-devel] " Peter Wu
2013-06-15 11:05 ` [Qemu-trivial] " Michael Tokarev
2013-06-15 11:05 ` [Qemu-devel] " Michael Tokarev
2013-06-16 17:26 ` Andreas Färber [this message]
2013-06-16 17:26 ` Andreas Färber
2013-06-17 21:06 ` [Qemu-trivial] " Anthony Liguori
2013-06-17 21:06 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BDF556.9040807@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=lekensteyn@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.