All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Wu <lekensteyn@gmail.com>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH trivial] vl: always define no_frame
Date: Sat, 15 Jun 2013 15:05:27 +0400	[thread overview]
Message-ID: <51BC4A77.7020308@msgid.tls.msk.ru> (raw)
In-Reply-To: <12048990.5frBUX2jFf@al>

15.06.2013 14:51, Peter Wu wrote:
> On Saturday 15 June 2013 14:42:03 Michael Tokarev wrote:
> 
>> Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke
>> build of qemu without sdl, by referencing `no_frame' variable which is
>> defined inside #if SDL block. Fix that by defining that variable
>> unconditionally.
> 
> Reviewed-by: Peter Wu <lekensteyn@gmail.com>

Thanks!

> As for the discussion about legacy options[1], are there plans to remove `-sdl` (replaced by `-display sdl`) and move the `-*-grab` and `-no-frame` to `-display sdl` options? If that is the idea, what about printing a message that the mentioned options are deprecated and removed in a future version?

This is already done for sdl, see select_display() function in vl.c --
it handles -display sdl,frame={on|off},...

It is unlikely the old options will be removed any time soon, and
these will not likely print any warnings either -- this hasn't done
for lots of other old options (-stdvga for example).

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Wu <lekensteyn@gmail.com>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH trivial] vl: always define no_frame
Date: Sat, 15 Jun 2013 15:05:27 +0400	[thread overview]
Message-ID: <51BC4A77.7020308@msgid.tls.msk.ru> (raw)
In-Reply-To: <12048990.5frBUX2jFf@al>

15.06.2013 14:51, Peter Wu wrote:
> On Saturday 15 June 2013 14:42:03 Michael Tokarev wrote:
> 
>> Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke
>> build of qemu without sdl, by referencing `no_frame' variable which is
>> defined inside #if SDL block. Fix that by defining that variable
>> unconditionally.
> 
> Reviewed-by: Peter Wu <lekensteyn@gmail.com>

Thanks!

> As for the discussion about legacy options[1], are there plans to remove `-sdl` (replaced by `-display sdl`) and move the `-*-grab` and `-no-frame` to `-display sdl` options? If that is the idea, what about printing a message that the mentioned options are deprecated and removed in a future version?

This is already done for sdl, see select_display() function in vl.c --
it handles -display sdl,frame={on|off},...

It is unlikely the old options will be removed any time soon, and
these will not likely print any warnings either -- this hasn't done
for lots of other old options (-stdvga for example).

Thanks,

/mjt

  reply	other threads:[~2013-06-15 11:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-15 10:42 [Qemu-trivial] [PATCH trivial] vl: always define no_frame Michael Tokarev
2013-06-15 10:42 ` [Qemu-devel] " Michael Tokarev
2013-06-15 10:51 ` [Qemu-trivial] " Peter Wu
2013-06-15 10:51   ` [Qemu-devel] " Peter Wu
2013-06-15 11:05   ` Michael Tokarev [this message]
2013-06-15 11:05     ` Michael Tokarev
2013-06-16 17:26 ` [Qemu-trivial] " Andreas Färber
2013-06-16 17:26   ` Andreas Färber
2013-06-17 21:06 ` [Qemu-trivial] " Anthony Liguori
2013-06-17 21:06   ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BC4A77.7020308@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=aliguori@us.ibm.com \
    --cc=lekensteyn@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.