All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, berrange@redhat.com,
	qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] acl: acl_add can't insert before last list element, fix
Date: Wed, 19 Jun 2013 11:44:06 +0400	[thread overview]
Message-ID: <51C16146.3040100@msgid.tls.msk.ru> (raw)
In-Reply-To: <1371542723-926-1-git-send-email-armbru@redhat.com>

18.06.2013 12:05, Markus Armbruster wrote:
[]
> The second acl_add inserts at position 2 instead of 1.
> 
> Root cause is an off-by-one in qemu_acl_insert(): when index ==
> acl->nentries, it appends instead of inserting before the last list
> element.

Thanks, applied to the trivial patches queue.

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] acl: acl_add can't insert before last list element, fix
Date: Wed, 19 Jun 2013 11:44:06 +0400	[thread overview]
Message-ID: <51C16146.3040100@msgid.tls.msk.ru> (raw)
In-Reply-To: <1371542723-926-1-git-send-email-armbru@redhat.com>

18.06.2013 12:05, Markus Armbruster wrote:
[]
> The second acl_add inserts at position 2 instead of 1.
> 
> Root cause is an off-by-one in qemu_acl_insert(): when index ==
> acl->nentries, it appends instead of inserting before the last list
> element.

Thanks, applied to the trivial patches queue.

/mjt

  parent reply	other threads:[~2013-06-19  7:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  8:05 [Qemu-trivial] [PATCH] acl: acl_add can't insert before last list element, fix Markus Armbruster
2013-06-18  8:05 ` [Qemu-devel] " Markus Armbruster
2013-06-18 18:15 ` [Qemu-trivial] [Qemu-stable] " mdroth
2013-06-18 18:15   ` [Qemu-devel] " mdroth
2013-06-19  7:44 ` Michael Tokarev [this message]
2013-06-19  7:44   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-07-31 14:44 ` Markus Armbruster
2013-07-31 14:44   ` [Qemu-devel] " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C16146.3040100@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.