From: Chen Gang <gang.chen@asianux.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
Tony Lindgren <tony@atomide.com>,
"olof@lixom.net" <olof@lixom.net>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler()
Date: Mon, 24 Jun 2013 17:19:46 +0800 [thread overview]
Message-ID: <51C80F32.4060500@asianux.com> (raw)
In-Reply-To: <20130624084744.GA23779@mudshark.cambridge.arm.com>
On 06/24/2013 04:47 PM, Will Deacon wrote:
> On Sat, Jun 22, 2013 at 06:54:14AM +0100, Chen Gang wrote:
>> >
>> > If 'COMPAT' not defined, aarch32_break_handler() cannot pass compiling,
>> > so need add '#ifdef' for it just like the header file has done.
>> >
>> > The related make:
>> >
>> > make ARCH=arm64 randconfig
>> > make ARCH=arm64 menuconfig
>> > make ARCH=arm64 V=1 EXTRA_CFLAGS=-W
>> >
>> > The related error:
>> >
>> > arch/arm64/kernel/debug-monitors.c:249:5: error: redefinition of ‘aarch32_break_handler’
>> > In file included from arch/arm64/kernel/debug-monitors.c:29:0:
>> > /root/linux-next/arch/arm64/include/asm/debug-monitors.h:89:12: note: previous definition of ‘aarch32_break_handler’ was here
> Actually, can we just kill the static definition in debug-monitors.h
> instead? I don't see anything in the full-blown aardch32_break_handler that
> won't play nicely if !COMPAT.
It sounds good, I will send patch v2.
Thanks.
--
Chen Gang
Asianux Corporation
WARNING: multiple messages have this Message-ID (diff)
From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler()
Date: Mon, 24 Jun 2013 17:19:46 +0800 [thread overview]
Message-ID: <51C80F32.4060500@asianux.com> (raw)
In-Reply-To: <20130624084744.GA23779@mudshark.cambridge.arm.com>
On 06/24/2013 04:47 PM, Will Deacon wrote:
> On Sat, Jun 22, 2013 at 06:54:14AM +0100, Chen Gang wrote:
>> >
>> > If 'COMPAT' not defined, aarch32_break_handler() cannot pass compiling,
>> > so need add '#ifdef' for it just like the header file has done.
>> >
>> > The related make:
>> >
>> > make ARCH=arm64 randconfig
>> > make ARCH=arm64 menuconfig
>> > make ARCH=arm64 V=1 EXTRA_CFLAGS=-W
>> >
>> > The related error:
>> >
>> > arch/arm64/kernel/debug-monitors.c:249:5: error: redefinition of ?aarch32_break_handler?
>> > In file included from arch/arm64/kernel/debug-monitors.c:29:0:
>> > /root/linux-next/arch/arm64/include/asm/debug-monitors.h:89:12: note: previous definition of ?aarch32_break_handler? was here
> Actually, can we just kill the static definition in debug-monitors.h
> instead? I don't see anything in the full-blown aardch32_break_handler that
> won't play nicely if !COMPAT.
It sounds good, I will send patch v2.
Thanks.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-06-24 9:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 5:54 [PATCH] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler() Chen Gang
2013-06-22 5:54 ` Chen Gang
2013-06-24 8:47 ` Will Deacon
2013-06-24 8:47 ` Will Deacon
2013-06-24 9:19 ` Chen Gang [this message]
2013-06-24 9:19 ` Chen Gang
2013-06-24 9:27 ` [PATCH v2] " Chen Gang
2013-06-24 9:27 ` Chen Gang
2013-06-24 10:06 ` [Suggestion] arch: arm64: xen: "ln -s" the paravirt.h from arm Chen Gang
2013-06-24 15:43 ` Stefano Stabellini
2013-06-24 15:43 ` Stefano Stabellini
2013-06-24 16:50 ` Stefano Stabellini
2013-06-24 16:50 ` Stefano Stabellini
2013-06-25 1:31 ` Chen Gang
2013-06-25 1:31 ` Chen Gang
2013-06-25 12:32 ` Stefano Stabellini
2013-06-25 12:32 ` Stefano Stabellini
2013-06-25 13:25 ` Catalin Marinas
2013-06-25 13:25 ` Catalin Marinas
2013-06-25 15:54 ` Stefano Stabellini
2013-06-25 15:54 ` Stefano Stabellini
2013-06-24 10:14 ` [PATCH v2] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler() Will Deacon
2013-06-24 10:14 ` Will Deacon
2013-06-24 10:16 ` Chen Gang
2013-06-24 10:16 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C80F32.4060500@asianux.com \
--to=gang.chen@asianux.com \
--cc=Catalin.Marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.