[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

[Jason Liu]

When the local timer freq changed, the twd_update_frequency function
should be run all the CPUs include itself, otherwise, the twd freq will
not get updated and the local timer will not run correcttly.

smp_call_function will run functions on all other CPUs, but not include
himself, this is not correct,use on_each_cpu instead to fix this issue.

Signed-off-by: Jason Liu <r64343@freescale.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: stable at vger.kernel.org
---
 arch/arm/kernel/smp_twd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
index 90525d9..f6fd1d4 100644
--- a/arch/arm/kernel/smp_twd.c
+++ b/arch/arm/kernel/smp_twd.c
@@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block *nb,
 	 * changing cpu.
 	 */
 	if (flags == POST_RATE_CHANGE)
-		smp_call_function(twd_update_frequency,
+		on_each_cpu(twd_update_frequency,
 				  (void *)&cnd->new_rate, 1);
 
 	return NOTIFY_OK;
-- 
1.7.10.4

[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

[Linus Walleij]

On Thu, Jun 13, 2013 at 1:19 AM, Jason Liu <r64343@freescale.com> wrote:

> When the local timer freq changed, the twd_update_frequency function
> should be run all the CPUs include itself, otherwise, the twd freq will
> not get updated and the local timer will not run correcttly.
>
> smp_call_function will run functions on all other CPUs, but not include
> himself, this is not correct,use on_each_cpu instead to fix this issue.
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: stable at vger.kernel.org

Mike Turquette wrote this code, so let him look at it.

But it makes sense to me:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Please mark this for stable and put it into Russell's patch tracker
after allowing some time for others to have a look.

Yours,
Linus Walleij

[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

[Liu Hui-R64343]

>-----Original Message-----
>From: Linus Walleij [mailto:linus.walleij at linaro.org]
>Sent: Thursday, June 13, 2013 4:00 PM
>To: Liu Hui-R64343; Mike Turquette
>Cc: linux-arm-kernel at lists.infradead.org; Russell King - ARM Linux
>Subject: Re: [PATCH] ARM: smp_twd: twd_update_frequency need be run on
>all online CPUs
>
>On Thu, Jun 13, 2013 at 1:19 AM, Jason Liu <r64343@freescale.com> wrote:
>
>> When the local timer freq changed, the twd_update_frequency function
>> should be run all the CPUs include itself, otherwise, the twd freq
>> will not get updated and the local timer will not run correcttly.
>>
>> smp_call_function will run functions on all other CPUs, but not
>> include himself, this is not correct,use on_each_cpu instead to fix
>this issue.
>>
>> Signed-off-by: Jason Liu <r64343@freescale.com>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Shawn Guo <shawn.guo@linaro.org>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: stable at vger.kernel.org
>
>Mike Turquette wrote this code, so let him look at it.

Mike, could you please look at it?

>
>But it makes sense to me:
>Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks Linus W.

>
>Please mark this for stable and put it into Russell's patch tracker
>after allowing some time for others to have a look.

Sure, Will do it after others look at it. 

>
>Yours,
>Linus Walleij

[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

[Shawn Guo]

On Thu, Jun 13, 2013 at 07:19:40AM +0800, Jason Liu wrote:
> When the local timer freq changed, the twd_update_frequency function
> should be run all the CPUs include itself, otherwise, the twd freq will
> not get updated and the local timer will not run correcttly.
> 
> smp_call_function will run functions on all other CPUs, but not include
> himself, this is not correct,use on_each_cpu instead to fix this issue.
> 
> Signed-off-by: Jason Liu <r64343@freescale.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

BTW, is there anything wrong with your mailer (git send-email command
line)?  I do not see people you put on Cc tag here show up in Cc of the
email.  And that might the be reason why people are not responding so
far.

Shawn

> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: stable at vger.kernel.org
> ---
>  arch/arm/kernel/smp_twd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
> index 90525d9..f6fd1d4 100644
> --- a/arch/arm/kernel/smp_twd.c
> +++ b/arch/arm/kernel/smp_twd.c
> @@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block *nb,
>  	 * changing cpu.
>  	 */
>  	if (flags == POST_RATE_CHANGE)
> -		smp_call_function(twd_update_frequency,
> +		on_each_cpu(twd_update_frequency,
>  				  (void *)&cnd->new_rate, 1);
>  
>  	return NOTIFY_OK;
> -- 
> 1.7.10.4
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

[Liu Hui-R64343]

>-----Original Message-----
>From: Shawn Guo [mailto:shawn.guo at linaro.org]
>Sent: Monday, June 17, 2013 3:31 PM
>To: Liu Hui-R64343
>Cc: linux-arm-kernel at lists.infradead.org
>Subject: Re: [PATCH] ARM: smp_twd: twd_update_frequency need be run on
>all online CPUs
>
>On Thu, Jun 13, 2013 at 07:19:40AM +0800, Jason Liu wrote:
>> When the local timer freq changed, the twd_update_frequency function
>> should be run all the CPUs include itself, otherwise, the twd freq
>> will not get updated and the local timer will not run correcttly.
>>
>> smp_call_function will run functions on all other CPUs, but not
>> include himself, this is not correct,use on_each_cpu instead to fix
>this issue.
>>
>> Signed-off-by: Jason Liu <r64343@freescale.com>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Shawn Guo <shawn.guo@linaro.org>
>
>Acked-by: Shawn Guo <shawn.guo@linaro.org>

Thanks Shawn.

>
>BTW, is there anything wrong with your mailer (git send-email command
>line)?  I do not see people you put on Cc tag here show up in Cc of the
>email.  And that might the be reason why people are not responding so
>far.

Yes, there is one issue in my script and get fixed. I will put the patch
Into Russell's patch tracking system after Mike and Russell reviewed it
And also Cc stable kernel as Linus W. said. 

>
>Shawn
>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: stable at vger.kernel.org
>> ---
>>  arch/arm/kernel/smp_twd.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
>> index 90525d9..f6fd1d4 100644
>> --- a/arch/arm/kernel/smp_twd.c
>> +++ b/arch/arm/kernel/smp_twd.c
>> @@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block
>*nb,
>>  	 * changing cpu.
>>  	 */
>>  	if (flags == POST_RATE_CHANGE)
>> -		smp_call_function(twd_update_frequency,
>> +		on_each_cpu(twd_update_frequency,
>>  				  (void *)&cnd->new_rate, 1);
>>
>>  	return NOTIFY_OK;
>> --
>> 1.7.10.4
>>
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

[Dirk Behme]

On 17.06.2013 10:11, Liu Hui-R64343 wrote:
>> -----Original Message-----
>> From: Shawn Guo [mailto:shawn.guo at linaro.org]
>> Sent: Monday, June 17, 2013 3:31 PM
>> To: Liu Hui-R64343
>> Cc: linux-arm-kernel at lists.infradead.org
>> Subject: Re: [PATCH] ARM: smp_twd: twd_update_frequency need be run on
>> all online CPUs
>>
>> On Thu, Jun 13, 2013 at 07:19:40AM +0800, Jason Liu wrote:
>>> When the local timer freq changed, the twd_update_frequency function
>>> should be run all the CPUs include itself, otherwise, the twd freq
>>> will not get updated and the local timer will not run correcttly.
>>>
>>> smp_call_function will run functions on all other CPUs, but not
>>> include himself, this is not correct,use on_each_cpu instead to fix
>> this issue.
>>>
>>> Signed-off-by: Jason Liu <r64343@freescale.com>
>>> Cc: Russell King <linux@arm.linux.org.uk>
>>> Cc: Linus Walleij <linus.walleij@linaro.org>
>>> Cc: Rob Herring <rob.herring@calxeda.com>
>>> Cc: Shawn Guo <shawn.guo@linaro.org>
>>
>> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
> Thanks Shawn.
>
>>
>> BTW, is there anything wrong with your mailer (git send-email command
>> line)?  I do not see people you put on Cc tag here show up in Cc of the
>> email.  And that might the be reason why people are not responding so
>> far.
>
> Yes, there is one issue in my script and get fixed. I will put the patch
> Into Russell's patch tracking system after Mike and Russell reviewed it
> And also Cc stable kernel as Linus W. said.

Any news on this?

Thanks

Dirk

>> Shawn
>>
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Cc: stable at vger.kernel.org
>>> ---
>>>   arch/arm/kernel/smp_twd.c |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
>>> index 90525d9..f6fd1d4 100644
>>> --- a/arch/arm/kernel/smp_twd.c
>>> +++ b/arch/arm/kernel/smp_twd.c
>>> @@ -120,7 +120,7 @@ static int twd_rate_change(struct notifier_block
>> *nb,
>>>   	 * changing cpu.
>>>   	 */
>>>   	if (flags == POST_RATE_CHANGE)
>>> -		smp_call_function(twd_update_frequency,
>>> +		on_each_cpu(twd_update_frequency,
>>>   				  (void *)&cnd->new_rate, 1);
>>>
>>>   	return NOTIFY_OK;
>>> --
>>> 1.7.10.4

[PATCH] ARM: smp_twd: twd_update_frequency need be run on all online CPUs

[Liu Hui-R64343]

>-----Original Message-----
>From: Dirk Behme [mailto:dirk.behme at de.bosch.com]
>Sent: Wednesday, June 26, 2013 8:29 PM
>To: Liu Hui-R64343; Mike Turquette
>Cc: Shawn Guo; Linus Walleij; rob.herring at calxeda.com; Russell King -
>ARM Linux; linux-arm-kernel at lists.infradead.org
>Subject: Re: [PATCH] ARM: smp_twd: twd_update_frequency need be run on
>all online CPUs
>
>On 17.06.2013 10:11, Liu Hui-R64343 wrote:
>>> -----Original Message-----
>>> From: Shawn Guo [mailto:shawn.guo at linaro.org]
>>> Sent: Monday, June 17, 2013 3:31 PM
>>> To: Liu Hui-R64343
>>> Cc: linux-arm-kernel at lists.infradead.org
>>> Subject: Re: [PATCH] ARM: smp_twd: twd_update_frequency need be run
>>> on all online CPUs
>>>
>>> On Thu, Jun 13, 2013 at 07:19:40AM +0800, Jason Liu wrote:
>>>> When the local timer freq changed, the twd_update_frequency function
>>>> should be run all the CPUs include itself, otherwise, the twd freq
>>>> will not get updated and the local timer will not run correcttly.
>>>>
>>>> smp_call_function will run functions on all other CPUs, but not
>>>> include himself, this is not correct,use on_each_cpu instead to fix
>>> this issue.
>>>>
>>>> Signed-off-by: Jason Liu <r64343@freescale.com>
>>>> Cc: Russell King <linux@arm.linux.org.uk>
>>>> Cc: Linus Walleij <linus.walleij@linaro.org>
>>>> Cc: Rob Herring <rob.herring@calxeda.com>
>>>> Cc: Shawn Guo <shawn.guo@linaro.org>
>>>
>>> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>>
>> Thanks Shawn.
>>
>>>
>>> BTW, is there anything wrong with your mailer (git send-email command
>>> line)?  I do not see people you put on Cc tag here show up in Cc of
>>> the email.  And that might the be reason why people are not
>>> responding so far.
>>
>> Yes, there is one issue in my script and get fixed. I will put the
>> patch Into Russell's patch tracking system after Mike and Russell
>> reviewed it And also Cc stable kernel as Linus W. said.
>
>Any news on this?

I have put the patch into Russell's patch tracking system. 

>
>Thanks
>