From: Lars-Peter Clausen <lars@metafoo.de>
To: Bo Shen <voice.shen@atmel.com>
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, richard.genoud@gmail.com,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback
Date: Tue, 02 Jul 2013 17:25:46 +0200 [thread overview]
Message-ID: <51D2F0FA.6040409@metafoo.de> (raw)
In-Reply-To: <1372755849-19546-2-git-send-email-voice.shen@atmel.com>
On 07/02/2013 11:04 AM, Bo Shen wrote:
[...]
> + dma_params->substream = substream;
Unrelated to this patch, but having a substream field in the dma_params seems
to be redundant, since you need to know the substream to get the dma_params in
the first place. Looking at the code it also seems to be unused other than this
assignment. Maybe you can send a follow up patch to remove it.
[...]
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Bo Shen <voice.shen@atmel.com>
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, richard.genoud@gmail.com,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback
Date: Tue, 02 Jul 2013 15:25:46 +0000 [thread overview]
Message-ID: <51D2F0FA.6040409@metafoo.de> (raw)
In-Reply-To: <1372755849-19546-2-git-send-email-voice.shen@atmel.com>
On 07/02/2013 11:04 AM, Bo Shen wrote:
[...]
> + dma_params->substream = substream;
Unrelated to this patch, but having a substream field in the dma_params seems
to be redundant, since you need to know the substream to get the dma_params in
the first place. Looking at the code it also seems to be unused other than this
assignment. Maybe you can send a follow up patch to remove it.
[...]
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback
Date: Tue, 02 Jul 2013 17:25:46 +0200 [thread overview]
Message-ID: <51D2F0FA.6040409@metafoo.de> (raw)
In-Reply-To: <1372755849-19546-2-git-send-email-voice.shen@atmel.com>
On 07/02/2013 11:04 AM, Bo Shen wrote:
[...]
> + dma_params->substream = substream;
Unrelated to this patch, but having a substream field in the dma_params seems
to be redundant, since you need to know the substream to get the dma_params in
the first place. Looking at the code it also seems to be unused other than this
assignment. Maybe you can send a follow up patch to remove it.
[...]
next prev parent reply other threads:[~2013-07-02 15:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 9:04 [PATCH 0/2] ASoC: atmel-pcm: use generic dmaengine framework Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 15:25 ` Lars-Peter Clausen [this message]
2013-07-02 15:25 ` [alsa-devel] " Lars-Peter Clausen
2013-07-02 15:25 ` Lars-Peter Clausen
2013-07-03 1:20 ` Bo Shen
2013-07-03 1:20 ` Bo Shen
2013-07-03 1:20 ` Bo Shen
2013-07-03 1:20 ` Bo Shen
2013-07-03 5:22 ` Bo Shen
2013-07-03 5:22 ` Bo Shen
2013-07-03 5:22 ` Bo Shen
2013-07-02 9:04 ` [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 15:34 ` [alsa-devel] " Lars-Peter Clausen
2013-07-02 15:34 ` Lars-Peter Clausen
2013-07-02 15:34 ` Lars-Peter Clausen
2013-07-03 1:33 ` Bo Shen
2013-07-03 1:33 ` Bo Shen
2013-07-03 1:33 ` Bo Shen
2013-07-03 1:33 ` Bo Shen
2013-07-03 7:36 ` Lars-Peter Clausen
2013-07-03 7:36 ` Lars-Peter Clausen
2013-07-03 7:36 ` Lars-Peter Clausen
2013-07-03 7:57 ` Bo Shen
2013-07-03 7:57 ` Bo Shen
2013-07-03 7:57 ` Bo Shen
2013-07-03 7:57 ` Bo Shen
2013-07-03 8:08 ` Lars-Peter Clausen
2013-07-03 8:08 ` Lars-Peter Clausen
2013-07-03 8:08 ` Lars-Peter Clausen
2013-07-03 8:13 ` Bo Shen
2013-07-03 8:13 ` [alsa-devel] " Bo Shen
2013-07-03 8:13 ` Bo Shen
2013-07-03 8:13 ` Bo Shen
-- strict thread matches above, loose matches on Subject: below --
2013-07-02 7:55 [PATCH 0/2] " Bo Shen
2013-07-02 7:55 ` Bo Shen
2013-07-02 7:55 ` [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback Bo Shen
2013-07-02 7:55 ` Bo Shen
2013-07-02 7:55 ` [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework Bo Shen
2013-07-02 7:55 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2F0FA.6040409@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=richard.genoud@gmail.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.