From: Bo Shen <voice.shen@atmel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, richard.genoud@gmail.com,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework
Date: Wed, 3 Jul 2013 15:57:29 +0800 [thread overview]
Message-ID: <51D3D969.1060308@atmel.com> (raw)
In-Reply-To: <51D3D482.1050100@metafoo.de>
Hi Lars,
On 7/3/2013 15:36, Lars-Peter Clausen wrote:
>>>> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR;
>>> >>[...]
>>>> >>>+ slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR;
>>> >>
>>> >>Change the type of phybase to dma_addr_t
>> >
>> >It should be:
>> >slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR);
>> >slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR);
> The type of phybase in the ssc_device struct should be changed from
> resource_size_t to dma_addr_t.
Actually, the phybase in ssc_device structure is resource_size_t which
used to access the ssc device register.
Here, we use ssc register as dma source address or destination address,
so we convert it to dma_addr_t type. So, not need to change, am I right?
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, richard.genoud@gmail.com,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework
Date: Wed, 03 Jul 2013 07:57:29 +0000 [thread overview]
Message-ID: <51D3D969.1060308@atmel.com> (raw)
In-Reply-To: <51D3D482.1050100@metafoo.de>
Hi Lars,
On 7/3/2013 15:36, Lars-Peter Clausen wrote:
>>>> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR;
>>> >>[...]
>>>> >>>+ slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR;
>>> >>
>>> >>Change the type of phybase to dma_addr_t
>> >
>> >It should be:
>> >slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR);
>> >slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR);
> The type of phybase in the ssc_device struct should be changed from
> resource_size_t to dma_addr_t.
Actually, the phybase in ssc_device structure is resource_size_t which
used to access the ssc device register.
Here, we use ssc register as dma source address or destination address,
so we convert it to dma_addr_t type. So, not need to change, am I right?
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: voice.shen@atmel.com (Bo Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework
Date: Wed, 3 Jul 2013 15:57:29 +0800 [thread overview]
Message-ID: <51D3D969.1060308@atmel.com> (raw)
In-Reply-To: <51D3D482.1050100@metafoo.de>
Hi Lars,
On 7/3/2013 15:36, Lars-Peter Clausen wrote:
>>>> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR;
>>> >>[...]
>>>> >>>+ slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR;
>>> >>
>>> >>Change the type of phybase to dma_addr_t
>> >
>> >It should be:
>> >slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR);
>> >slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR);
> The type of phybase in the ssc_device struct should be changed from
> resource_size_t to dma_addr_t.
Actually, the phybase in ssc_device structure is resource_size_t which
used to access the ssc device register.
Here, we use ssc register as dma source address or destination address,
so we convert it to dma_addr_t type. So, not need to change, am I right?
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mark Brown <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
<richard.genoud@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
<linux-kernel@vger.kernel.org>, <linux-sound@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework
Date: Wed, 3 Jul 2013 15:57:29 +0800 [thread overview]
Message-ID: <51D3D969.1060308@atmel.com> (raw)
In-Reply-To: <51D3D482.1050100@metafoo.de>
Hi Lars,
On 7/3/2013 15:36, Lars-Peter Clausen wrote:
>>>> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR;
>>> >>[...]
>>>> >>>+ slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR;
>>> >>
>>> >>Change the type of phybase to dma_addr_t
>> >
>> >It should be:
>> >slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR);
>> >slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR);
> The type of phybase in the ssc_device struct should be changed from
> resource_size_t to dma_addr_t.
Actually, the phybase in ssc_device structure is resource_size_t which
used to access the ssc device register.
Here, we use ssc register as dma source address or destination address,
so we convert it to dma_addr_t type. So, not need to change, am I right?
Best Regards,
Bo Shen
next prev parent reply other threads:[~2013-07-03 7:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 9:04 [PATCH 0/2] ASoC: atmel-pcm: use generic dmaengine framework Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 15:25 ` [alsa-devel] " Lars-Peter Clausen
2013-07-02 15:25 ` Lars-Peter Clausen
2013-07-02 15:25 ` Lars-Peter Clausen
2013-07-03 1:20 ` Bo Shen
2013-07-03 1:20 ` Bo Shen
2013-07-03 1:20 ` Bo Shen
2013-07-03 1:20 ` Bo Shen
2013-07-03 5:22 ` Bo Shen
2013-07-03 5:22 ` Bo Shen
2013-07-03 5:22 ` Bo Shen
2013-07-02 9:04 ` [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 9:04 ` Bo Shen
2013-07-02 15:34 ` [alsa-devel] " Lars-Peter Clausen
2013-07-02 15:34 ` Lars-Peter Clausen
2013-07-02 15:34 ` Lars-Peter Clausen
2013-07-03 1:33 ` Bo Shen
2013-07-03 1:33 ` Bo Shen
2013-07-03 1:33 ` Bo Shen
2013-07-03 1:33 ` Bo Shen
2013-07-03 7:36 ` Lars-Peter Clausen
2013-07-03 7:36 ` Lars-Peter Clausen
2013-07-03 7:36 ` Lars-Peter Clausen
2013-07-03 7:57 ` Bo Shen [this message]
2013-07-03 7:57 ` Bo Shen
2013-07-03 7:57 ` Bo Shen
2013-07-03 7:57 ` Bo Shen
2013-07-03 8:08 ` Lars-Peter Clausen
2013-07-03 8:08 ` Lars-Peter Clausen
2013-07-03 8:08 ` Lars-Peter Clausen
2013-07-03 8:13 ` Bo Shen
2013-07-03 8:13 ` [alsa-devel] " Bo Shen
2013-07-03 8:13 ` Bo Shen
2013-07-03 8:13 ` Bo Shen
-- strict thread matches above, loose matches on Subject: below --
2013-07-02 7:55 [PATCH 0/2] " Bo Shen
2013-07-02 7:55 ` Bo Shen
2013-07-02 7:55 ` [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback Bo Shen
2013-07-02 7:55 ` Bo Shen
2013-07-02 7:55 ` [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework Bo Shen
2013-07-02 7:55 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D3D969.1060308@atmel.com \
--to=voice.shen@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.