Possible bug in src/Makefile.am

Possible bug in src/Makefile.am

[Mark Kirkwood]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

I noticed when building with prefix=/usr/local that the install step 
produced an usr/local/sbin hierarchy *under* /usr/local (i.e 
/usr/local/usr/local/sbin) with ceph_disk and friends (i.e 
ceph_sbin_SCRIPTS) therein. I am guessing that these should actually be 
installed in /usr/local/sbin (i.e prefix/sbin).

The attached patch does this.

Regards

Mark

[-- Attachment #2: src-Makefile.am.patch --]
[-- Type: text/x-patch, Size: 380 bytes --]

diff --git a/src/Makefile.am b/src/Makefile.am
index c1a7e80..21f30dd 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -28,7 +28,7 @@ bin_PROGRAMS =
 bin_DEBUGPROGRAMS =
 sbin_PROGRAMS =
 # like sbin_SCRIPTS but can be used to install to e.g. /usr/sbin
-ceph_sbindir = $(prefix)$(sbindir)
+ceph_sbindir = $(sbindir)
 ceph_sbin_SCRIPTS = \
 	ceph-disk \
 	ceph-disk-prepare \

Re: Possible bug in src/Makefile.am

[Mark Kirkwood]

It seems this has been noted previously (just...):

http://tracker.ceph.com/issues/5492

Blast, I was just a bit slow :-) , should have posted when I first 
noticed this a week or so ago!

Regards

Mark

On 07/07/13 17:15, Mark Kirkwood wrote:
> I noticed when building with prefix=/usr/local that the install step
> produced an usr/local/sbin hierarchy *under* /usr/local (i.e
> /usr/local/usr/local/sbin) with ceph_disk and friends (i.e
> ceph_sbin_SCRIPTS) therein. I am guessing that these should actually be
> installed in /usr/local/sbin (i.e prefix/sbin).
>
> The attached patch does this.
>
> Regards
>
> Mark