From: George Cherian <george.cherian@ti.com>
To: balbi@ti.com
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux@arm.linux.org.uk, benoit.cousson@linaro.org, afzal@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node
Date: Tue, 9 Jul 2013 16:51:35 +0530 [thread overview]
Message-ID: <51DBF23F.20103@ti.com> (raw)
In-Reply-To: <20130709102022.GH5552@arwen.pp.htv.fi>
On 7/9/2013 3:50 PM, Felipe Balbi wrote:
> On Tue, Jul 09, 2013 at 02:47:26PM +0530, George Cherian wrote:
>> Adds device node for HS USB Host module for AM437x
>>
>> changes from v1
>>
>> renamed synopsis to snps
>> removed flag tx-fifo-resize
> the patch revision changes don't need to go to the commit log,
> they should be placed after the tearline (---) and before the diffstat.
>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ddc1df7..c9e0da8 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -64,5 +64,23 @@
>> compatible = "ti,am4372-counter32k","ti,omap-counter32k";
>> reg = <0x44e86000 0x40>;
>> };
>> +
>> + usb_otg_hs1: am4372_dwc3@48380000 {
> dtsi should always have status = "disabled"; no ?
>
>> + compatible = "ti,am437x-dwc3";
>> + reg = <0x48380000 0x1ff>;
> weird size, shouldn't this be 0x200 ?
okay
>> + interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + utmi-mode = <1>;
>> + ranges;
>> +
>> + dwc3@48390000 {
> dtsi should always have status = "disabled"; no ?
okay
>
>> + compatible = "snps,dwc3";
>> + reg = <0x48390000 0xcfff>;
> weird size, shouldn't this be 0xd000 then the size would be exactly
> 52KiB
okay
>> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>> + };
>> +
> there two trailing tabs on this line.
>
> Another thing: am437x has 4 instances of this IP, why are you adding
> only one ?
AM437x has got only 2 instances. I have verified only one on HAPS so
adding only one.
> And why aren't you pasing the PHY nodes here ? The device
> won't work without its PHYs.
Yes true, again in HAPS I didnt have any PHY configuration to be done.
>
--
-George
WARNING: multiple messages have this Message-ID (diff)
From: george.cherian@ti.com (George Cherian)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node
Date: Tue, 9 Jul 2013 16:51:35 +0530 [thread overview]
Message-ID: <51DBF23F.20103@ti.com> (raw)
In-Reply-To: <20130709102022.GH5552@arwen.pp.htv.fi>
On 7/9/2013 3:50 PM, Felipe Balbi wrote:
> On Tue, Jul 09, 2013 at 02:47:26PM +0530, George Cherian wrote:
>> Adds device node for HS USB Host module for AM437x
>>
>> changes from v1
>>
>> renamed synopsis to snps
>> removed flag tx-fifo-resize
> the patch revision changes don't need to go to the commit log,
> they should be placed after the tearline (---) and before the diffstat.
>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ddc1df7..c9e0da8 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -64,5 +64,23 @@
>> compatible = "ti,am4372-counter32k","ti,omap-counter32k";
>> reg = <0x44e86000 0x40>;
>> };
>> +
>> + usb_otg_hs1: am4372_dwc3 at 48380000 {
> dtsi should always have status = "disabled"; no ?
>
>> + compatible = "ti,am437x-dwc3";
>> + reg = <0x48380000 0x1ff>;
> weird size, shouldn't this be 0x200 ?
okay
>> + interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + utmi-mode = <1>;
>> + ranges;
>> +
>> + dwc3 at 48390000 {
> dtsi should always have status = "disabled"; no ?
okay
>
>> + compatible = "snps,dwc3";
>> + reg = <0x48390000 0xcfff>;
> weird size, shouldn't this be 0xd000 then the size would be exactly
> 52KiB
okay
>> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>> + };
>> +
> there two trailing tabs on this line.
>
> Another thing: am437x has 4 instances of this IP, why are you adding
> only one ?
AM437x has got only 2 instances. I have verified only one on HAPS so
adding only one.
> And why aren't you pasing the PHY nodes here ? The device
> won't work without its PHYs.
Yes true, again in HAPS I didnt have any PHY configuration to be done.
>
--
-George
WARNING: multiple messages have this Message-ID (diff)
From: George Cherian <george.cherian@ti.com>
To: <balbi@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux@arm.linux.org.uk>,
<benoit.cousson@linaro.org>, <afzal@ti.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node
Date: Tue, 9 Jul 2013 16:51:35 +0530 [thread overview]
Message-ID: <51DBF23F.20103@ti.com> (raw)
In-Reply-To: <20130709102022.GH5552@arwen.pp.htv.fi>
On 7/9/2013 3:50 PM, Felipe Balbi wrote:
> On Tue, Jul 09, 2013 at 02:47:26PM +0530, George Cherian wrote:
>> Adds device node for HS USB Host module for AM437x
>>
>> changes from v1
>>
>> renamed synopsis to snps
>> removed flag tx-fifo-resize
> the patch revision changes don't need to go to the commit log,
> they should be placed after the tearline (---) and before the diffstat.
>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index ddc1df7..c9e0da8 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -64,5 +64,23 @@
>> compatible = "ti,am4372-counter32k","ti,omap-counter32k";
>> reg = <0x44e86000 0x40>;
>> };
>> +
>> + usb_otg_hs1: am4372_dwc3@48380000 {
> dtsi should always have status = "disabled"; no ?
>
>> + compatible = "ti,am437x-dwc3";
>> + reg = <0x48380000 0x1ff>;
> weird size, shouldn't this be 0x200 ?
okay
>> + interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + utmi-mode = <1>;
>> + ranges;
>> +
>> + dwc3@48390000 {
> dtsi should always have status = "disabled"; no ?
okay
>
>> + compatible = "snps,dwc3";
>> + reg = <0x48390000 0xcfff>;
> weird size, shouldn't this be 0xd000 then the size would be exactly
> 52KiB
okay
>> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>> + };
>> +
> there two trailing tabs on this line.
>
> Another thing: am437x has 4 instances of this IP, why are you adding
> only one ?
AM437x has got only 2 instances. I have verified only one on HAPS so
adding only one.
> And why aren't you pasing the PHY nodes here ? The device
> won't work without its PHYs.
Yes true, again in HAPS I didnt have any PHY configuration to be done.
>
--
-George
next prev parent reply other threads:[~2013-07-09 11:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 9:17 [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node George Cherian
2013-07-09 9:17 ` George Cherian
2013-07-09 9:17 ` George Cherian
2013-07-09 10:20 ` Felipe Balbi
2013-07-09 10:20 ` Felipe Balbi
2013-07-09 10:20 ` Felipe Balbi
2013-07-09 11:21 ` George Cherian [this message]
2013-07-09 11:21 ` George Cherian
2013-07-09 11:21 ` George Cherian
2013-07-09 11:27 ` Felipe Balbi
2013-07-09 11:27 ` Felipe Balbi
2013-07-09 11:27 ` Felipe Balbi
2013-07-09 11:52 ` George Cherian
2013-07-09 11:52 ` George Cherian
2013-07-09 11:52 ` George Cherian
2013-07-09 12:03 ` Felipe Balbi
2013-07-09 12:03 ` Felipe Balbi
2013-07-09 12:03 ` Felipe Balbi
2013-07-09 10:32 ` Mohammed, Afzal
2013-07-09 10:32 ` Mohammed, Afzal
2013-07-09 10:32 ` Mohammed, Afzal
2013-07-09 14:07 ` Sergei Shtylyov
2013-07-09 14:07 ` Sergei Shtylyov
2013-07-09 15:01 ` Sergei Shtylyov
2013-07-09 15:01 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DBF23F.20103@ti.com \
--to=george.cherian@ti.com \
--cc=afzal@ti.com \
--cc=balbi@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.