From: George Cherian <george.cherian@ti.com>
To: balbi@ti.com
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux@arm.linux.org.uk, benoit.cousson@linaro.org, afzal@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node
Date: Tue, 9 Jul 2013 17:22:43 +0530 [thread overview]
Message-ID: <51DBF98B.1050104@ti.com> (raw)
In-Reply-To: <20130709112751.GI5552@arwen.pp.htv.fi>
On 7/9/2013 4:57 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jul 09, 2013 at 04:51:35PM +0530, George Cherian wrote:
>>>> + compatible = "snps,dwc3";
>>>> + reg = <0x48390000 0xcfff>;
>>> weird size, shouldn't this be 0xd000 then the size would be exactly
>>> 52KiB
>> okay
> btw, the reason here is that when you call devm_ioremap_resource(), that
> will call resource_size() which does:
>
> size = res->end - res->start - 1;
>
> so you need this extra 1 on the size when passing it via DT.
agreed.
>>> Another thing: am437x has 4 instances of this IP, why are you adding
>>> only one ?
>> AM437x has got only 2 instances. I have verified only one on HAPS so
>> adding only one.
> weird, on my TRM I see for dwc3 but 2 PHYs.
Please confirm whether you are looking at am437x TRM or dra7x TRM?
dra7x has 4 dwc3 and 2 internal phys and 2 external phys
>>> And why aren't you pasing the PHY nodes here ? The device
>>> won't work without its PHYs.
>> Yes true, again in HAPS I didnt have any PHY configuration to be done.
> alright, but we should still pass the PHY right ? once silicon comes,
> we want this to work without any further changers.
okay will add phy nodes and 2 instances of dwc3.
--
-George
WARNING: multiple messages have this Message-ID (diff)
From: george.cherian@ti.com (George Cherian)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node
Date: Tue, 9 Jul 2013 17:22:43 +0530 [thread overview]
Message-ID: <51DBF98B.1050104@ti.com> (raw)
In-Reply-To: <20130709112751.GI5552@arwen.pp.htv.fi>
On 7/9/2013 4:57 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jul 09, 2013 at 04:51:35PM +0530, George Cherian wrote:
>>>> + compatible = "snps,dwc3";
>>>> + reg = <0x48390000 0xcfff>;
>>> weird size, shouldn't this be 0xd000 then the size would be exactly
>>> 52KiB
>> okay
> btw, the reason here is that when you call devm_ioremap_resource(), that
> will call resource_size() which does:
>
> size = res->end - res->start - 1;
>
> so you need this extra 1 on the size when passing it via DT.
agreed.
>>> Another thing: am437x has 4 instances of this IP, why are you adding
>>> only one ?
>> AM437x has got only 2 instances. I have verified only one on HAPS so
>> adding only one.
> weird, on my TRM I see for dwc3 but 2 PHYs.
Please confirm whether you are looking at am437x TRM or dra7x TRM?
dra7x has 4 dwc3 and 2 internal phys and 2 external phys
>>> And why aren't you pasing the PHY nodes here ? The device
>>> won't work without its PHYs.
>> Yes true, again in HAPS I didnt have any PHY configuration to be done.
> alright, but we should still pass the PHY right ? once silicon comes,
> we want this to work without any further changers.
okay will add phy nodes and 2 instances of dwc3.
--
-George
WARNING: multiple messages have this Message-ID (diff)
From: George Cherian <george.cherian@ti.com>
To: <balbi@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux@arm.linux.org.uk>,
<benoit.cousson@linaro.org>, <afzal@ti.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node
Date: Tue, 9 Jul 2013 17:22:43 +0530 [thread overview]
Message-ID: <51DBF98B.1050104@ti.com> (raw)
In-Reply-To: <20130709112751.GI5552@arwen.pp.htv.fi>
On 7/9/2013 4:57 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jul 09, 2013 at 04:51:35PM +0530, George Cherian wrote:
>>>> + compatible = "snps,dwc3";
>>>> + reg = <0x48390000 0xcfff>;
>>> weird size, shouldn't this be 0xd000 then the size would be exactly
>>> 52KiB
>> okay
> btw, the reason here is that when you call devm_ioremap_resource(), that
> will call resource_size() which does:
>
> size = res->end - res->start - 1;
>
> so you need this extra 1 on the size when passing it via DT.
agreed.
>>> Another thing: am437x has 4 instances of this IP, why are you adding
>>> only one ?
>> AM437x has got only 2 instances. I have verified only one on HAPS so
>> adding only one.
> weird, on my TRM I see for dwc3 but 2 PHYs.
Please confirm whether you are looking at am437x TRM or dra7x TRM?
dra7x has 4 dwc3 and 2 internal phys and 2 external phys
>>> And why aren't you pasing the PHY nodes here ? The device
>>> won't work without its PHYs.
>> Yes true, again in HAPS I didnt have any PHY configuration to be done.
> alright, but we should still pass the PHY right ? once silicon comes,
> we want this to work without any further changers.
okay will add phy nodes and 2 instances of dwc3.
--
-George
next prev parent reply other threads:[~2013-07-09 11:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 9:17 [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node George Cherian
2013-07-09 9:17 ` George Cherian
2013-07-09 9:17 ` George Cherian
2013-07-09 10:20 ` Felipe Balbi
2013-07-09 10:20 ` Felipe Balbi
2013-07-09 10:20 ` Felipe Balbi
2013-07-09 11:21 ` George Cherian
2013-07-09 11:21 ` George Cherian
2013-07-09 11:21 ` George Cherian
2013-07-09 11:27 ` Felipe Balbi
2013-07-09 11:27 ` Felipe Balbi
2013-07-09 11:27 ` Felipe Balbi
2013-07-09 11:52 ` George Cherian [this message]
2013-07-09 11:52 ` George Cherian
2013-07-09 11:52 ` George Cherian
2013-07-09 12:03 ` Felipe Balbi
2013-07-09 12:03 ` Felipe Balbi
2013-07-09 12:03 ` Felipe Balbi
2013-07-09 10:32 ` Mohammed, Afzal
2013-07-09 10:32 ` Mohammed, Afzal
2013-07-09 10:32 ` Mohammed, Afzal
2013-07-09 14:07 ` Sergei Shtylyov
2013-07-09 14:07 ` Sergei Shtylyov
2013-07-09 15:01 ` Sergei Shtylyov
2013-07-09 15:01 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DBF98B.1050104@ti.com \
--to=george.cherian@ti.com \
--cc=afzal@ti.com \
--cc=balbi@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.