From: Kevin Hilman <khilman@linaro.org>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tony@atomide.com, paul@pwsan.com, benoit.cousson@gmail.com,
r.sricharan@ti.com, ambresh@ti.com
Subject: Re: [PATCH 08/12] ARM: DRA7: Reuse the omap44xx_restart and fix the device instance
Date: Sun, 14 Jul 2013 13:12:48 +0100 [thread overview]
Message-ID: <51E295C0.4080309@linaro.org> (raw)
In-Reply-To: <1373355139-12487-9-git-send-email-rnayak@ti.com>
On 07/09/2013 08:32 AM, Rajendra Nayak wrote:
> The omap44xx_restart used on omap4 and omap5 devices can be reused
> on dra7 devices as well. The device instance however is different
> across omap5 and dra7 as compared to omap4. So fix this for omap5
> as well as dra7.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: R Sricharan <r.sricharan@ti.com>
[...]
> @@ -165,10 +168,19 @@ int omap4_prminst_deassert_hardreset(u8 shift, u8 part, s16 inst,
> void omap4_prminst_global_warm_sw_reset(void)
> {
> u32 v;
> -
> - v = omap4_prminst_read_inst_reg(OMAP4430_PRM_PARTITION,
> - OMAP4430_PRM_DEVICE_INST,
> - OMAP4_PRM_RSTCTRL_OFFSET);
> + s16 dev_inst;
> +
> + if (cpu_is_omap44xx())
> + dev_inst = OMAP4430_PRM_DEVICE_INST;
Please don't use cpu_is_* (or soc_is_*) at runtime. Rather, the right
offset/instance should be setup at init time.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/12] ARM: DRA7: Reuse the omap44xx_restart and fix the device instance
Date: Sun, 14 Jul 2013 13:12:48 +0100 [thread overview]
Message-ID: <51E295C0.4080309@linaro.org> (raw)
In-Reply-To: <1373355139-12487-9-git-send-email-rnayak@ti.com>
On 07/09/2013 08:32 AM, Rajendra Nayak wrote:
> The omap44xx_restart used on omap4 and omap5 devices can be reused
> on dra7 devices as well. The device instance however is different
> across omap5 and dra7 as compared to omap4. So fix this for omap5
> as well as dra7.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: R Sricharan <r.sricharan@ti.com>
[...]
> @@ -165,10 +168,19 @@ int omap4_prminst_deassert_hardreset(u8 shift, u8 part, s16 inst,
> void omap4_prminst_global_warm_sw_reset(void)
> {
> u32 v;
> -
> - v = omap4_prminst_read_inst_reg(OMAP4430_PRM_PARTITION,
> - OMAP4430_PRM_DEVICE_INST,
> - OMAP4_PRM_RSTCTRL_OFFSET);
> + s16 dev_inst;
> +
> + if (cpu_is_omap44xx())
> + dev_inst = OMAP4430_PRM_DEVICE_INST;
Please don't use cpu_is_* (or soc_is_*) at runtime. Rather, the right
offset/instance should be setup at init time.
Kevin
next prev parent reply other threads:[~2013-07-15 5:52 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 7:32 [PATCH 00/12] DRA7xx PRCM, hwmod and DT data Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 01/12] ARM: DRA7: PRM: Add DRA7XX register definitions Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 02/12] ARM: DRA7: CM: Add DRA7XX register defines Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 03/12] ARM: DRA7: CM: Add minimal regbit shifts Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 04/12] ARM: DRA7: PRCM: Add DRA7XX local MPU PRCM regsiters Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 05/12] ARM: DRA7: clockdomain: Add DRA7XX data and update header Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 06/12] ARM: DRA7: powerdomain: " Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 07/12] ARM: DRA7: powerdomain: Handle missing vc/vp Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 08/12] ARM: DRA7: Reuse the omap44xx_restart and fix the device instance Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-14 12:12 ` Kevin Hilman [this message]
2013-07-14 12:12 ` Kevin Hilman
2013-07-09 7:32 ` [PATCH 09/12] ARM: DRA7: hwmod: Create initial DRA7XX SoC data Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 8:31 ` Tony Lindgren
2013-07-09 8:31 ` Tony Lindgren
2013-07-09 10:14 ` Rajendra Nayak
2013-07-09 10:14 ` Rajendra Nayak
2013-07-09 11:36 ` Tony Lindgren
2013-07-09 11:36 ` Tony Lindgren
2013-07-15 9:22 ` Rajendra Nayak
2013-07-15 9:22 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 10/12] ARM: DRA7: Enable PM framework initializations Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 11/12] ARM: DRA7: Add the build support in omap2plus Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 12/12] ARM: DRA7: dts: Add the dts files for dra7 SoC and dra7-evm board Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-08-21 2:10 ` [PATCH 00/12] DRA7xx PRCM, hwmod and DT data Paul Walmsley
2013-08-21 2:10 ` Paul Walmsley
2013-08-21 8:55 ` Paul Walmsley
2013-08-21 8:55 ` Paul Walmsley
2013-08-21 9:16 ` Rajendra Nayak
2013-08-21 9:16 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E295C0.4080309@linaro.org \
--to=khilman@linaro.org \
--cc=ambresh@ti.com \
--cc=benoit.cousson@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=r.sricharan@ti.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.